2.5.20 config forward references to CONFIG_X86_LOCAL_APIC

DISCUSSION Keith Owens 3 participants 4 messages Jun 5, 2002

Share & tools

Keith Owens

author

2002-06-05 04:55 UTC #0 lore raw

arch/i386/config.in tests CONFIG_X86_LOCAL_APIC before it is defined.
dep_bool 'check for P4 thermal throttling interrupt.' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_LOCAL_APIC

arch/i386/config.in also includes drivers/acpi/Config.in which tests CONFIG_X86_LOCAL_APIC before this variable is defined via CONFIG_SMP.

The forward references result in incorrect configurations when switching config from one cpu type to another or from SMP to UP.

Zwane Mwaikambo

2002-06-05 08:36 UTC #1 lore raw

Hi Keith,

Quoted 8 lines · Keith Owens

arch/i386/config.in tests CONFIG_X86_LOCAL_APIC before it is defined.
dep_bool 'check for P4 thermal throttling interrupt.' CONFIG_X86_MCE_P4THERMAL $CONFIG_X86_MCE $CONFIG_X86_LOCAL_APIC
arch/i386/config.in also includes drivers/acpi/Config.in which tests CONFIG_X86_LOCAL_APIC before this variable is defined via CONFIG_SMP.
The forward references result in incorrect configurations when switching config from one cpu type to another or from SMP to UP.

We could move the conditional to preprocessor time by wrapping certain bits in #ifdef (urgh), what really is the more elegant way of doing it?

Regards,
Zwane Mwaikambo

Signature · 1 line

http://function.linuxpower.ca

Dave Jones

2002-06-05 10:14 UTC #2 lore raw

In reply to Keith Owens

Quoted 4 lines · Zwane Mwaikambo

Quoted 2 lines
The forward references result in incorrect configurations when switching config from one cpu type to another or from SMP to UP.
We could move the conditional to preprocessor time by wrapping certain bits in #ifdef (urgh), what really is the more elegant way of doing it?

Doing the CONFIG_X86_LOCAL_APIC definition earlier.

Dave.

Signature · 2 lines

| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

Zwane Mwaikambo

2002-06-05 10:25 UTC #3 lore raw

Quoted 7 lines · Dave Jones

Quoted 4 lines · Zwane Mwaikambo
Quoted 2 lines
The forward references result in incorrect configurations when switching config from one cpu type to another or from SMP to UP.
We could move the conditional to preprocessor time by wrapping certain bits in #ifdef (urgh), what really is the more elegant way of doing it?
Doing the CONFIG_X86_LOCAL_APIC definition earlier.

... so simple it hurts ...

Signature · 1 line

http://function.linuxpower.ca