pci: pcie-designware: Remove irq_desc abuse
Jingoo Han
Acked-byT24gTW9uZGF5LCBGZWJydWFyeSAyNCwgMjAxNCA2OjQwIEFNLCBUaG9tYXMgR2xlaXhuZXIgd3Jv dGU6DQo+IA0KPiBUaGVyZSBpcyBubyByZWFzb24gdG8gY2FyZSBhYm91dCBpcnFfZGVzYyBpbiB0 aGF0IGNvbnRleHQsIGVzY3BlY2lhbGx5DQo+IGFzIGlycV9kYXRhIGZvciB0aGF0IGludGVycnVw dCBpcyByZXRyaWV2ZWQgYXMgd2VsbC4NCj4gDQo+IFVzZSB0aGUgcHJvcGVyIGFjY2Vzc29yIGZv ciB0aGUgbXNpIGRlc2NyaXB0b3INCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBHbGVpeG5l ciA8dGdseEBsaW51dHJvbml4LmRlPg0KPiBDYzogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29v Z2xlLmNvbT4NCj4gQ2M6IEppbmdvbyBIYW4gPGpnMS5oYW5Ac2Ftc3VuZy5jb20+DQo+IENjOiBN b2hpdCBLdW1hciA8bW9oaXQua3VtYXJAc3QuY29tPg0KPiBDYzogcGNpIDxsaW51eC1wY2lAdmdl ci5rZXJuZWwub3JnPg0KDQpBY2tlZC1ieTogSmluZ29vIEhhbiA8amcxLmhhbkBzYW1zdW5nLmNv bT4NCg0KQSBmZXcgZGF5cyBhZ28sIEkgbm90aWNlZCB0aGF0IGlycV9kYXRhX2dldF9tc2koKSBj YW4gYmUgdXNlZC4NCkhvd2V2ZXIsIEkgZGlkIG5vdCBzdWJtaXQgdGhlIHNhbWUgcGF0Y2guIEkg cmVhbGx5IGFwcHJlY2lhdGUNCnlvdXIgcGF0Y2guIDotKQ0KDQpCZXN0IHJlZ2FyZHMsDQpKaW5n b28gSGFuDQoNCj4gLS0tDQo+ICBkcml2ZXJzL3BjaS9ob3N0L3BjaWUtZGVzaWdud2FyZS5jIHwg ICAgNCArLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25z KC0pDQo+IA0KPiBJbmRleDogdGlwL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMN Cj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQ0KPiAtLS0gdGlwLm9yaWcvZHJpdmVycy9wY2kvaG9zdC9wY2llLWRlc2ln bndhcmUuYw0KPiArKysgdGlwL2RyaXZlcnMvcGNpL2hvc3QvcGNpZS1kZXNpZ253YXJlLmMNCj4g QEAgLTI5NCwxNCArMjk0LDEyIEBAIG5vX3ZhbGlkX2lycToNCj4gIHN0YXRpYyB2b2lkIGNsZWFy X2lycSh1bnNpZ25lZCBpbnQgaXJxKQ0KPiAgew0KPiAgCXVuc2lnbmVkIGludCBwb3MsIG52ZWM7 DQo+IC0Jc3RydWN0IGlycV9kZXNjICpkZXNjOw0KPiAgCXN0cnVjdCBtc2lfZGVzYyAqbXNpOw0K PiAgCXN0cnVjdCBwY2llX3BvcnQgKnBwOw0KPiAgCXN0cnVjdCBpcnFfZGF0YSAqZGF0YSA9IGly cV9nZXRfaXJxX2RhdGEoaXJxKTsNCj4gDQo+ICAJLyogZ2V0IHRoZSBwb3J0IHN0cnVjdHVyZSAq Lw0KPiAtCWRlc2MgPSBpcnFfdG9fZGVzYyhpcnEpOw0KPiAtCW1zaSA9IGlycV9kZXNjX2dldF9t c2lfZGVzYyhkZXNjKTsNCj4gKwltc2kgPSBpcnFfZGF0YV9nZXRfbXNpKGRhdGEpOw0KPiAgCXBw ID0gc3lzX3RvX3BjaWUobXNpLT5kZXYtPmJ1cy0+c3lzZGF0YSk7DQo+ICAJaWYgKCFwcCkgew0K PiAgCQlCVUcoKTs=
Quoted 7 lines · Jingoo Han
Quoted 6 lines · Thomas Gleixner
There is no reason to care about
irq_descin that context, escpecially asirq_datafor that interrupt is retrieved as well.Use the proper accessor for the msi descriptor
Quoted 7 lines
Quoted 5 lines
Signed-off-by Thomas Gleixner <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Jingoo Han <[email protected]>Cc Mohit Kumar <[email protected]>Cc pci <[email protected]>Acked-by Jingoo Han <[email protected]>
Thomas, I assume you'll merge this along with the rest of your series.
I don't have any pending changes in this area.
Bjorn
Quoted 31 lines
A few days ago, I noticed that
irq_data_get_msi()can be used. However, I did not submit the same patch. I really appreciate your patch. :-)Best regards,
Jingoo HanQuoted 24 lines
--- drivers/pci/host/pcie-designware.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)Index:
tip/drivers/pci/host/pcie-designware.c
===================================================================drivers/pci/host/pcie-designware.c +1
-3@@ -294,14 +294,12 @@ no_valid_irq:static void clear_irq (unsigned int irq) {unsigned int pos, nvec; -struct irq_desc *desc;struct msi_desc *msi;struct pcie_port *pp;struct irq_data *data =irq_get_irq_data (irq);/* get the port structure */ - desc =irq_to_desc (irq); - msi =irq_desc_get_msi_desc (desc); + msi =irq_data_get_msi (data); pp =sys_to_pcie (msi->dev->bus->sysdata);if (!pp) {BUG ();
Quoted 14 lines · Bjorn Helgaas
Quoted 13 lines · Jingoo Han
Quoted 11 lines · Thomas Gleixner
There is no reason to care about
irq_descin that context, escpecially asirq_datafor that interrupt is retrieved as well.Use the proper accessor for the msi descriptor
Signed-off-by Thomas Gleixner <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Jingoo Han <[email protected]>Cc Mohit Kumar <[email protected]>Cc pci <[email protected]>
Quoted 6 lines
Quoted 1 line
Acked-by Jingoo Han <[email protected]>Acked-by Bjorn Helgaas <[email protected]>Thomas, I assume you'll merge this along with the rest of your series.
I don't have any pending changes in this area.
I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine.
Thanks,
tglx
Bjorn Helgaas
maintainerQuoted 17 lines · Thomas Gleixner
Quoted 16 lines · Bjorn Helgaas
Quoted 14 lines · Jingoo Han
Quoted 11 lines · Thomas Gleixner
There is no reason to care about
irq_descin that context, escpecially asirq_datafor that interrupt is retrieved as well.Use the proper accessor for the msi descriptor
Signed-off-by Thomas Gleixner <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Jingoo Han <[email protected]>Cc Mohit Kumar <[email protected]>Cc pci <[email protected]>Acked-by Jingoo Han <[email protected]>
Quoted 7 lines
Quoted 4 lines
Acked-by Bjorn Helgaas <[email protected]>Thomas, I assume you'll merge this along with the rest of your series.
I don't have any pending changes in this area.I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine.
I never know what to do with these. I suggested that you pick it up so the whole series would be together, because I assumed it would make more sense in the git history to have all these similar changes grouped together. But maybe that really doesn't matter.
What's the recommended practice?
Bjorn
Quoted 26 lines · Bjorn Helgaas
Quoted 17 lines · Thomas Gleixner
Quoted 16 lines · Bjorn Helgaas
Quoted 14 lines · Jingoo Han
Quoted 11 lines · Thomas Gleixner
There is no reason to care about
irq_descin that context, escpecially asirq_datafor that interrupt is retrieved as well.Use the proper accessor for the msi descriptor
Signed-off-by Thomas Gleixner <[email protected]>Cc Bjorn Helgaas <[email protected]>Cc Jingoo Han <[email protected]>Cc Mohit Kumar <[email protected]>Cc pci <[email protected]>Acked-by Jingoo Han <[email protected]>Quoted 7 lines
Quoted 4 lines
Acked-by Bjorn Helgaas <[email protected]>Thomas, I assume you'll merge this along with the rest of your series.
I don't have any pending changes in this area.I can do, but it does not depend on anything else, so you can pick it up as well. Either way is fine.
Quoted 6 lines
I never know what to do with these. I suggested that you pick it up so the whole series would be together, because I assumed it would make more sense in the git history to have all these similar changes grouped together. But maybe that really doesn't matter.
What's the recommended practice?
Dunno. There is no rule. I'll merge it up with the rest of the lot.
Thanks,
tglx