Skip to contentSkip to conversation

struct export_operations: adjust comments to match current members

PATCH In review David Howells 3 participants 3 messages Mar 14, 2008 Filesystems exportfs

lore
Share & tools
lore

David Howells

author
#0 lore raw

PATCH 1/1 struct export_operations: adjust comments to match current members

From: "Marc Dionne" <[email protected]>

The comments in the definition of struct export_operations don't match the current members.

Add a comment for the 2 new functions and remove 2 comments for unused ones.

Signed-off-by Marc Dionne <[email protected]>
Acked-by David Howells <[email protected]>
---
 include/linux/exportfs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/exportfs.h +2 -2
index 51d2141..adcbb05 100644
@@ -49,11 +49,11 @@ struct fid {
 
 /**
  * struct export_operations - for nfsd to communicate with file systems
- * @decode_fh:      decode a file handle fragment and return a &struct dentry
  * @encode_fh:      encode a file handle fragment from a dentry
+ * @fh_to_dentry:   find the implied object and get a dentry for it
+ * @fh_to_parent:   find the implied object's parent and get a dentry for it
  * @get_name:       find the name for a given inode in a given directory
  * @get_parent:     find the parent of a given directory
- * @get_dentry:     find a dentry for the inode given a file handle

sub-fragment
*
* See Documentation/filesystems/Exporting for details on how to use
* this interface correctly.

#2 lore raw
In reply to David Howells
Quoted 10 lines · On Fri, 14 Mar 2008 13:11:29 +0000 David Howells <[email protected]> wrote:

From: "Marc Dionne" <[email protected]>

The comments in the definition of struct export_operations don't match the current members.

Add a comment for the 2 new functions and remove 2 comments for unused ones.

Signed-off-by Marc Dionne <[email protected]>
Acked-by David Howells <[email protected]>

I changed this to Signed-off-by:. You were in the delivery path.

Quoted 19 lines
---
 include/linux/exportfs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/exportfs.h +2 -2
index 51d2141..adcbb05 100644
@@ -49,11 +49,11 @@ struct fid {
 
 /**
  * struct export_operations - for nfsd to communicate with file systems
- * @decode_fh:      decode a file handle fragment and return a &struct dentry
  * @encode_fh:      encode a file handle fragment from a dentry
+ * @fh_to_dentry:   find the implied object and get a dentry for it
+ * @fh_to_parent:   find the implied object's parent and get a dentry for it
  * @get_name:       find the name for a given inode in a given directory
  * @get_parent:     find the parent of a given directory
- * @get_dentry:     find a dentry for the inode given a file handle
Quoted 1 line

sub-fragment

Someone is wordwrapping.

Quoted 3 lines

*
* See Documentation/filesystems/Exporting for details on how to use
* this interface correctly.