ACPI: DPTF: Driver name fixes and Kconfig update
cover ACPI: DPTF: Driver name fixes and Kconfig update
Hi,
These patches fix the names of two DPTF drivers to adhere to the sysfs file naming conventions and rework the DPTF part of Kconfig.
Please refer to the patch changelogs for details.
Thanks!
PATCH 1/2 ACPI: DPTF: Fix participant driver names
From: Rafael J. Wysocki <[email protected]>
Change the names of DPTF participant drivers to adhere to the sysfs file naming conventions (no spaces present in the name in particular).
--- drivers/acpi/dptf/dptf_pch_fivr.c | 2 +- drivers/acpi/dptf/dptf_power.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/dptf/dptf_pch_fivr.c +1 -1
@@ -114,7 +114,7 @@ static struct platform_driver pch_fivr_d .probe = pch_fivr_add, .remove = pch_fivr_remove, .driver = { - .name = "DPTF PCH FIVR", + .name = "dptf_pch_fivr", .acpi_match_table = pch_fivr_device_ids, }, };
drivers/acpi/dptf/dptf_power.c +1 -1
@@ -237,7 +237,7 @@ static struct platform_driver dptf_power .probe = dptf_power_add, .remove = dptf_power_remove, .driver = { - .name = "DPTF Platform Power", + .name = "dptf_power", .acpi_match_table = int3407_device_ids, }, };
Re: [PATCH 1/2] ACPI: DPTF: Fix participant driver names
Quoted 10 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Change the names of DPTF participant drivers to adhere to the sysfs file naming conventions (no spaces present in the name in particular).
Fixes 2ce6324eadb0 ("ACPI: DPTF: Add PCH FIVR participant driver")Fixes 6256ebd5daf9 ("ACPI / DPTF: Add DPTF power participantdriver")
Signed-off-by Rafael J. Wysocki <[email protected]>
Quoted 34 lines
--- drivers/acpi/dptf/dptf_pch_fivr.c | 2 +- drivers/acpi/dptf/dptf_power.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)Index:
linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
===================================================================drivers/acpi/dptf/dptf_pch_fivr.c +1
-1@@ -114,7 +114,7 @@ static struct platform_driver pch_fivr_d .probe = pch_fivr_add, .remove = pch_fivr_remove, .driver = { - .name = "DPTF PCH FIVR", + .name = "dptf_pch_fivr", .acpi_match_table = pch_fivr_device_ids, }, };Index:
linux-pm/drivers/acpi/dptf/dptf_power.c
===================================================================drivers/acpi/dptf/dptf_power.c +1
-1@@ -237,7 +237,7 @@ static struct platform_driver dptf_power .probe = dptf_power_add, .remove = dptf_power_remove, .driver = { - .name = "DPTF Platform Power", + .name = "dptf_power", .acpi_match_table = int3407_device_ids, }, };
Re: [PATCH 1/2] ACPI: DPTF: Fix participant driver names
In reply to Rafael J. WysockiQuoted 32 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Change the names of DPTF participant drivers to adhere to the sysfs file naming conventions (no spaces present in the name in particular).
Fixes 2ce6324eadb0 ("ACPI: DPTF: Add PCH FIVR participant driver")Fixes 6256ebd5daf9 ("ACPI / DPTF: Add DPTF power participant driver")Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/acpi/dptf/dptf_pch_fivr.c | 2 +- drivers/acpi/dptf/dptf_power.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)Index:
linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
===================================================================drivers/acpi/dptf/dptf_pch_fivr.c +1
-1@@ -114,7 +114,7 @@ static struct platform_driver pch_fivr_d .probe = pch_fivr_add, .remove = pch_fivr_remove, .driver = { - .name = "DPTF PCH FIVR", + .name = "dptf_pch_fivr", .acpi_match_table = pch_fivr_device_ids, }, };Index:
linux-pm/drivers/acpi/dptf/dptf_power.c
===================================================================
drivers/acpi/dptf/dptf_power.c static struct platform_driver dptf_power · line 243
Quoted 8 lines
drivers/acpi/dptf/dptf_power.c +1
-1@@ -237,7 +237,7 @@ static struct platform_driver dptf_power .probe = dptf_power_add, .remove = dptf_power_remove, .driver = { - .name = "DPTF Platform Power", + .name = "dptf_power", .acpi_match_table = int3407_device_ids, }, };
Signature · 4 lines
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG NürnbergPATCH 2/2 ACPI: DPTF: Add ACPI_DPTF Kconfig menu
In reply to Rafael J. WysockiFrom: Rafael J. Wysocki <[email protected]>
Add a Kconfig menu for Intel DPTF (Dynamic Platform and Thermal Framework), put both the existing participant drivers in it and set them to be built as modules by default.
While at it, do a few assorted cleanups for a good measure.
--- drivers/acpi/dptf/Kconfig | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-)
drivers/acpi/dptf/Kconfig +24 -5
@@ -1,8 +1,25 @@ # SPDX-License-Identifier: GPL-2.0 -config DPTF_POWER - tristate "DPTF Platform Power Participant" + +menuconfig ACPI_DPTF + bool "Intel DPTF (Dynamic Platform and Thermal Framework) Support" depends on X86 help + Intel Dynamic Platform and Thermal Framework (DPTF) is a platform + level hardware/software solution for power and thermal management. + + As a container for multiple power/thermal technologies, DPTF provides + a coordinated approach for different policies to effect the hardware + state of a system. + + For more information see: + <https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chromium-os/overview> + +if ACPI_DPTF + +config DPTF_POWER + tristate "Platform Power DPTF Participant" + default m + help This driver adds support for Dynamic Platform and Thermal Framework (DPTF) Platform Power Participant device (INT3407) support. This participant is responsible for exposing platform telemetry:
@@ -16,15 +33,17 @@ config DPTF_POWER the module will be called dptf_power. config DPTF_PCH_FIVR - tristate "DPTF PCH FIVR Participant" - depends on X86 + tristate "PCH FIVR DPTF Participant" + default m help This driver adds support for Dynamic Platform and Thermal Framework (DPTF) PCH FIVR Participant device support. This driver allows to - switch PCH FIVR (Fully Integrated Voltage Regulator) frequency. + switch the PCH FIVR (Fully Integrated Voltage Regulator) frequency. This participant is responsible for exposing: freq_mhz_low_clock freq_mhz_high_clock To compile this driver as a module, choose M here: the module will be called dptf_pch_fivr. + +endif
Re: [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu
Quoted 9 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Add a
Kconfigmenu for Intel DPTF (Dynamic Platform and Thermal Framework), put both the existing participant drivers in it and set them to be built as modules by default.While at it, do a few assorted cleanups for a good measure.
Signed-off-by Rafael J. Wysocki <[email protected]>
Quoted 73 lines
--- drivers/acpi/dptf/Kconfig | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-)Index: linux-pm/drivers/acpi/dptf/Kconfig
===================================================================drivers/acpi/dptf/Kconfig +3
-2@@ -1,8 +1,25 @@ # SPDX-License-Identifier: GPL-2.0 -config DPTF_POWER - tristate "DPTF Platform Power Participant" + +menuconfig ACPI_DPTF + bool "Intel DPTF (Dynamic Platform and Thermal Framework)Support"
drivers/acpi/dptf/Kconfig +1
-0depends on X86 help + Intel Dynamic Platform and Thermal Framework (DPTF) is aplatform
drivers/acpi/dptf/Kconfig +1
-0+ level hardware/software solution for power and thermalmanagement.
drivers/acpi/dptf/Kconfig +2
-0+ + As a container for multiple power/thermal technologies, DPTFprovides
drivers/acpi/dptf/Kconfig +1
-0+ a coordinated approach for different policies to effect thehardware
drivers/acpi/dptf/Kconfig +4
-0+ state of a system. + + For more information see: + <https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chromium-os/overview
Quoted 1 line
drivers/acpi/dptf/Kconfig +7
-0+ +if ACPI_DPTF + +config DPTF_POWER + tristate "Platform Power DPTF Participant" + default m + help This driver adds support for Dynamic Platform and ThermalFramework
drivers/acpi/dptf/Kconfig +0
-0(DPTF) Platform Power Participant device (INT3407) support. This participant is responsible for exposing platformtelemetry:
drivers/acpi/dptf/Kconfig +2
-2@@ -16,15 +33,17 @@ config DPTF_POWER the module will be called dptf_power. config DPTF_PCH_FIVR - tristate "DPTF PCH FIVR Participant" - depends on X86 + tristate "PCH FIVR DPTF Participant" + default m help This driver adds support for Dynamic Platform and ThermalFramework
(DPTF) PCH FIVR Participant device support. This driver
allows todrivers/acpi/dptf/Kconfig +0
-1- switch PCH FIVR (Fully Integrated Voltage Regulator)frequency.
drivers/acpi/dptf/Kconfig +1
-0+ switch the PCH FIVR (Fully Integrated Voltage Regulator)frequency.
drivers/acpi/dptf/Kconfig +2
-0This participant is responsible for exposing: freq_mhz_low_clock freq_mhz_high_clock To compile this driver as a module, choose M here: the module will be called dptf_pch_fivr. + +endif
Re: [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu
In reply to Rafael J. WysockiQuoted 25 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Add a
Kconfigmenu for Intel DPTF (Dynamic Platform and Thermal Framework), put both the existing participant drivers in it and set them to be built as modules by default.While at it, do a few assorted cleanups for a good measure.
Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/acpi/dptf/Kconfig | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-)Index: linux-pm/drivers/acpi/dptf/Kconfig
===================================================================drivers/acpi/dptf/Kconfig +3
-2@@ -1,8 +1,25 @@ # SPDX-License-Identifier: GPL-2.0 -config DPTF_POWER - tristate "DPTF Platform Power Participant" + +menuconfig ACPI_DPTF + bool "Intel DPTF (Dynamic Platform and Thermal Framework) Support" depends on X86
drivers/acpi/dptf/Kconfig line 15
Quoted 10 lines
drivers/acpi/dptf/Kconfig +9
-0help + Intel Dynamic Platform and Thermal Framework (DPTF) is a platform + level hardware/software solution for power and thermal management. + + As a container for multiple power/thermal technologies, DPTF provides + a coordinated approach for different policies to effect the hardware + state of a system. + + For more information see: + <https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chromium-os/overview>
Oh wow, they have a "(r)" for all rights reserved *in* *the* *URL*. OMG.
But yeah:
Thx Rafael.
Signature · 4 lines
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg