Skip to contentSkip to conversation

drivers/mmc/cor/bus: Delete redundant match function

DISCUSSION Uwe Kleine-König 2 participants 2 messages Nov 12, 2021 – Nov 19, 2021 2 messages not in the archive MMC, SD and SDIO

lore
Share & tools
lore

Uwe Kleine-König

author Acked-by
#1 lore raw
In reply to a message not in the archive
Quoted 28 lines · 李哲

HI:
I failed to send kernel patch mail with git sendmail,
could you help me take a look at the submitted patch?
the attachment is a patch file,
For convenience, I put the content of the patch in the body of the email

thanks. lizhe
patch :
|
From 40577316f4dbcf35061a14f27f7a777c2f4199a1 Mon Sep 17 00:00:00 2001
From: lizhe <[email protected]>
Date: Tue, 9 Nov 2021 10:13:43 -0800
Subject: [PATCH] drivers/mmc/cor/bus: Delete redundant match function

When the device and the driver are matching,
if the device or the bus to which the device driver belongs does not provide a match function,
then the device and the driver are matched by default. function 'driver_match_device' illustrates this mechanism. Because the return value of mmc_bus_match is 1, even if this function is not provided,
the function 'driver_match_device' returns 1,
so function 'mmc_bus_match' is redundant.

Quoted 1 line

Apart from how the patch is put in the mail, a maintainer responsible for picking patches up in this area will probably refuse because the name in the From line of your mail doesn't match the name used in the
Signed-off-by: line.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
#3 lore raw
In reply to a message not in the archive
Quoted 7 lines · lizhe

HI :
Does this patch need to be changed? If need to modify something, please let me know and I will fix it soon

Thanks
lizhe

Hi Lizhe,

Please read Documentation/process/submitting-patches.rst carefully. It guides you through the process of how to submit a patch.

For example, you need to use "git send-email" and we only use plain text emails.

Kind regards
Uffe

Quoted 55 lines
Quoted 44 lines · Uwe Kleine-König
Quoted 28 lines · 李哲

HI:
I failed to send kernel patch mail with git sendmail,
could you help me take a look at the submitted patch?
the attachment is a patch file,
For convenience, I put the content of the patch in the body of the email

thanks. lizhe
patch :
|
From 40577316f4dbcf35061a14f27f7a777c2f4199a1 Mon Sep 17 00:00:00 2001
From: lizhe <[email protected]>
Date: Tue, 9 Nov 2021 10:13:43 -0800
Subject: [PATCH] drivers/mmc/cor/bus: Delete redundant match function

When the device and the driver are matching,
if the device or the bus to which the device driver belongs does not provide a match function,
then the device and the driver are matched by default. function 'driver_match_device' illustrates this mechanism. Because the return value of mmc_bus_match is 1, even if this function is not provided,
the function 'driver_match_device' returns 1,
so function 'mmc_bus_match' is redundant.

Quoted 1 line

Apart from how the patch is put in the mail, a maintainer responsible for picking patches up in this area will probably refuse because the name in the From line of your mail doesn't match the name used in the
Signed-off-by: line.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |