Skip to contentSkip to conversation

tools/liblockdep: Build failure

PATCH Eunbong Song 4 participants 7 messages Apr 1, 2014 Locking primitives

lore
Share & tools
lore
#0 lore raw

There is tools/liblockdep build failure.
I have been trying to find the cause and i found commit id 63f9a7fde715352e0769302527670542a664b981 is the casue.

Author: Andi Kleen <[email protected]>
Date:   Sat Feb 8 08:52:01 2014 +0100

asmlinkage: Make lockdep_sys_exit asmlinkage

lockdep_sys_exit can be called from assembler code, so make it asmlinkage.

include/linux/lockdep.h +1 -1
index 92b1bfc..7df9aa6 100644
@@ -265,7 +265,7 @@ extern void lockdep_info(void);
 extern void lockdep_reset(void);
 extern void lockdep_reset_lock(struct lockdep_map *lock);
 extern void lockdep_free_key_range(void *start, unsigned long size);
-extern void lockdep_sys_exit(void);
+extern asmlinkage void lockdep_sys_exit(void);
 
 extern void lockdep_off(void);
 extern void lockdep_on(void);
kernel/locking/lockdep.c +1 -1
index eb8a547..c8b6753 100644
@@ -4191,7 +4191,7 @@ void debug_show_held_locks(struct task_struct *task)
 }
 EXPORT_SYMBOL_GPL(debug_show_held_locks);
 
-void lockdep_sys_exit(void)
+asmlinkage void lockdep_sys_exit(void)
 {
        struct task_struct *curr = current;

�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay����,j�f"톒쉹��묎�z_溫(�쉸듶줷"얎�m����G쳺�◀?솳鈺�&x�~뤳턨O뺞촾퇉v�^�m��� �띠�◀?뻀�

#1 lore raw

Hi.

I have same issue.

I investigated output of gcc -E and I found that asmlinkage macro isn't expanded as is expected.

$ grep asmlinkage common.o
asmlinkage extern void lockdep_sys_exit(void);
Quoted 43 lines · Eunbong Song

There is tools/liblockdep build failure.
I have been trying to find the cause and i found commit id 63f9a7fde715352e0769302527670542a664b981 is the casue.

Author: Andi Kleen <[email protected]>
Date:   Sat Feb 8 08:52:01 2014 +0100

asmlinkage: Make lockdep_sys_exit asmlinkage

lockdep_sys_exit can be called from assembler code, so make it asmlinkage.

include/linux/lockdep.h +1 -1
index 92b1bfc..7df9aa6 100644
@@ -265,7 +265,7 @@ extern void lockdep_info(void);
 extern void lockdep_reset(void);
 extern void lockdep_reset_lock(struct lockdep_map *lock);
 extern void lockdep_free_key_range(void *start, unsigned long size);
-extern void lockdep_sys_exit(void);
+extern asmlinkage void lockdep_sys_exit(void);
 
 extern void lockdep_off(void);
 extern void lockdep_on(void);
kernel/locking/lockdep.c +1 -1
index eb8a547..c8b6753 100644
@@ -4191,7 +4191,7 @@ void debug_show_held_locks(struct task_struct *task)
 }
 EXPORT_SYMBOL_GPL(debug_show_held_locks);
 
-void lockdep_sys_exit(void)
+asmlinkage void lockdep_sys_exit(void)
 {
        struct task_struct *curr = current;
#2 lore raw

More investigation reveals this:

(from common.o which is output of gcc -E)
# 1 "./uinclude/linux/linkage.h" 1

pwd is: linux/tools/lib/lockdep

$ cat ./uinclude/linux/linkage.h

/* empty file */

Have nice day
Robin Hack

Quoted 59 lines · Robin Hack

Hi.

I have same issue.

I investigated output of gcc -E and I found that asmlinkage macro isn't expanded as is expected.

$ grep asmlinkage common.o
asmlinkage extern void lockdep_sys_exit(void);
Quoted 36 lines · Eunbong Song

There is tools/liblockdep build failure.
I have been trying to find the cause and i found commit id 63f9a7fde715352e0769302527670542a664b981 is the casue.

Author: Andi Kleen <[email protected]>
Date:   Sat Feb 8 08:52:01 2014 +0100

asmlinkage: Make lockdep_sys_exit asmlinkage

lockdep_sys_exit can be called from assembler code, so make it asmlinkage.

include/linux/lockdep.h +1 -1
index 92b1bfc..7df9aa6 100644
@@ -265,7 +265,7 @@ extern void lockdep_info(void);
 extern void lockdep_reset(void);
 extern void lockdep_reset_lock(struct lockdep_map *lock);
 extern void lockdep_free_key_range(void *start, unsigned long size);
-extern void lockdep_sys_exit(void);
+extern asmlinkage void lockdep_sys_exit(void);
 
 extern void lockdep_off(void);
 extern void lockdep_on(void);
kernel/locking/lockdep.c +0 -0
index eb8a547..c8b6753 100644

kernel/locking/lockdep.c void debug_show_held_locks(struct task_struct *task) · line 4196

Quoted 7 lines
kernel/locking/lockdep.c +1 -1
@@ -4191,7 +4191,7 @@ void debug_show_held_locks(struct task_struct *task)
 }
 EXPORT_SYMBOL_GPL(debug_show_held_locks);
 
-void lockdep_sys_exit(void)
+asmlinkage void lockdep_sys_exit(void)
 {
        struct task_struct *curr = current;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#3 lore raw

From: Robin Hack <[email protected]>
Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h.

tools/lib/lockdep/uinclude/linux/linkage.h +17 -1
index fab00ff..6799a5b 100644
@@ -1,3 +1,19 @@
+#ifndef _LOCKDEP_ULINKAGE_H
+#define _LOCKDEP_ULINKAGE_H
 
-/* empty file */
+#if GCC_VERSION >= 40600
+/*
+ * Tell the optimizer that something else uses this function or variable.
+ */
+#define __visible __attribute__((externally_visible))
+#else
+#define __visible
+#endif
 
+#define CPP_ASMLINKAGE __visible
+
+#ifndef asmlinkage
+#define asmlinkage CPP_ASMLINKAGE
+#endif
+
+#endif
#4 lore raw

Patch is wrong.

Quoted 34 lines · Robin Hack

From: Robin Hack <[email protected]>
Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h.

tools/lib/lockdep/uinclude/linux/linkage.h +17 -2
index fab00ff..6799a5b 100644
@@ -1,3 +1,19 @@
+#ifndef _LOCKDEP_ULINKAGE_H
+#define _LOCKDEP_ULINKAGE_H
 
-/* empty file */
+#if GCC_VERSION >= 40600
+/*
+ * Tell the optimizer that something else uses this function or variable.
+ */
+#define __visible __attribute__((externally_visible))
+#else
+#define __visible
+#endif
 
+#define CPP_ASMLINKAGE __visible
+
+#ifndef asmlinkage
+#define asmlinkage CPP_ASMLINKAGE
+#endif
+
+#endif
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#5 lore raw
In reply to Robin Hack
Quoted 2 lines · Robin Hack

From: Robin Hack <[email protected]>
Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h.

You can just do

#define asmlinkage
#define __visible

for this case. don't need all the ifdefs or the attribute in the userspace build.

-Andi

#6 lore raw
Quoted 8 lines · Andi Kleen
Quoted 2 lines · Robin Hack

From: Robin Hack <[email protected]>
Copy asmlinkage macro to lockdep/uinclude/linux/linkage.h.

You can just do

#define asmlinkage
#define __visible

Thanks Andi,

I've queued it up along with another fix for Ingo.

Thanks,
Sasha