Skip to contentSkip to conversation

[PATCH usb: phy: add run-time dependencies to R-Car driver

DISCUSSION Laurent Pinchart 2 participants 3 messages May 26, 2014 SuperH

lore
Share & tools
lore
#0 lore raw

Hi Jean,

Thank you for the patch.

Quoted 7 lines · On Friday 23 May 2014 10:36:22 Jean Delvare wrote:

The Renesas R-Car USB PHY driver only supports the R8A7778 and R8A7779, it isn't useful on other systems unless build testing.

Cc Felipe Balbi <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Laurent Pinchart <[email protected]>

Could you please CC the linux-sh mailing list for similar patches in the future ?

Sergei, any opinion on this ?

Quoted 15 lines
---
 drivers/usb/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-3.15-rc6.orig/drivers/usb/phy/Kconfig 2014-04-14
09:42:31.481112766 +0200 +++
linux-3.15-rc6/drivers/usb/phy/Kconfig 2014-05-23 10:11:59.979813625 +0200

(quoted diff) +1 -0
@@ -208,6 +208,7 @@ config USB_MXS_PHY
 config USB_RCAR_PHY
 	tristate "Renesas R-Car USB PHY support"
 	depends on USB || USB_GADGET
+	depends on ARCH_R8A7778 || ARCH_R8A7779 || COMPILE_TEST
 	select USB_PHY
 	help
 	  Say Y here to add support for the Renesas R-Car USB common PHY driver.
Signature · 3 lines
Regards,

Laurent Pinchart
#1 lore raw

Hello.

Quoted 8 lines · Laurent Pinchart
Quoted 7 lines

The Renesas R-Car USB PHY driver only supports the R8A7778 and R8A7779, it isn't useful on other systems unless build testing.

Cc Felipe Balbi <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Laurent Pinchart <[email protected]>
Quoted 4 lines

Could you please CC the linux-sh mailing list for similar patches in the future ?

Sergei, any opinion on this ?

I wouldn't object.

Quoted 4 lines
Quoted 3 lines
---
  drivers/usb/phy/Kconfig |    1 +
  1 file changed, 1 insertion(+)
Quoted 11 lines

Review config USB_MXS_PHY · line 214

Quoted 11 lines

--- linux-3.15-rc6.orig/drivers/usb/phy/Kconfig 2014-04-14
09:42:31.481112766 +0200 +++
linux-3.15-rc6/drivers/usb/phy/Kconfig 2014-05-23 10:11:59.979813625 +0200

(quoted diff) +1 -0
@@ -208,6 +208,7 @@ config USB_MXS_PHY
  config USB_RCAR_PHY
  	tristate "Renesas R-Car USB PHY support"
  	depends on USB || USB_GADGET
+	depends on ARCH_R8A7778 || ARCH_R8A7779 || COMPILE_TEST
  	select USB_PHY
  	help
  	  Say Y here to add support for the Renesas R-Car USB common PHY driver.

WBR, Sergei

author Acked-by
#2 lore raw
In reply to Laurent Pinchart

Hi Sergei,

Quoted 9 lines · On Monday 26 May 2014 17:55:49 Sergei Shtylyov wrote:
Quoted 8 lines · Laurent Pinchart
Quoted 7 lines

The Renesas R-Car USB PHY driver only supports the R8A7778 and R8A7779, it isn't useful on other systems unless build testing.

Cc Felipe Balbi <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Laurent Pinchart <[email protected]>
Quoted 6 lines
Quoted 4 lines

Could you please CC the linux-sh mailing list for similar patches in the future ?

Sergei, any opinion on this ?

I wouldn't object.

Thank you. I won't object either then.

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines

---

  drivers/usb/phy/Kconfig |    1 +
  1 file changed, 1 insertion(+)

--- linux-3.15-rc6.orig/drivers/usb/phy/Kconfig 2014-04-14
09:42:31.481112766 +0200 +++
linux-3.15-rc6/drivers/usb/phy/Kconfig 2014-05-23 10:11:59.979813625
+0200

(quoted diff) +1 -0
@@ -208,6 +208,7 @@ config USB_MXS_PHY
  config USB_RCAR_PHY
  	tristate "Renesas R-Car USB PHY support"
  	depends on USB || USB_GADGET
+	depends on ARCH_R8A7778 || ARCH_R8A7779 || COMPILE_TEST
  	select USB_PHY
  	help
  	  Say Y here to add support for the Renesas R-Car USB common PHY

driver.

Signature · 3 lines
Regards,

Laurent Pinchart