spi: lantiq-ssc: Use devm_platform_ioremap_resource() in lantiq_ssc_probe()
Subsystems (2)
PATCH 1/1 spi: lantiq-ssc: Use devm_platform_ioremap_resource() in lantiq_ssc_probe()
From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 14:16:49 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
--- drivers/spi/spi-lantiq-ssc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/spi/spi-lantiq-ssc.c +1 -9
@@ -797,7 +797,6 @@ static int lantiq_ssc_probe(struct platform_device *pdev) {struct device *dev = &pdev->dev;struct spi_master *master; -struct resource *res;struct lantiq_ssc_spi *spi;const struct lantiq_ssc_hwcfg *hwcfg;const struct of_device_id *match;
@@ -812,12 +811,6 @@ static int lantiq_ssc_probe(struct platform_device *pdev) } hwcfg = match->data; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -if (!res) { -dev_err (dev,"failed to get resources\n" ); -return -ENXIO ; - } - rx_irq =platform_get_irq_byname (pdev,LTQ_SPI_RX_IRQ_NAME );if (rx_irq <0 )return -ENXIO ;
@@ -839,8 +832,7 @@ static int lantiq_ssc_probe(struct platform_device *pdev) spi->dev = dev; spi->hwcfg = hwcfg;platform_set_drvdata (pdev, spi); - - spi->regbase =devm_ioremap_resource (dev, res); + spi->regbase =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (spi->regbase)) { err =PTR_ERR (spi->regbase); goto err_master_put;
--
2.23.0
Mark Brown
maintainerApplied "spi: lantiq-ssc: Use devm_platform_ioremap_resource() in lantiq_ssc_probe()" to the spi tree
The patch
spi: lantiq-ssc: Use devm_platform_ioremap_resource() in lantiq_ssc_probe()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
From 22262695f46b68659ba98a12e275df388c74968c Mon Sep 17 00:00:00 2001
From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 14:16:49 +0200
Subject: [PATCH] spi: lantiq-ssc: Use devm_platform_ioremap_resource() in
lantiq_ssc_probe()
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
--- drivers/spi/spi-lantiq-ssc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/spi/spi-lantiq-ssc.c +1 -9
@@ -797,7 +797,6 @@ static int lantiq_ssc_probe(struct platform_device *pdev) {struct device *dev = &pdev->dev;struct spi_master *master; -struct resource *res;struct lantiq_ssc_spi *spi;const struct lantiq_ssc_hwcfg *hwcfg;const struct of_device_id *match;
@@ -812,12 +811,6 @@ static int lantiq_ssc_probe(struct platform_device *pdev) } hwcfg = match->data; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -if (!res) { -dev_err (dev,"failed to get resources\n" ); -return -ENXIO ; - } - rx_irq =platform_get_irq_byname (pdev,LTQ_SPI_RX_IRQ_NAME );if (rx_irq <0 )return -ENXIO ;
@@ -839,8 +832,7 @@ static int lantiq_ssc_probe(struct platform_device *pdev) spi->dev = dev; spi->hwcfg = hwcfg;platform_set_drvdata (pdev, spi); - - spi->regbase =devm_ioremap_resource (dev, res); + spi->regbase =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (spi->regbase)) { err =PTR_ERR (spi->regbase); goto err_master_put;
Signature · 1 line
2.20.1