Skip to contentSkip to conversation

CONFIG_ACPI totally broken (2.6.9-rc1-mm2)

DISCUSSION Martin J. Bligh 3 participants 5 messages Aug 31, 2004 – Sep 1, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

OK, not only does it not compile in -mm2, you also can't disable it.

Moreover, if you try you get this:

scripts/kconfig/mconf arch/i386/Kconfig
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830

larry:~/linux/2.6.9-rc1-mm2# egrep '(HT|MMCONFIG|HPET)' .config
# CONFIG_HPET_TIMER is not set
# CONFIG_X86_HT is not set
# CONFIG_PCI_GOMMCONFIG is not set
# CONFIG_HPET is not set
larry:~/linux/2.6.9-rc1-mm2# grep ACPI .config
# Power management options (ACPI, APM)
# ACPI (Advanced Configuration and Power Interface) Support
CONFIG_ACPI=y
# CONFIG_ACPI_AC is not set
# CONFIG_ACPI_BATTERY is not set
# CONFIG_ACPI_BUTTON is not set
# CONFIG_ACPI_FAN is not set
# CONFIG_ACPI_PROCESSOR is not set
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_TOSHIBA is not set
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_PCI=y

How the hell do you turn this stuff off?

M.

#1 lore raw
Quoted 1 line

OK, not only does it not compile in -mm2, you also can't disable it.

The exact same config file works fine in -mm1 ... it's just the -mm2 one that's broken.

Quoted 34 lines

Moreover, if you try you get this:

scripts/kconfig/mconf arch/i386/Kconfig
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830

larry:~/linux/2.6.9-rc1-mm2# egrep '(HT|MMCONFIG|HPET)' .config
# CONFIG_HPET_TIMER is not set
# CONFIG_X86_HT is not set
# CONFIG_PCI_GOMMCONFIG is not set
# CONFIG_HPET is not set
larry:~/linux/2.6.9-rc1-mm2# grep ACPI .config
# Power management options (ACPI, APM)
# ACPI (Advanced Configuration and Power Interface) Support
CONFIG_ACPI=y
# CONFIG_ACPI_AC is not set
# CONFIG_ACPI_BATTERY is not set
# CONFIG_ACPI_BUTTON is not set
# CONFIG_ACPI_FAN is not set
# CONFIG_ACPI_PROCESSOR is not set
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_TOSHIBA is not set
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_PCI=y

How the hell do you turn this stuff off?

M.

#2 lore raw
Quoted 15 lines · Martin J. Bligh
Quoted 2 lines

OK, not only does it not compile in -mm2, you also can't disable it.

The exact same config file works fine in -mm1 ... it's just the -mm2 one that's broken.

Quoted 9 lines

Moreover, if you try you get this:

scripts/kconfig/mconf arch/i386/Kconfig
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830

Yeah, that one. I bugged Len the other day, but perhaps he's out of town or something.

Quoted 24 lines
Quoted 24 lines
larry:~/linux/2.6.9-rc1-mm2# egrep '(HT|MMCONFIG|HPET)' .config
# CONFIG_HPET_TIMER is not set
# CONFIG_X86_HT is not set
# CONFIG_PCI_GOMMCONFIG is not set
# CONFIG_HPET is not set
larry:~/linux/2.6.9-rc1-mm2# grep ACPI .config
# Power management options (ACPI, APM)
# ACPI (Advanced Configuration and Power Interface) Support
CONFIG_ACPI=y
# CONFIG_ACPI_AC is not set
# CONFIG_ACPI_BATTERY is not set
# CONFIG_ACPI_BUTTON is not set
# CONFIG_ACPI_FAN is not set
# CONFIG_ACPI_PROCESSOR is not set
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_TOSHIBA is not set
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_PCI=y

How the hell do you turn this stuff off?

M.

#3 lore raw
Quoted 4 lines
Quoted 4 lines
Quoted 1 line

OK, not only does it not compile in -mm2, you also can't disable it.

The exact same config file works fine in -mm1 ... it's just the -mm2 one that's broken.

OK, removing all the "select ACPI" statements from arch/i386/Kconfig fixes it ... but all of the things that those were under were already disabled. So I think it might be a Kconfig bug.

ftp://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/config.numaq

should demonstrate it well.

Quoted 10 lines
Quoted 9 lines
Quoted 9 lines

Moreover, if you try you get this:

scripts/kconfig/mconf arch/i386/Kconfig
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830

Quoted 2 lines

Yeah, that one. I bugged Len the other day, but perhaps he's out of town or something.

Nah, he's talking to me on IRC, so he can't escape ;-)

#4 lore raw
In reply to Martin J. Bligh

Hi,

Quoted 7 lines · Martin J. Bligh

scripts/kconfig/mconf arch/i386/Kconfig
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_AC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K7_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_POWERNOW_K8_ACPI Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_EC
Warning! Found recursive dependency: ACPI PCI_MMCONFIG ACPI ACPI_PROCESSOR X86_SPEEDSTEP_CENTRINO_ACPI Warning! Found recursive dependency: DRM_I830 DRM_I915 DRM_I830

The patch below fixes these warnings. This usage of select is really bad, as it made it impossible to just enable PCI_BIOS and PCI_DIRECT without turning on ACPI.
I seriously consider to add a timeout after such warnings or even turn them into errors, currently they are too easily ignored. :(

bye, Roman

arch/i386/Kconfig +5 -10
diff -ur linux-2.6.org/arch/i386/Kconfig linux-2.6/arch/i386/Kconfig
@@ -1120,6 +1120,7 @@
 
 config PCI_GOMMCONFIG
 	bool "MMConfig"
+	depends on ACPI
 
 config PCI_GODIRECT
 	bool "Direct"
@@ -1130,20 +1131,14 @@
 endchoice
 
 config PCI_BIOS
-	bool
-	depends on !X86_VISWS && PCI && (PCI_GOBIOS || PCI_GOANY)
-	default y
+	def_bool PCI_GOBIOS || PCI_GOANY
 
 config PCI_DIRECT
-	bool
- 	depends on PCI && ((PCI_GODIRECT || PCI_GOANY) || X86_VISWS)
-	default y
+	def_bool PCI_GODIRECT || PCI_GOANY || X86_VISWS
 
 config PCI_MMCONFIG
-	bool
-	depends on PCI && (PCI_GOMMCONFIG || (PCI_GOANY && ACPI))
-	select ACPI
-	default y
+	def_bool PCI_GOMMCONFIG || PCI_GOANY
+	depends on ACPI
 
 source "drivers/pci/Kconfig"
 
drivers/char/drm/Kconfig +9 -5
diff -ur linux-2.6.org/drivers/char/drm/Kconfig linux-2.6/drivers/char/drm/Kconfig
@@ -55,9 +55,13 @@
 	  selected, the module will be called i810.  AGP support is required
 	  for this driver to work.
 
+choice
+	prompt "Intel 830M, 845G, 852GM, 855GM, 865G (915G)"
+	depends on DRM && AGP && AGP_INTEL
+	optional
+
 config DRM_I830
-	tristate "Intel 830M, 845G, 852GM, 855GM, 865G"
-	depends on DRM && AGP && AGP_INTEL && !(DRM_I915=y)
+	tristate "Old driver"
 	help
 	  Choose this option if you have a system that has Intel 830M, 845G,
 	  852GM, 855GM or 865G integrated graphics.  If M is selected, the
@@ -67,15 +71,15 @@
 	  or previous releases.
 
 config DRM_I915
-	tristate "Intel 830M, 845G, 852GM, 855GM, 865G, 915G"
-	depends on DRM && AGP && AGP_INTEL && !(DRM_I830=y)
+	tristate "New driver"
 	help
 	  Choose this option if you have a system that has Intel 830M, 845G,
 	  852GM, 855GM 865G or 915G integrated graphics.  If M is selected, the
 	  module will be called i915.  AGP support is required for this driver
 	  to work. This driver should be used for systems running Xorg 6.8 and
 	  XFree86 releases after (but not including 4.4).
-	
+
+endchoice
 
 config DRM_MGA
 	tristate "Matrox g200/g400"