Skip to contentSkip to conversation

io_uring: fix a memory leak of buffer group list on exit

PATCH New Jens Axboe 1 participant 1 message May 26, 2022

Subsystems (2)
lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: fix a memory leak of buffer group list on exit

If we use a buffer group ID that is large enough to require io_uring to allocate it, then we don't correctly free it if the cleanup is deferred to the ring exit. The explicit removal paths are fine.

Fixes 9cfc7e94e42b ("io_uring: get rid of hashed provided buffer groups")

---

fs/io_uring.c +1 -0
index f7e1fc85d266..ccb47d87a65a 100644
@@ -11065,6 +11065,7 @@ static void io_destroy_buffers(struct io_ring_ctx *ctx)
 	xa_for_each(&ctx->io_bl_xa, index, bl) {
 		xa_erase(&ctx->io_bl_xa, bl->bgid);
 		__io_remove_buffers(ctx, bl, -1U);
+		kfree(bl);
 	}
 
 	while (!list_empty(&ctx->io_buffers_pages)) {
Signature · 1 line
Jens Axboe