Skip to contentSkip to conversation

dmaengine: rcar-dmac: convert to SPDX identifiers

DISCUSSION Laurent Pinchart 1 participant 1 message Jul 3, 2018 dmaengine

lore
Share & tools
lore
#0 lore raw

Hi Vinod,

Quoted 53 lines · On Tuesday, 3 July 2018 09:20:08 EEST Vinod wrote:
Quoted 45 lines · Laurent Pinchart

Hi Morimoto-san,

Thank you for the patch.

Quoted 1 line · On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote:

From: Kuninori Morimoto <[email protected]>

A commit message would be nice :-)

Quoted 19 lines

---

 drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/dma/sh/rcar-dmac.c +0 -8
index 79d14af..322e57b 100644
@@ -1,14 +1,10 @@
-/*
- * Renesas R-Car Gen2 DMA Controller Driver
- *
- * Copyright (C) 2014 Renesas Electronics Inc.
- *
- * Author: Laurent Pinchart <[email protected]>
- *
- * This is free software; you can redistribute it and/or modify

drivers/dma/sh/rcar-dmac.c line 7

Quoted 10 lines
drivers/dma/sh/rcar-dmac.c +7 -3
- * it under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- */
+// SPDX-License-Identifier: GPL-2.0
+//
+// Renesas R-Car Gen2 DMA Controller Driver
+//
+// Copyright (C) 2014 Renesas Electronics Inc.
+//
+// Author: Laurent Pinchart <[email protected]>

I think the preferred comment style, accordingly to what other drivers do, is

// SPDX-License-Identifier: GPL-2.0
/*

Quoted 6 lines

* Renesas R-Car Gen2 DMA Controller Driver
*
* Copyright (C) 2014 Renesas Electronics Inc.
*
* Author: Laurent Pinchart <[email protected]> */

Quoted 5 lines

And Linus said this https://lkml.org/lkml/2017/11/25/133

So lets keep C99 style as Morimoto-San proposed.

And high time, this should be documented :)

As mentioned before, while I certainly prefer the traditional C-style comments, I ultimately let driver authors decide. What matters most in my opinion is consistency, mixing styles in the same driver just makes the code harder to read.

What matters in the end is how easy reading the code will be, and until the majority of kernel developers get used to the C++ comment style, no matter what Linus' personal preference is, // will be an annoyance.

Signature · 3 lines
Regards,

Laurent Pinchart