binfmt_elf: fix documented return value for load_elf_phdrs()
Subsystems (3)
PATCH 1/1 binfmt_elf: fix documented return value for load_elf_phdrs()
This function has never returned anything but a plain NULL.
Fixes 6a8d38945cf4 ("binfmt_elf: Hoist ELF program header loading to a function")
Signed-off-by Rolf Eike Beer <[email protected]>
--- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/binfmt_elf.c +1 -1
@@ -456,7 +456,7 @@ static unsigned long maximum_alignment(struct elf_phdr *cmds, int nr)* * Loads ELF program headers from the binary file elf_file, which has the ELF * header pointed to by elf_ex, into a newly allocated array. The caller is -* responsible for freeing the allocated data. Returns an ERR_PTR upon failure. +* responsible for freeing the allocated data. Returns NULL upon failure. */ static struct elf_phdr *load_elf_phdrs (const struct elfhdr *elf_ex,struct file *elf_file)
Signature · 10 lines
2.37.3 -- Rolf Eike Beer, emlix GmbH, https://www.emlix.com Fon +49 551 30664-0, Fax +49 551 30664-11 Gothaer Platz 3, 37083 Göttingen, Germany Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 emlix - smart embedded open source
Kees Cook
AppliedQuoted 1 line · Rolf Eike Beer
This function has never returned anything but a plain NULL.
Applied to for-next/execve, thanks!
[1/1] binfmt_elf: fix documented return value for load_elf_phdrs()
https://git.kernel.org/kees/c/cfc46ca4fdca
Signature · 1 line
Kees Cook