Skip to contentSkip to conversation

ACPI: PAD: xen: Stop setting acpi_device_name/class()

PATCH In review Rafael J. Wysocki 3 participants 3 messages Jul 6 – Jul 8

Subsystems (2)
lore
Share & tools
lore

Rafael J. Wysocki

author maintainer
#0 lore raw

PATCH 1/1 ACPI: PAD: xen: Stop setting acpi_device_name/class()

From: "Rafael J. Wysocki" <[email protected]>

The driver sets acpi_device_name() and acpi_device_class() which are never read afterward, so make it stop doing that and drop the symbols defined specifically for this purpose.

No intentional functional impact.

This will facilitate the removal of device_name and device_class from struct acpi_device_pnp in the future.

---
 drivers/xen/xen-acpi-pad.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/xen/xen-acpi-pad.c +0 -5
index 5b98e0e93807..2fa9c7d3581f 100644
@@ -17,8 +17,6 @@
 #include <xen/xen-ops.h>
 #include <asm/xen/hypercall.h>
 
-#define ACPI_PROCESSOR_AGGREGATOR_CLASS	"acpi_pad"
-#define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
 #define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80
 static DEFINE_MUTEX(xen_cpu_lock);
 
@@ -117,9 +115,6 @@ static int acpi_pad_probe(struct platform_device *pdev)
 	if (!device)
 		return -ENODEV;
 
-	strcpy(acpi_device_name(device), ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME);
-	strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS);
-
 	status = acpi_install_notify_handler(device->handle,
 		ACPI_DEVICE_NOTIFY, acpi_pad_notify, device);
 	if (ACPI_FAILURE(status))
Signature · 1 line
2.51.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Rafael J. Wysocki

From: "Rafael J. Wysocki" <[email protected]>

The driver sets acpi_device_name() and acpi_device_class() which are never read afterward, so make it stop doing that and drop the symbols defined specifically for this purpose.

Quoted 6 lines

No intentional functional impact.

This will facilitate the removal of device_name and device_class from struct acpi_device_pnp in the future.

Juergen

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rafael J. Wysocki
Quoted 8 lines · Rafael J. Wysocki

The driver sets acpi_device_name() and acpi_device_class() which are never read afterward, so make it stop doing that and drop the symbols defined specifically for this purpose.

No intentional functional impact.

This will facilitate the removal of device_name and device_class from struct acpi_device_pnp in the future.

Signature · 2 lines
With Best Regards,
Andy Shevchenko