fs: New zonefs file system
…
Quoted 1 line
+++
b/fs/zonefs/super.c
…
Review
Quoted 4 lines
(quoted diff) +4
-0+out: + kunmap(page); +out_free: + __free_page(page);
Would you like to reconsider your name selection for such labels?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460
Change possibility:
+unmap:
+ kunmap(page);
+free_page:
+ __free_page(page);
Regards,
Markus
Quoted 14 lines · Markus Elfring
…
Quoted 1 line
+++
b/fs/zonefs/super.c…
Review
Quoted 4 lines
(quoted diff) +4
-0+out: + kunmap(page); +out_free: + __free_page(page);Would you like to reconsider your name selection for such labels?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=b0be0eff1a5ab77d588b76bd8b1c92d5d17b3f73#n460Change possibility:
Review
Quoted 4 lines
(quoted diff) +4
-0+unmap: + kunmap(page); +free_page: + __free_page(page);
Fixed. Thanks !
Quoted 3 lines
Regards,
Markus
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 1 line
Quoted 1 line
Would you like to reconsider your name selection for such labels?
…
Quoted 1 line
Fixed. Thanks !
Will a different identifier be occasionally more helpful than the label “out” also at other source code places?
Regards,
Markus
Quoted 6 lines · Markus Elfring
Quoted 1 line
Quoted 1 line
Would you like to reconsider your name selection for such labels?
…
Quoted 1 line
Fixed. Thanks !
Will a different identifier be occasionally more helpful than the label “out” also at other source code places?
I am addressing all comments I got for v10 right now and reviewing all the goto labels too. Thanks.
Quoted 4 lines
Regards,
Markus
Signature · 2 lines
Damien Le Moal Western Digital Research