drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config
Quoted 1 line
in
amdgpu_display_crtc_set_config, …
* Can the term “reference count” become relevant also for this commit message besides other possible adjustments?
* Can it be nicer to combine proposed updates for this software module as a patch series (with a cover letter)?
* Would you like to add the tag “Fixes”?
…
Quoted 1 line
+++
b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
…
Review int amdgpu_display_crtc_set_config(struct drm_mode_set *set, · line 312
Quoted 8 lines
(quoted diff) +1
-0@@ -306,6 +306,7 @@ int amdgpu_display_crtc_set_config(struct drm_mode_set *set, adev->have_disp_power_ref = false; } +out: /* drop the power reference we got coming in here */ pm_runtime_put_autosuspend(dev->dev); return ret;
Perhaps use the label “put_runtime” instead?
Regards,
Markus