i2c: i2c-core-smbus: fixed a whitespace style issue
Subsystems (2)
PATCH 1/1 i2c: i2c-core-smbus: fixed a whitespace style issue
From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
From: Liam Zuiderhoek <[email protected]>
Date: Tue, 22 Oct 2024 20:46:59 +0200
Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
Fixing a coding style issue.
--- drivers/i2c/i2c-core-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/i2c-core-smbus.c +1 -1
@@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);s32 i2c_smbus_write_byte (const struct i2c_client *client,u8 value) {return i2c_smbus_xfer (client->adapter, client->addr, client->flags, -I2C_SMBUS_WRITE , value,I2C_SMBUS_BYTE ,NULL ); +I2C_SMBUS_WRITE , value,I2C_SMBUS_BYTE ,NULL ); }EXPORT_SYMBOL (i2c_smbus_write_byte);
Signature · 1 line
2.43.0
Andi Shyti
maintainerHi Liam,
your patch is almost correct, just a few things need to be fixed.
Quoted 4 lines · Liam Zuiderhoek
From
214adebf7cf37be941f208124fac9ea6bec0f1d2Mon Sep 17 00:00:00 2001
From: Liam Zuiderhoek <[email protected]>
Date: Tue, 22 Oct 2024 20:46:59 +0200
Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
Why the header file is in the commit log?
The title needs to be written in imperative form:
"Fix whitespace style issue"
instead of
"fixed a whitespace..."
Quoted 1 line
Fixing a coding style issue.
We have plenty of space in the commit log and you can be more specific on the coding style you are fixing; e.g. "use tabs instead of white spaces for alignment".
Please read Documentation/process/submitting-patches.rst.
Quoted 10 lines
Signed-off-by Liam Zuiderhoek <[email protected]>--- drivers/i2c/i2c-core-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i2c/i2c-core-smbus.c +0
-0
drivers/i2c/i2c-core-smbus.c EXPORT_SYMBOL(i2c_smbus_read_byte); · line 125
Quoted 5 lines
drivers/i2c/i2c-core-smbus.c +1
-1@@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);s32 i2c_smbus_write_byte (const struct i2c_client *client,u8 value) {return i2c_smbus_xfer (client->adapter, client->addr, client->flags, -I2C_SMBUS_WRITE , value,I2C_SMBUS_BYTE ,NULL ); +I2C_SMBUS_WRITE , value,I2C_SMBUS_BYTE ,NULL );
Please align everything under the "(":
return i2c_smbus_xfer(client->adapter, client->addr, client->flags, I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
That means, use as many tabs as you can, until you need to use spaces to align under the "(".
Thanks,
Andi