OMAP4 ISS driver

Hello,

Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera interface).

The driver has been posted for review on the [email protected] and [email protected] mailing lists. A couple of review comments were received (thanks to the reviewers). I've decided to address them as follow-up patches in order to keep the original code, well, original and credit Sergio Aguirre for his great work.

I'll work on addressing the comments, cleaning up the code and getting the driver out of staging in the next couple of kernel versions.

The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2:

Linux 3.12-rc5 (2013-10-13 15:41:28 -0700)

are available in the git repository at:

git://linuxtv.org/pinchartl/media.git omap4iss/next

for you to fetch changes up to 8255f7e6fc15f238c40d1244863433bea0436956:

v4l: omap4iss: Add support for OMAP4 camera interface - Build system
(2013-10-15 17:56:15 +0200)

----------------------------------------------------------------
Laurent Pinchart (1):
v4l: omap4iss: Add support for OMAP4 camera interface - Build system

Sergio Aguirre (5):
v4l: omap4iss: Add support for OMAP4 camera interface - Core
v4l: omap4iss: Add support for OMAP4 camera interface - Video devices
v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers
v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF)
v4l: omap4iss: Add support for OMAP4 camera interface - Resizer

 Documentation/video4linux/omap4_camera.txt   |   63 ++
 drivers/staging/media/Kconfig                |    2 +
 drivers/staging/media/Makefile               |    1 +
 drivers/staging/media/omap4iss/Kconfig       |   12 +
 drivers/staging/media/omap4iss/Makefile      |    6 +
 drivers/staging/media/omap4iss/TODO          |    4 +
 drivers/staging/media/omap4iss/iss.c         | 1477 +++++++++++++++++++++++++
 drivers/staging/media/omap4iss/iss.h         |  153 ++++
 drivers/staging/media/omap4iss/iss_csi2.c    | 1368 +++++++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_csi2.h    |  156 ++++
 drivers/staging/media/omap4iss/iss_csiphy.c  |  278 +++++++
 drivers/staging/media/omap4iss/iss_csiphy.h  |   51 ++
 drivers/staging/media/omap4iss/iss_ipipe.c   |  581 +++++++++++++
 drivers/staging/media/omap4iss/iss_ipipe.h   |   67 ++
 drivers/staging/media/omap4iss/iss_ipipeif.c |  847 +++++++++++++++++++
 drivers/staging/media/omap4iss/iss_ipipeif.h |   92 +++
 drivers/staging/media/omap4iss/iss_regs.h    |  883 ++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_resizer.c |  905 +++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_resizer.h |   75 ++
 drivers/staging/media/omap4iss/iss_video.c   | 1129 +++++++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_video.h   |  201 +++++
 include/media/omap4iss.h                     |   65 ++
 22 files changed, 8416 insertions(+)
 create mode 100644 Documentation/video4linux/omap4_camera.txt
 create mode 100644 drivers/staging/media/omap4iss/Kconfig
 create mode 100644 drivers/staging/media/omap4iss/Makefile
 create mode 100644 drivers/staging/media/omap4iss/TODO
 create mode 100644 drivers/staging/media/omap4iss/iss.c
 create mode 100644 drivers/staging/media/omap4iss/iss.h
 create mode 100644 drivers/staging/media/omap4iss/iss_csi2.c
 create mode 100644 drivers/staging/media/omap4iss/iss_csi2.h
 create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.c
 create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.h
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.c
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.h
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.c
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.h
 create mode 100644 drivers/staging/media/omap4iss/iss_regs.h
 create mode 100644 drivers/staging/media/omap4iss/iss_resizer.c
 create mode 100644 drivers/staging/media/omap4iss/iss_resizer.h
 create mode 100644 drivers/staging/media/omap4iss/iss_video.c
 create mode 100644 drivers/staging/media/omap4iss/iss_video.h
 create mode 100644 include/media/omap4iss.h

Regards,

Laurent Pinchart

I don't take pull requests for staging drivers.

But even if I did, Mauro takes drivers/staging/media/ code, so it's up to him to take this, not me.

thanks,

greg k-h

Hi Greg,

My bad, I shouldn't have CC'ed you, sorry about the noise. I believe Mauro will handle this, as the linuxtv patchwork has picked the pull request up.

Regards,

Laurent Pinchart

Em Tue, 15 Oct 2013 18:38:40 +0200
Laurent Pinchart <[email protected]> escreveu:

Yeah, I'll handle this.

Cheers,
Mauro

Yeah... Pull request get far less review. I never bother reviewing them, honestly. I feel bad for that.

regards,
dan carpenter

Hi Dan,

That's why I've posted the patches for review two weeks ago. As noted in the pull request, I will address all comments received (there was quite a lot of small interesting comments but no show-stopper) as part of the driver cleanup work to move it out of staging.

Regards,

Laurent Pinchart