Skip to contentSkip to conversation

USB SERIAL: option.c: add 2020:4000 IDs

PATCH In review Claudio Cappelli 3 participants 4 messages Jun 10, 2015 – Jun 17, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 USB SERIAL: option.c: add 2020:4000 IDs

From: Claudio Cappelli <[email protected]>

Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.

---

drivers/usb/serial/option.c | 1 +

 1 file changed, 1 insertion(+)
drivers/usb/serial/option.c renamed from drivers/usb/serial/option.c.orig +1 -0
@@ -1765,6 +1765,7 @@ static const struct usb_device_id option
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
+	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) },                /* OLICARD300 - MT6225 */
 	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
 	{ USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
 	{ } /* Terminating entry */
#1 lore raw
Quoted 18 lines · On Wednesday 10 June 2015 20:38:30 Claudio Cappelli wrote:

From: Claudio Cappelli <[email protected]>

Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.

---

drivers/usb/serial/option.c | 1 +

 1 file changed, 1 insertion(+)

drivers/usb/serial/option.c static const struct usb_device_id option · line 1771

Quoted 7 lines
drivers/usb/serial/option.c renamed from drivers/usb/serial/option.c.orig +1 -0
@@ -1765,6 +1765,7 @@ static const struct usb_device_id option
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
+	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) },                /* OLICARD300 - MT6225 */
 	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
 	{ USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
 	{ } /* Terminating entry */

Was this second version in the right format?
Since it was my first patch submit, I'd be
grateful if you could confirm.

Thanks!
See you

#2 lore raw
Quoted 24 lines · Claudio Cappelli
Quoted 23 lines · On Wednesday 10 June 2015 20:38:30 Claudio Cappelli wrote:

From: Claudio Cappelli <[email protected]>

Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.

---

drivers/usb/serial/option.c | 1 +

 1 file changed, 1 insertion(+)
drivers/usb/serial/option.c renamed from drivers/usb/serial/option.c.orig +1 -0
@@ -1765,6 +1765,7 @@ static const struct usb_device_id option
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
+	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) },                /* OLICARD300 - MT6225 */
 	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
 	{ USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
Quoted 8 lines

drivers/usb/serial/option.c static const struct usb_device_id option · line 1771

Quoted 2 lines
drivers/usb/serial/option.c renamed from drivers/usb/serial/option.c.orig +0 -0
 	{ } /* Terminating entry */

Was this second version in the right format?
Since it was my first patch submit, I'd be
grateful if you could confirm.

Be patient, kernel maintainers are busy people...

maintainer
#3 lore raw
In reply to Claudio Cappelli
Quoted 15 lines · Claudio Cappelli
Quoted 14 lines · On Wednesday 10 June 2015 20:38:30 Claudio Cappelli wrote:

From: Claudio Cappelli <[email protected]>

Add device Olivetti Olicard 300 (Network Connect: MT6225) - IDs 2020:4000.

---

drivers/usb/serial/option.c | 1 +

 1 file changed, 1 insertion(+)
Quoted 15 lines

drivers/usb/serial/option.c static const struct usb_device_id option · line 1771

Quoted 11 lines
drivers/usb/serial/option.c renamed from drivers/usb/serial/option.c.orig +1 -0
@@ -1765,6 +1765,7 @@ static const struct usb_device_id option
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x7d03, 0xff, 0x00, 0x00) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */
+	{ USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) },                /* OLICARD300 - MT6225 */
 	{ USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
 	{ USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
 	{ } /* Terminating entry */

Was this second version in the right format?
Since it was my first patch submit, I'd be
grateful if you could confirm.

Looks good. I've added the usb-devices output from your earlier mail to the commit message and queued it up for 4.2-rc2.

Thanks,
Johan