gianfar: add missing include

PATCH In review Michael Neuling 2 participants 3 messages Apr 10, 2012

Subsystems (4)

Networking Network drivers Linux-next tree Freescale eTSEC Ethernet driver (gianfar)

lore

Share & tools

lore

Michael Neuling

author

2012-04-10 04:18 UTC #0 lore raw

PATCH 1/1 gianfar: add missing include

next-20120405 compiled with mpc85xx_defconfig gives the following:

CC drivers/net/ethernet/freescale/gianfar_ethtool.o
drivers/net/ethernet/freescale/gianfar_ethtool.c: In function 'gfar_get_ts_info':
drivers/net/ethernet/freescale/gianfar_ethtool.c:1751:4: error: 'SOF_TIMESTAMPING_RX_SOFTWARE' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1751:4: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/freescale/gianfar_ethtool.c:1752:4: error: 'SOF_TIMESTAMPING_SOFTWARE' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1757:3: error: 'SOF_TIMESTAMPING_TX_HARDWARE' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1758:3: error: 'SOF_TIMESTAMPING_RX_HARDWARE' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1759:3: error: 'SOF_TIMESTAMPING_RAW_HARDWARE' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1762:9: error: 'HWTSTAMP_TX_OFF' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1763:9: error: 'HWTSTAMP_TX_ON' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1765:9: error: 'HWTSTAMP_FILTER_NONE' undeclared (first use in this function) drivers/net/ethernet/freescale/gianfar_ethtool.c:1766:9: error: 'HWTSTAMP_FILTER_ALL' undeclared (first use in this function)

This is because of a missing include file from:
6663628 gianfar: Support the get_ts_info ethtool method.

Signed-off-by Michael Neuling <[email protected]>

CC Richard Cochran <[email protected]>

CC David S. Miller <[email protected]>

drivers/net/ethernet/freescale/gianfar_ethtool.c +1 -0

index 27f49c7..3c34b32b 100644
@@ -29,6 +29,7 @@
 #include <linux/skbuff.h>
 #include <linux/spinlock.h>
 #include <linux/mm.h>
+#include <linux/net_tstamp.h>
 
 #include <asm/io.h>
 #include <asm/irq.h>

Richard Cochran

Acked-by on v1 1/1

2012-04-10 06:36 UTC #1 lore raw

Quoted 4 lines · Michael Neuling

This is because of a missing include file from:
6663628 gianfar: Support the get_ts_info ethtool method.
Signed-off-by Michael Neuling <[email protected]>

I did a poor job testing the non-x86 stuff in this series. Thanks for the fix.

Acked-by Richard Cochran <[email protected]>

Michael Neuling

author

2012-04-10 06:41 UTC #2 lore raw

Quoted 10 lines · Richard Cochran

Quoted 4 lines · Michael Neuling
This is because of a missing include file from:
6663628 gianfar: Support the get_ts_info ethtool method.
Signed-off-by Michael Neuling <[email protected]>
I did a poor job testing the non-x86 stuff in this series. Thanks for the fix.
Acked-by Richard Cochran <[email protected]>

Looks like davem fixed it before my post anyway...

http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=commitdiff;h=65a85a8d4dcabe95587ab61bece38b8d58174043

This is in next-20120410.

Sorry for the noise.

Mikey