Skip to contentSkip to conversation

ANNOUNCE: mdadm 3.2.4 - A tool for managing Soft RAID under Linux

DISCUSSION Paweł Sikora 3 participants 6 messages May 12, 2012 – May 15, 2012 MD RAID

lore
Share & tools
lore
#1 lore raw
Quoted 4 lines · Paweł Sikora

fyi, this release contains a hidden strict-aliasing-violation bug [1]. please fix this correctly or build mdadm with -fno-strict-aliasing option.

[1] http://www.spinics.net/lists/raid/msg37298.html

If you provide a patch, you're more likely to get the issue fixed than by just telling other people to fix it for you.

Thanks,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 8 lines · On Monday 14 of May 2012 22:30:32 Jes Sorensen wrote:
Quoted 4 lines · Paweł Sikora

fyi, this release contains a hidden strict-aliasing-violation bug [1]. please fix this correctly or build mdadm with -fno-strict-aliasing option.

[1] http://www.spinics.net/lists/raid/msg37298.html

If you provide a patch, you're more likely to get the issue fixed than by just telling other people to fix it for you.

i have sent you a revert request with a proper fix 3 months ago and you have finally rejected it with "invalid commit message", so feel free to keep broken mdadm sources as long as you wish :>

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 5 lines · Paweł Sikora
Quoted 4 lines · On Monday 14 of May 2012 22:30:32 Jes Sorensen wrote:
Quoted 3 lines · Paweł Sikora

fyi, this release contains a hidden strict-aliasing-violation bug [1]. please fix this correctly or build mdadm with -fno-strict-aliasing option.

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

[1] http://www.spinics.net/lists/raid/msg37298.html

If you provide a patch, you're more likely to get the issue fixed than by just telling other people to fix it for you.

i have sent you a revert request with a proper fix 3 months ago and you have finally rejected it with "invalid commit message", so feel free to keep broken mdadm sources as long as you wish :>

If you post a patch without including a proper commit message and signed-off-by lines, which is standard practice, then that is equivalent to you not having posted a patch in the first place.

Don't blame others for not doing the basic work everybody else does when posting patches. It really isn't hard to comply with the standard patch posting rules!

Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 16 lines · On Mon, 14 May 2012 22:58:58 +0200 Jes Sorensen <[email protected]> wrote:
Quoted 5 lines · Paweł Sikora
Quoted 4 lines · On Monday 14 of May 2012 22:30:32 Jes Sorensen wrote:
Quoted 3 lines · Paweł Sikora

fyi, this release contains a hidden strict-aliasing-violation bug [1]. please fix this correctly or build mdadm with -fno-strict-aliasing option.

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

[1] http://www.spinics.net/lists/raid/msg37298.html

If you provide a patch, you're more likely to get the issue fixed than by just telling other people to fix it for you.

i have sent you a revert request with a proper fix 3 months ago and you have finally rejected it with "invalid commit message", so feel free to keep broken mdadm sources as long as you wish :>

Quoted 7 lines

If you post a patch without including a proper commit message and signed-off-by lines, which is standard practice, then that is equivalent to you not having posted a patch in the first place.

Don't blame others for not doing the basic work everybody else does when posting patches. It really isn't hard to comply with the standard patch posting rules!

I decided a better approach is just to refresh from upstream:

http://gcc.gnu.org/svn/gcc/branches/cilkplus/include/sha1.h
http://gcc.gnu.org/svn/gcc/branches/cilkplus/libiberty/sha1.c

have been copied into mdadm with just a tiny change to not include config.h

Seems to work, and probably has the *right* fix.

NeilBrown

#5 lore raw
Quoted 9 lines · NeilBrown

On Mon, 14 May 2012 22:58:58 +0200 Jes Sorensen <[email protected]>

Quoted 7 lines

If you post a patch without including a proper commit message and signed-off-by lines, which is standard practice, then that is equivalent to you not having posted a patch in the first place.

Don't blame others for not doing the basic work everybody else does when posting patches. It really isn't hard to comply with the standard patch posting rules!

Quoted 8 lines

I decided a better approach is just to refresh from upstream:

http://gcc.gnu.org/svn/gcc/branches/cilkplus/include/sha1.h
http://gcc.gnu.org/svn/gcc/branches/cilkplus/libiberty/sha1.c

have been copied into mdadm with just a tiny change to not include config.h

Seems to work, and probably has the *right* fix.

I would tend to agree with you, if not we can hollor at the gcc guys :)

Cheers,
Jes