Skip to contentSkip to conversation

24rc8: unregister_netdevice: waiting for ... to become free

DISCUSSION [email protected] 2 participants 2 messages May 4, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

[email protected]

author Acked-by
#0 lore raw
Quoted 1 line

Roland, does this fix your bug?

Yes!
With this patch i can unload the nic driver again. Thank you !

Quoted 47 lines

-----Ursprüngliche Nachricht-----
Von: "David Miller" <[email protected]>
Gesendet: 04.05.08 06:11:32
An: [email protected]
CC: [email protected], [email protected], [email protected], [email protected]
Betreff: Re: 24rc8: unregister_netdevice: waiting for ... to become free

From: David Miller <[email protected]>
Date: Fri, 02 May 2008 05:45:36 -0700 (PDT)

Quoted 15 lines

From: "Roland" <[email protected]>
Date: Fri, 2 May 2008 14:38:36 +0200

Quoted 11 lines

it seems it`s lapbether driver

reproduce:

on system with pcnet32 (vmware) do

modprobe pcnet32
modprobe lapbether
modprobe -r lapbether
modprobe -r pcnet32 -> hang -> unregister_netdevice: waiting for eth0 to become free

Quoted 5 lines

lapbeth_cleanup_driver() unregisters the netdevice, but does not release the reference to lapbeth->ethdev in those device instances.

Once this happens, and the lapbeth_dev_notifier is unregistered, these references will leak forever.

Roland, does this fix your bug?

lapbeth: Release ->ethdev when unregistering device.

Otherwise it leaks forever.

Based upon a report by Roland <[email protected]>

Signed-off-by David S. Miller <[email protected]>
drivers/net/wan/lapbether.c +0 -0
index b5860b9..24fd613 100644

drivers/net/wan/lapbether.c static void __exit lapbeth_cleanup_driver(void) · line 465

Quoted 7 lines
drivers/net/wan/lapbether.c +1 -0
@@ -459,6 +459,7 @@ static void __exit lapbeth_cleanup_driver(void)
 	list_for_each_safe(entry, tmp, &lapbeth_devices) {
 		lapbeth = list_entry(entry, struct lapbethdev, node);
 
+		dev_put(lapbeth->ethdev);
 		unregister_netdevice(lapbeth->axdev);
 	}
 	rtnl_unlock();
Acked-by Roland Kletzing <[email protected]>

_______________________________________________________________________
Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 30 Tage kostenlos testen. http://www.pc-sicherheit.web.de/startseite/?mc=022220

maintainer
#1 lore raw

From: [email protected]
Date: Sun, 04 May 2008 11:33:12 +0200

Quoted 4 lines
Quoted 1 line

Roland, does this fix your bug?

Yes!
With this patch i can unload the nic driver again.

Thanks for testing, I'll push this fix to Linus.