Skip to contentSkip to conversation

Possible bug in 8250.c

DISCUSSION Ivica Mikec 2 participants 2 messages Aug 19, 2011

lore
Share & tools
lore
#0 lore raw

Hi!

I noticed a problem in 8250.c.

My board has only one UART port, and is 16550 compatible, so in function serial8250_interrupt I see that serial_in function is called twice. Second time, code "else if (end == NULL)" is executed and function return IRQ_NONE. This causes an entry in /proc/irq/spurious:

count 239
unhandled 1
last_unhandled 4294700846 ms

But this is not a spurious interrupt.

Regards.

#1 lore raw
Quoted 6 lines · Ivica Mikec

Hi!

I noticed a problem in 8250.c.

Quoted 7 lines

My board has only one UART port, and is 16550 compatible, so in function serial8250_interrupt I see that serial_in function is called twice. Second time, code "else if (end == NULL)" is executed and function return IRQ_NONE. This causes an entry in /proc/irq/spurious:

count 239
unhandled 1
last_unhandled 4294700846 ms

But this is not a spurious interrupt.

How did you find out? Have you checked that the port signals that it raised an interrupt? I.e. does it go through the 'if (!(iir & UART_IIR_NO_INT))' branch?

What other devices are bound to the same interrupt? Attach /proc/interrupts.

regards,

Signature · 2 lines
js
suse labs