Skip to contentSkip to conversation

fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests

PATCH In review James (song wei) 2 participants 4 messages Dec 14, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix bug in c/s 20332 Add commands to hotplug usb devices to hvm guests

diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 +0800
@@ -234,7 +234,7 @@

def op_usb_del(self, op, req):
self.acceptCommand(req)
- return req.threadRequest(self.do_usb_add, op, req)
+ return req.threadRequest(self.do_usb_del, op, req)

def do_usb_del(self, _, req):
return self.xd.domain_usb_add(self.dom.getName(), req)

Signature · 2 lines
View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26772352.html
Sent from the Xen - Dev mailing list archive at Nabble.com.
#1 lore raw
Quoted 8 lines · James (song wei)

diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 +0800

Review line 240

Quoted 8 lines
(quoted diff) +1 -1
@@ -234,7 +234,7 @@
 
     def op_usb_del(self, op, req):
         self.acceptCommand(req)
-        return req.threadRequest(self.do_usb_add, op, req)
+        return req.threadRequest(self.do_usb_del, op, req)
 
     def do_usb_del(self, _, req):
         return self.xd.domain_usb_add(self.dom.getName(), req)
                                     ^^^

do_usb_del() is still using domain_usb_add() ..

-- Pasi

#2 lore raw

Sorry, thanks Pasi!
-James

diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 16:18:27 2009 +0800
@@ -234,10 +234,10 @@

def op_usb_del(self, op, req):
self.acceptCommand(req)
- return req.threadRequest(self.do_usb_add, op, req)
+ return req.threadRequest(self.do_usb_del, op, req)

     def do_usb_del(self, _, req):

- return self.xd.domain_usb_add(self.dom.getName(), req)
+ return self.xd.domain_usb_del(self.dom.getName(), req)

def render_POST(self, req):
return self.perform(req)

Quoted 31 lines · Pasi Kärkkäinen
Quoted 8 lines · James (song wei)

diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 +0800

Review line 240

Quoted 8 lines
(quoted diff) +1 -1
@@ -234,7 +234,7 @@
 
     def op_usb_del(self, op, req):
         self.acceptCommand(req)
-        return req.threadRequest(self.do_usb_add, op, req)
+        return req.threadRequest(self.do_usb_del, op, req)
 
     def do_usb_del(self, _, req):
         return self.xd.domain_usb_add(self.dom.getName(), req)
                                     ^^^

do_usb_del() is still using domain_usb_add() ..

-- Pasi

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Signature · 2 lines
View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26774299.html
Sent from the Xen - Dev mailing list archive at Nabble.com.
#3 lore raw
Quoted 4 lines · James (song wei)

Sorry, thanks Pasi!
-James

Keir: This patch needs to go to xen-3.4-testing.hg aswell.

-- Pasi

Quoted 63 lines

diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 16:18:27 2009 +0800

(quoted diff) +2 -2
@@ -234,10 +234,10 @@
 
     def op_usb_del(self, op, req):
         self.acceptCommand(req)
-        return req.threadRequest(self.do_usb_add, op, req)
+        return req.threadRequest(self.do_usb_del, op, req)
 
     def do_usb_del(self, _, req):
-        return self.xd.domain_usb_add(self.dom.getName(), req)
+        return self.xd.domain_usb_del(self.dom.getName(), req)
 
     def render_POST(self, req):
         return self.perform(req)
Quoted 31 lines · Pasi Kärkkäinen
Quoted 8 lines · James (song wei)

diff -r b928797213ac tools/python/xen/xend/server/SrvDomain.py --- a/tools/python/xen/xend/server/SrvDomain.py Fri Dec 11 09:17:09 2009 +0000
+++ b/tools/python/xen/xend/server/SrvDomain.py Mon Dec 14 10:41:48 2009 +0800

Review line 240

Quoted 8 lines
(quoted diff) +1 -1
@@ -234,7 +234,7 @@
 
     def op_usb_del(self, op, req):
         self.acceptCommand(req)
-        return req.threadRequest(self.do_usb_add, op, req)
+        return req.threadRequest(self.do_usb_del, op, req)
 
     def do_usb_del(self, _, req):
         return self.xd.domain_usb_add(self.dom.getName(), req)
                                     ^^^

do_usb_del() is still using domain_usb_add() ..

-- Pasi

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Signature · 8 lines
View this message in context: http://old.nabble.com/-PATCH--fix-bug-in-c-s-20332-Add-commands-to-hotplug-usb-devices-to-hvm-guests-tp26772352p26774299.html
Sent from the Xen - Dev mailing list archive at Nabble.com.


_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel