Skip to contentSkip to conversation

io_uring: remove errant ';' from IORING_CQE_F_TSTAMP_HW definition

PATCH New Jens Axboe 1 participant 1 message Jun 30, 2025 io_uring

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: remove errant ';' from IORING_CQE_F_TSTAMP_HW definition

An errant ';' slipped into that definition, which will cause some compilers to complain when it's used in an application:

timestamp.c:257:45: error: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
257 | hwts = cqe->flags & IORING_CQE_F_TSTAMP_HW;
| ^

Fixes 9e4ed359b8ef ("io_uring/netcmd: add tx timestamping cmd support")

---

Noticed when liburing CI tripped over it, after the merge of the timestamp test case.

include/uapi/linux/io_uring.h +1 -1
index 85600ad0ac08..b6be063693c8 100644
@@ -980,7 +980,7 @@ enum io_uring_socket_op {
 /* The cqe->flags bit from which the timestamp type is stored */
 #define IORING_TIMESTAMP_TYPE_SHIFT	(IORING_TIMESTAMP_HW_SHIFT + 1)
 /* The cqe->flags flag signifying whether it's a hardware timestamp */
-#define IORING_CQE_F_TSTAMP_HW		((__u32)1 << IORING_TIMESTAMP_HW_SHIFT);
+#define IORING_CQE_F_TSTAMP_HW		((__u32)1 << IORING_TIMESTAMP_HW_SHIFT)
 
 struct io_timespec {
 	__u64		tv_sec;
Signature · 1 line
Jens Axboe