Skip to contentSkip to conversation

thermal: ACPI: Include the right header file

PATCH In review Rafael J. Wysocki 2 participants 2 messages Oct 13, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal: ACPI: Include the right header file

From: Rafael J. Wysocki <[email protected]>

It is not necessary to include thermal_core.h into thermal_acpi.c, because none of the code in there depends on anything in the former, except for the linux/thermal.h, but it is better to include that one directly instead of including the entire thermal_core.h, so make that change.

No functional impact.

Fixes 7a0e39748861 ("thermal: ACPI: Add ACPI trip point routines")
---
 drivers/thermal/thermal_acpi.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/thermal/thermal_acpi.c +1 -2
Index: linux-pm/drivers/thermal/thermal_acpi.c
===================================================================
@@ -8,8 +8,7 @@
  */
 #include <linux/acpi.h>
 #include <linux/units.h>
-
-#include "thermal_core.h"
+#include <linux/thermal.h>
 
 /*
  * Minimum temperature for full military grade is 218°K (-55°C) and
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

It is not necessary to include thermal_core.h into thermal_acpi.c, because none of the code in there depends on anything in the former, except for the linux/thermal.h, but it is better to include that one directly instead of including the entire thermal_core.h, so make that change.

Quoted 5 lines

No functional impact.

Fixes 7a0e39748861 ("thermal: ACPI: Add ACPI trip point routines")

---

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog