net: Adds Fast Ethernet Controller driver for Armada100
PATCH v3 1/3 net: Adds Fast Ethernet Controller driver for Armada100
In reply to a message not in the archiveQuoted 8 lines · ----- "Marek Vasut
Quoted 4 lines · Ajay Bhargav
This patch adds support for Fast Ethernet Controller driver for Armada100 series.
Signed-off-by Ajay Bhargav <[email protected]>Hi, please don't forget to CC me next time ;-)
Sure, I'll do that.. you and Mike both :)
Quoted 4 lines
[...]
Quoted 1 line
+static int smi_reg_read(const char *devname, u8
phy_addr, u8
phy_reg,
Quoted 13 lines
Review
Quoted 10 lines
(quoted diff) +10
-0+ u16 *value) +{ + struct eth_device *dev = eth_get_dev_by_name(devname); + struct armdfec_device *darmdfec = to_darmdfec(dev); + struct armdfec_reg *regs = darmdfec->regs; + u32 val, reg_data; + + if (phy_addr == PHY_ADR_REQ && phy_reg == PHY_ADR_REQ) { + reg_data = readl(®s->phyadr); + *value = (u16) (reg_data & 0x1f);Do you need this cast?
I thought I fixed most of the cast related issues :) looks like I missed one.
Quoted 3 lines
Unify the error reporting please.
I will do that...
Quoted 4 lines
It looks good, just a few nits
Cheers!
Cheers! :)
Ajay Bhargav