Skip to contentSkip to conversation

Fix for some 'requesting unregistered parameter'

Powertop Jaroslav Skarvada 2 participants 2 messages Oct 29, 2013 1 message not in the archive

lore
Share & tools
lore

Jaroslav Skarvada

author
#1 lore raw
In reply to a message not in the archive

Hi,

the attached patch may fix 'requesting unregistered parameter' for cases if e.g NIC was added after calibration

regards

Jaroslav

From d1daec6fd9c1d6534d81df1c3c73de9d714b7196 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaroslav=20=C5=A0karvada?= <[email protected]>
Date: Tue, 29 Oct 2013 10:12:12 +0100
Subject: [PATCH] network: fixed 'requesting unregistered parameter' if NIC is
added
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/devices/network.cpp | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
src/devices/network.cpp +21 -0
index d0827ef..002600b 100644
@@ -345,11 +345,32 @@ const char * network::device_name(void)
 
 static void netdev_callback(const char *d_name)
 {
+	char devname[128];
+
 	std::string f_name("/sys/class/net/");
 	if (strcmp(d_name, "lo") == 0)
 		return;
 
 	f_name.append(d_name);
+
+	sprintf(devname, "%s-up", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-powerunsave", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-100", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-1000", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-high", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-packets", d_name);
+	register_parameter(devname);
+
 	network *bl = new(std::nothrow) class network(d_name, f_name.c_str());
 	if (bl) {
 		all_devices.push_back(bl);
Signature · 1 line
1.8.3.1
#2 lore raw
Quoted 5 lines · Jaroslav Skarvada

Hi,

the attached patch may fix 'requesting unregistered parameter' for cases if e.g NIC was added after calibration

added to -next. thanks.

	-ss
Quoted 63 lines

regards

Jaroslav

From d1daec6fd9c1d6534d81df1c3c73de9d714b7196 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaroslav=20=C5=A0karvada?= <jskarvad(a)redhat.com>
Date: Tue, 29 Oct 2013 10:12:12 +0100
Subject: [PATCH] network: fixed 'requesting unregistered parameter' if NIC is
added
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by Jaroslav ??karvada <jskarvad(a)redhat.com>
---
 src/devices/network.cpp | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
src/devices/network.cpp +21 -0
index d0827ef..002600b 100644
@@ -345,11 +345,32 @@ const char * network::device_name(void)
 
 static void netdev_callback(const char *d_name)
 {
+	char devname[128];
+
 	std::string f_name("/sys/class/net/");
 	if (strcmp(d_name, "lo") == 0)
 		return;
 
 	f_name.append(d_name);
+
+	sprintf(devname, "%s-up", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-powerunsave", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-100", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-1000", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-high", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-packets", d_name);
+	register_parameter(devname);
+
 	network *bl = new(std::nothrow) class network(d_name, f_name.c_str());
 	if (bl) {
 		all_devices.push_back(bl);
Signature · 7 lines
1.8.3.1


_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop