Skip to contentSkip to conversation

MMC: new version of the TI Flash Media card reader driver

PATCH Pierre Ossman 2 participants 2 messages Nov 22, 2006 – Jan 7, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · Alex Dubov

I know that the patch is too big, but I have no way to split it up. Basically, I've changed so many things (I had quite a few problems with interrupts after suspend/resume) that it can be regarded as a brand new driver. My SVN became somewhat messy too.

I can post the driver in it full (non-diff) form or as a 4 per-file diffs, but I have no way to split it up into per-issue form (except for issues 3 and 5, which are one-liners).

That's a start. But 4 sounds like it could be broken out with some work.

I'm not saying it's trivial to break this apart, but it is something that needs to be done. At the very least the commit messages need to reflect what is changed and why.

See it as practice as this is an issue you will be hit by now and then as a kernel developer. :)

Rgds

Signature · 5 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
#2 lore raw

Hi.
I just wanted to let you know that I tested the version found in git-mmc.patch (from latest -mm kernel) with kernel version 2.6.20-rc3-g6a4306b3 (2 or 3 days ago Linus' GIT tree).

No problems so far: the driver seems pretty stable: it survived various suspend-to-ram and suspend-to-disk attempts without a single problem, even with the card inserted and filesystem mounted.

Tests were performed with a 2GB SD card, a 512MB MMC card and with a 256 mini-SD.

Best regards,
Fabio

Quoted 31 lines · Pierre Ossman
Quoted 7 lines · Alex Dubov

I know that the patch is too big, but I have no way to split it up. Basically, I've changed so many things (I had quite a few problems with interrupts after suspend/resume) that it can be regarded as a brand new driver. My SVN became somewhat messy too.

I can post the driver in it full (non-diff) form or as a 4 per-file diffs, but I have no way to split it up into per-issue form (except for issues 3 and 5, which are one-liners).

That's a start. But 4 sounds like it could be broken out with some work.

I'm not saying it's trivial to break this apart, but it is something that needs to be done. At the very least the commit messages need to reflect what is changed and why.

See it as practice as this is an issue you will be hit by now and then as a kernel developer. :)

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/