Skip to contentSkip to conversation

FRV: Fix TLB miss mapping cache flush

PATCH New David Howells 1 participant 1 message Mar 30, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FRV: Fix TLB miss mapping cache flush

The attached patch fixes the TLB miss mapping cache flush function.

The flush was attempting to invalidate the coverage start virtual addresses for the cached page table mappings held in registers SCR0 and SCR1 by writing 0 into them. Unfortunately, 0x00000000-0x04000000 is itself a valid part of the virtual address range. This patches places -1 in there instead, thus specifying 0xfc000000-0xffffffff which is covered by a static I/O mapping, and so shouldn't ever be seen by the TLB-miss handler.

---
warthog>diffstat -p1 frv-tlbmiss-2612rc1.diff

 include/asm-frv/tlbflush.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
include/asm-frv/tlbflush.h renamed from warthog/kernels/linux-2.6.12-rc1/include/asm-frv/tlbflush.h +2 -1
diff -uNrp /warthog/kernels/linux-2.6.12-rc1/include/asm-frv/tlbflush.h linux-2.6.12-rc1-frv-tlbmiss/include/asm-frv/tlbflush.h
@@ -58,7 +58,8 @@ do {								\
 #define __flush_tlb_global()			flush_tlb_all()
 #define flush_tlb()				flush_tlb_all()
 #define flush_tlb_kernel_range(start, end)	flush_tlb_all()
-#define flush_tlb_pgtables(mm,start,end)	asm volatile("movgs gr0,scr0 ! movgs gr0,scr1");
+#define flush_tlb_pgtables(mm,start,end) \
+	asm volatile("movgs %0,scr0 ! movgs %0,scr1" :: "r"(ULONG_MAX) : "memory");
 
 #else