x86/platform/olpc: xo15: Stop setting acpi_device_name/class()
Subsystems (3)
Rafael J. Wysocki
maintainerPATCH 1/1 x86/platform/olpc: xo15: Stop setting acpi_device_name/class()
From: Rafael J. Wysocki <[email protected]>
The driver sets acpi_device_name() and acpi_device_class() which are never read afterward, so make it stop doing that and drop the symbols defined specifically for this purpose.
No intentional functional impact.
This will facilitate the removal of device_name and device_class from struct acpi_device_pnp in the future.
--- arch/x86/platform/olpc/olpc-xo15-sci.c | 5 ----- 1 file changed, 5 deletions(-)
arch/x86/platform/olpc/olpc-xo15-sci.c +0 -5
@@ -18,8 +18,6 @@#define DRV_NAME "olpc-xo15-sci"#define PFX DRV_NAME ": " -#define XO15_SCI_CLASS DRV_NAME -#define XO15_SCI_DEVICE_NAME "OLPC XO-1.5 SCI"static unsigned long xo15_sci_gpe;static bool lid_wake_on_close;
@@ -148,9 +146,6 @@ static int xo15_sci_probe(struct platforif (!device)return -ENODEV ; -strscpy (acpi_device_name (device),XO15_SCI_DEVICE_NAME ); -strscpy (acpi_device_class (device),XO15_SCI_CLASS ); -/* Get GPE bit assignment (EC events). */ status =acpi_evaluate_integer (device->handle,"_GPE" ,NULL , &tmp);if (ACPI_FAILURE (status))
Quoted 8 lines · Rafael J. Wysocki
The driver sets
acpi_device_name()andacpi_device_class()which are never read afterward, so make it stop doing that and drop the symbols defined specifically for this purpose.No intentional functional impact.
This will facilitate the removal of
device_nameanddevice_classfrom structacpi_device_pnpin the future.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Ilpo Järvinen
maintainerQuoted 10 lines · Rafael J. Wysocki
The driver sets
acpi_device_name()andacpi_device_class()which are never read afterward, so make it stop doing that and drop the symbols defined specifically for this purpose.No intentional functional impact.
This will facilitate the removal of
device_nameanddevice_classfrom structacpi_device_pnpin the future.[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.
The list of commits applied:
[1/1] x86/platform/olpc: xo15: Stop setting acpi_device_name/class()
commit: 6907aa0289b93481fa9a5847d1280aa665f9cb8f
--
i.