Skip to contentSkip to conversation

dmaengine: ppc4xx: fix off-by-one build failure

DISCUSSION Christian Lamparter 1 participant 1 message Oct 16, 2018 dmaengine

lore
Share & tools
lore
#0 lore raw
Quoted 11 lines · CEST Vinod
Quoted 8 lines · Christian Lamparter

There are two poly_store, but one should have been poly_show.

|adma.c:4382:16: error: conflicting types for 'poly_store'
| static ssize_t poly_store(struct device_driver *dev, const char *buf,
|                ^~~~~~~~~~
|adma.c:4363:16: note: previous definition of 'poly_store' was here
| static ssize_t poly_store(struct device_driver *dev, char *buf)
|                ^~~~~~~~~~

How come no one noticed till now :(

Well, I don't know if this driver works or not. I tried to evaluate if this driver could be modified to fit the PLB4DMA of the APM82181. But sadly this was not the case because the APM82181 and PPC460EX have a new design. So, I just happend to find this little bug, no idea if there's more bit-rot.

Regards,
Christian