extcon for Linux 3.8

GIT PULL MyungJoo Ham 2 participants 4 messages Nov 27, 2012

Share & tools

MyungJoo Ham

author

2012-11-27 00:54 UTC #0 lore raw

Quoted 8 lines · MyungJoo Ham

Quoted 1 line
Please pull extcon patches for Linux 3.8.
This is not a signed-tag pull request, which I thought I asked for previously.
Please create that, so that I can properly know I am getting the right pull request and patches.

A singed tag, "pull_req_20121122", has been already attached at the HEAD of for-next branch.

Would it be more readable if the request is made with
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git tags/pull_req_20121122
rather than
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-next
? (both point to the same commit and I tried the first URL for git request-pull; however git request-pull gives me the second URL as the result)

Cheers,
MyungJoo

Quoted 11 lines

thanks,
greg k-h

�淸�{.n�+돴윯돪�+%듚�깁負쪐w��{.n�+돴쪐{깸G쳺��{ay��,j�f＂톒쉹��묎�z_溫(�쉸듶줷"얎�m��G쳺�◀?솳鈺�&ｘ�~뤳턨O뺞촾퇉v�^�m��띠�◀?뻀�

Greg KH

2012-11-27 04:25 UTC #1 lore raw

Quoted 9 lines · MyungJoo Ham

Quoted 8 lines · MyungJoo Ham
Quoted 1 line
Please pull extcon patches for Linux 3.8.
This is not a signed-tag pull request, which I thought I asked for previously.
Please create that, so that I can properly know I am getting the right pull request and patches.

Quoted 8 lines

A singed tag, "pull_req_20121122", has been already attached at the HEAD of for-next branch.
Would it be more readable if the request is made with
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git tags/pull_req_20121122
rather than
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-next
? (both point to the same commit and I tried the first URL for git request-pull; however git request-pull gives me the second URL as the result)

git request-pull should show you the proper tag, if you are using a new version of git (i.e. something fairly recent.) What version of git are you using? How did you create the signed tag?

thanks,

greg k-h

MyungJoo Ham

author

2012-11-27 07:21 UTC #2 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 19 lines · MyungJoo Ham

Quoted 9 lines
Quoted 8 lines · MyungJoo Ham
Quoted 1 line
Please pull extcon patches for Linux 3.8.
This is not a signed-tag pull request, which I thought I asked for previously.
Please create that, so that I can properly know I am getting the right pull request and patches.
Quoted 8 lines
A singed tag, "pull_req_20121122", has been already attached at the HEAD of for-next branch.
Would it be more readable if the request is made with
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git tags/pull_req_20121122
rather than
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-next
? (both point to the same commit and I tried the first URL for git request-pull; however git request-pull gives me the second URL as the result)

Quoted 7 lines

git request-pull should show you the proper tag, if you are using a new version of git (i.e. something fairly recent.) What version of git are you using? How did you create the signed tag?
thanks,
greg k-h

I'm using 1.7.5.4.

And are you talking about the git update of "682853e68 request-pull: really favor a matching tag"?

The process I did for creating request-pull message was:

$ git tag -U D606808A pull_req_20121122 HEAD
$ git push --tags
$ git request-pull f4a75d2eb7b1e2206094b901be09adb31ba63681 git:/git.kernel.org:/pub/scm/linux/kernel/git/mzx/extcon tags/pull_req_20121122 HEAD

Anyway, with the version 1.7.9.5, it produces messages with proper tag ids.

The following changes since commit f4a75d2eb7b1e2206094b901be09adb31ba63681:

Linux 3.7-rc6 (2012-11-16 17:42:40 -0800)

are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon tags/pull_req_20121122

----------------------------------------------------------------
extcon pull request targetting Linux 3.8 for Greg KH on 2012.11.22 This is based on Linux 3.7 rc6

----------------------------------------------------------------
Alexey Khoroshilov (1):
extcon: arizona: unlock mutex on error path in arizona_micdet()

Chanwoo Choi (1):
extcon: Add missing header file to extcon.h

MyungJoo Ham (1):
extcon: kernel_doc style fix

Sachin Kamat (9):
extcon: Fix return value in extcon-class.c
extcon: max8997: Fix incorrect error check and return value
extcon: max77693: Fix incorrect error check and return value
extcon: max77693: Fix coding style
extcon: max8997: Fix checkpatch error
extcon: max8997: Fix a typo
extcon: max8997: Use devm_kzalloc
extcon: max77693: Use devm_kzalloc
extcon: max77693: Fix uninitialised variable warning

 drivers/extcon/extcon-arizona.c  |    1 +
 drivers/extcon/extcon-class.c    |    2 +-
 drivers/extcon/extcon-max77693.c |   36 ++++++++++++---------------
 drivers/extcon/extcon-max8997.c  |   28 +++++++++------------
 include/linux/extcon.h           |   50 +++++++++++++++++++------------------
 5 files changed, 56 insertions(+), 61 deletions(-)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJQtGkcAAoJEBOhurvWBoCK2EAP/1Hp3nKFCaNbqy7e1yg+bovM aSDSr+0XajZOuF+Cx8yE+2DtaRBEwu7vXyzMOek9daxGBAiLOHu+FyDTa5D67p8J eO031IHkg+Lx6JHip3csRQoyflTDc1pKnAMEKBPBPbVIqErw4q+d0WWfbQQ70z0g Pb3iM+pLb5sIvgbdJBMRsZ1JQFgHj1Fy558s9uaCQtlh2fw6zRuj5yi8nMAzxU8c DfSa0I2ESYeDfj+n5EoUdF3LmGeeSsrgWX4v9EtDCmzCGroddLA8BlmeTXhr32oI 9Kb7VmsUnUDtizQ59WYyiyku3NMa64LPdfqy3wlAJYbQxPJrg2AOlFzwOIbL1uLj 0ix5iq9k2I2bri2fHznpvbFnl/TAX8xiXGh5gfY10Vr4Z45HRFLf55usvAnwW137 I7FH/pkOd+YOBYiO0gIsj5ay7vpHLk9ezE9oXpUe2k9bSYXR3SAfd1cjNeAVQE1g 4nq68c6Mk3kU5COyUfoUIu8k62BnyKsWYzsI6bEfBzN1sfB3Q4fxGP+FVaAEYv80 1VwdiNeUKiDE7RTq5aBr9mXJFwoHwoZ4iuSyaQewyyZEveia9SSpp1KgvSZTAIc/ 8ibW/oVYbz+US0CHzCllLBApjNrDKy/vywFfY4R5R/oxbospKICdogu/hZwbcHw3 1WF9ehMD7PW4HIrcM2hT
=ytmK
-----END PGP SIGNATURE-----

Greg KH

2012-11-27 14:46 UTC #3 lore raw

Quoted 33 lines · MyungJoo Ham

Quoted 20 lines · MyungJoo Ham
Quoted 9 lines
Quoted 8 lines · MyungJoo Ham
Quoted 1 line
Please pull extcon patches for Linux 3.8.
This is not a signed-tag pull request, which I thought I asked for previously.
Please create that, so that I can properly know I am getting the right pull request and patches.
Quoted 8 lines
A singed tag, "pull_req_20121122", has been already attached at the HEAD of for-next branch.
Would it be more readable if the request is made with
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git tags/pull_req_20121122
rather than
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-next
? (both point to the same commit and I tried the first URL for git request-pull; however git request-pull gives me the second URL as the result)
Quoted 7 lines
git request-pull should show you the proper tag, if you are using a new version of git (i.e. something fairly recent.) What version of git are you using? How did you create the signed tag?
thanks,
greg k-h
I'm using 1.7.5.4.
And are you talking about the git update of "682853e68 request-pull: really favor a matching tag"?

Quoted 7 lines

The process I did for creating request-pull message was:
$ git tag -U D606808A pull_req_20121122 HEAD
$ git push --tags
$ git request-pull f4a75d2eb7b1e2206094b901be09adb31ba63681 git:/git.kernel.org:/pub/scm/linux/kernel/git/mzx/extcon tags/pull_req_20121122 HEAD
Anyway, with the version 1.7.9.5, it produces messages with proper tag ids.

Yes, that worked, thanks. There are newer versions of git out there, you should be using the 1.8 version by now. You can always just use the git git tree and install to your local directory, which is what is recommended for kernel developers, to ensure we have the latest version.

Quoted 10 lines

The following changes since commit f4a75d2eb7b1e2206094b901be09adb31ba63681:
Linux 3.7-rc6 (2012-11-16 17:42:40 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon tags/pull_req_20121122
----------------------------------------------------------------
extcon pull request targetting Linux 3.8 for Greg KH on 2012.11.22 This is based on Linux 3.7 rc6

Next time can you provide a bit more information here? I really don't care what the tree is based on (hint, git request-pull just told me that above). See other merges in the kernel tree for examples of good pull request messages as examples.

Now pulled and pushed out, thanks.

greg k-h