phosphor-dbus-interfaces modification process for existing YAML
Hello,
OpenBMC Sensor interface is specified here:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Sensor/Value.interface.yaml
We would need to extend it with new hierarchy/namespace : utilization, and corresponding Unit: Percent.
Should I push change directly to review or do I need to discuss it earlier with someone? My first thought was to address https://github.com/openbmc/docs/blob/master/architecture/sensor-architecture.md , however this document doesn't seem to address these details.
Regards,
Adrian
Quoted 2 lines · Adrian Ambrożewicz
We would need to extend it with new hierarchy/namespace : utilization, and corresponding Unit: Percent.
Seems reasonable to me.
Quoted 4 lines
Should I push change directly to review or do I need to discuss it earlier with someone? My first thought was to address
https://github.com/openbmc/docs/blob/master/architecture/sensor-architecture.md
, however this document doesn't seem to address these details.
It sounds like a straight-forward enough change to just put up a commit that changes the phosphor-dbus-interfaces. Since you're also proposing a new hierarchy for these sensors to fit under, there isn't likely to be any backwards compatibility issues are there? If there are, that's probably when we'd want to expand the scope to a design document.
Signature · 1 line
Patrick Williams
Quoted 11 lines · Adrian Ambrożewicz
Hello,
OpenBMC Sensor interface is specified here:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Sensor/Value.interface.yamlWe would need to extend it with new hierarchy/namespace : utilization, and corresponding Unit: Percent.
Should I push change directly to review or do I need to discuss it earlier with someone? My first thought was to address https://github.com/openbmc/docs/blob/master/architecture/sensor-architecture.md , however this document doesn't seem to address these details.
Regards,
Adrian
Thanks for bringing the topic to the mailing list first! I find discussion here to be much easier than in a docs/designs or phosphor-dbus-interfacs gerrit review. I also think it ends up getting much more visibility.
With that said - this one is pretty straightforward. Your proposal sounds good to me!
thx - brad
W dniu 4/22/2020 o 13:43, Patrick Williams pisze:
Quoted 5 lines · Adrian Ambrożewicz
Quoted 2 lines
We would need to extend it with new hierarchy/namespace : utilization, and corresponding Unit: Percent.
Seems reasonable to me.
It was easy :) Thanks
Quoted 6 lines
Quoted 5 lines
Should I push change directly to review or do I need to discuss it earlier with someone? My first thought was to address
https://github.com/openbmc/docs/blob/master/architecture/sensor-architecture.md
, however this document doesn't seem to address these details.
Quoted 6 lines
It sounds like a straight-forward enough change to just put up a commit that changes the phosphor-dbus-interfaces. Since you're also proposing a new hierarchy for these sensors to fit under, there isn't likely to be any backwards compatibility issues are there? If there are, that's probably when we'd want to expand the scope to a design document.
I don't expect any backward compatibility issues here. I've checked bmcweb implementation and it is just ignoring sensors of unknown 'hierarchy'.
W dniu 4/22/2020 o 13:45, Brad Bishop pisze:
Quoted 8 lines
Quoted 6 lines · Adrian Ambrożewicz
Hello,
OpenBMC Sensor interface is specified here:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Sensor/Value.interface.yaml
Quoted 8 lines
Quoted 6 lines
We would need to extend it with new hierarchy/namespace : utilization, and corresponding Unit: Percent.
Should I push change directly to review or do I need to discuss it earlier with someone? My first thought was to address https://github.com/openbmc/docs/blob/master/architecture/sensor-architecture.md , however this document doesn't seem to address these details.
Regards,
AdrianThanks for bringing the topic to the mailing list first! I find discussion here to be much easier than in a docs/designs or phosphor-dbus-interfacs gerrit review. I also think it ends up getting much more visibility.
Glad to see the enthusiasm :) I will keep that in mind for the future:)
Quoted 2 lines
With that said - this one is pretty straightforward. Your proposal sounds good to me!
Great.
Quoted 2 lines
thx - brad