Skip to contentSkip to conversation

scsi: ufs: Prepare HPB read for cached sub-region

PATCH 정요한(JOUNG YOHAN) Mobile SE 2 participants 2 messages Jun 11, 2021 – Jun 13, 2021 SCSI

lore
Share & tools
lore
#0 lore raw
Quoted 11 lines
(quoted diff) +11 -0
+	/*
+	 * If the region state is active, mctx must be allocated.
+	 * In this case, check whether the region is evicted or
+	 * mctx allcation fail.
+	 */
+	if (unlikely(!srgn->mctx)) {
+		dev_err(&hpb->sdev_ufs_lu->sdev_dev,
+			"no mctx in region %d subregion %d.\n",
+			srgn->rgn_idx, srgn->srgn_idx);
+		return true;
+	}

Review

Quoted 10 lines
(quoted diff) +10 -0
+
+	if ((srgn_offset + cnt) > bitmap_len)
+		bit_len = bitmap_len - srgn_offset;
+	else
+		bit_len = cnt;
+
+	if (find_next_bit(srgn->mctx->ppn_dirty, bitmap_len,
+			  srgn_offset) < bit_len + srgn_offset)
+		return true;
+

It seems unnecessary to search through bitmap_len
How about searching by transfer size?

if (find_next_bit(srgn->mctx->ppn_dirty,
bit_len + srgn_offset, srgn_offset) < bit_len + srgn_offset)

Thanks
Yohan

#1 lore raw
Quoted 25 lines
Quoted 11 lines
(quoted diff) +11 -0
+      /*
+       * If the region state is active, mctx must be allocated.
+       * In this case, check whether the region is evicted or
+       * mctx allcation fail.
+       */
+      if (unlikely(!srgn->mctx)) {
+              dev_err(&hpb->sdev_ufs_lu->sdev_dev,
+                      "no mctx in region %d subregion %d.\n",
+                      srgn->rgn_idx, srgn->srgn_idx);
+              return true;
+      }

Review

Quoted 10 lines
(quoted diff) +10 -0
+
+      if ((srgn_offset + cnt) > bitmap_len)
+              bit_len = bitmap_len - srgn_offset;
+      else
+              bit_len = cnt;
+
+      if (find_next_bit(srgn->mctx->ppn_dirty, bitmap_len,
+                        srgn_offset) < bit_len + srgn_offset)
+              return true;
+

It seems unnecessary to search through bitmap_len
How about searching by transfer size?

Quoted 2 lines

if (find_next_bit(srgn->mctx->ppn_dirty,
bit_len + srgn_offset, srgn_offset) < bit_len + srgn_offset)

Isn't bit_len should be used for size, and not bit_len + srgn_offset ?

Thanks,
Avri

Quoted 3 lines

Thanks
Yohan