Skip to contentSkip to conversation

v5.3.12 SCTP Stream Negotiation Problem

DISCUSSION Fan, Jessie (NSB - CN/Qingdao) 3 participants 4 messages Feb 18, 2020 – Mar 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

I found the SCTP Stream negotiation doesn't work as expected, that is, the local outbound stream and the remote inbound stream comparison seems missing. For example, when the local outstream(16) is greater than the remote inbound stream(2), 16 is saved and used as the "OUTS", which is shown from /proc/pid/net/sctp/assocs below. Can anyone help comment?

From local end point, 16 is set as both the outbound and inbound stream. From the remote end point, 2 is set for both the outbound and inbound stream

However, after the association is up, the inbound and outbound stream is set as (2,16), which I think is unexpected.
sh-4.2# cat 1/net/sctp/assocs
ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS MAXRT T1X T2X RTXC wmema wmemq sndbuf rcvbuf 55dae5bb bb3dec72 0 7 3 0 2415 0 0 504 1223451 2905 3904 xx.xx.xx.xx yy.yy.yy.yy <-> *zz.zz.zz.zz ww.ww.ww.ww 30000 2 16 10 0 0 0 1 0 262144 262144

I further checked the kernel code and found in v5.0, there is still comparison logic: min(outcnt, stream->outcnt) and save the smaller one in the function sctp_stream_alloc_out(). But the logic disappeared in v5.1, and if the "outcnt" is smaller, it's not saved locally.
static int sctp_stream_alloc_out(struct sctp_stream *stream, __u16 outcnt,
gfp_t gfp)

{
        int ret;

        if (outcnt <= stream->outcnt) //Here is problematic, and the outcnt is not saved locally.
                return 0;

        ret = genradix_prealloc(&stream->out, outcnt, gfp);
        if (ret)
                return ret;

        stream->outcnt = outcnt;
        return 0;
}

Thanks,
Jessie and Chris

#1 lore raw

Hi,

Quoted 14 lines · Jessie (NSB - CN/Qingdao)

Hi,

I found the SCTP Stream negotiation doesn't work as expected, that is, the local outbound stream and the remote inbound stream comparison seems missing. For example, when the local outstream(16) is greater than the remote inbound stream(2), 16 is saved and used as the "OUTS", which is shown from /proc/pid/net/sctp/assocs below. Can anyone help comment?

From local end point, 16 is set as both the outbound and inbound stream. From the remote end point, 2 is set for both the outbound and inbound stream

However, after the association is up, the inbound and outbound stream is set as (2,16), which I think is unexpected.
sh-4.2# cat 1/net/sctp/assocs
ASSOC SOCK STY SST ST HBKT ASSOC-ID TX_QUEUE RX_QUEUE UID INODE LPORT RPORT LADDRS <-> RADDRS HBINT INS OUTS MAXRT T1X T2X RTXC wmema wmemq sndbuf rcvbuf 55dae5bb bb3dec72 0 7 3 0 2415 0 0 504 1223451 2905 3904 xx.xx.xx.xx yy.yy.yy.yy <-> *zz.zz.zz.zz ww.ww.ww.ww 30000 2 16 10 0 0 0 1 0 262144 262144

Quoted 8 lines

I further checked the kernel code and found in v5.0, there is still comparison logic: min(outcnt, stream->outcnt) and save the smaller one in the function sctp_stream_alloc_out(). But the logic disappeared in v5.1, and if the "outcnt" is smaller, it's not saved locally.
static int sctp_stream_alloc_out(struct sctp_stream *stream, __u16 outcnt,
gfp_t gfp)

{
        int ret;

        if (outcnt <= stream->outcnt) //Here is problematic, and the outcnt is not saved locally.

Makes sense.
Before 2075e50caf5e ("sctp: convert to genradix") it was updating stream->outcnt with smaller values when applicable:

- if (outcnt > stream->outcnt)
- fa_zero(out, stream->outcnt, (outcnt - stream->outcnt));
+ if (outcnt <= stream->outcnt)
+ return 0;

- stream->out = out;

It also affects the input stream AFAICT.
Can you please try the following patch?

Thanks,
Marcelo

---8<---

net/sctp/stream.c +5 -3
index 67f7e71f9129..34f0b7312fe8 100644
@@ -81,12 +81,13 @@ static int sctp_stream_alloc_out(struct sctp_stream *stream, __u16 outcnt,
 	int ret;
 
 	if (outcnt <= stream->outcnt)
-		return 0;
+		goto out;
 
 	ret = genradix_prealloc(&stream->out, outcnt, gfp);
 	if (ret)
 		return ret;
 
+out:
 	stream->outcnt = outcnt;
 	return 0;
 }
@@ -96,13 +97,14 @@ static int sctp_stream_alloc_in(struct sctp_stream *stream, __u16 incnt,
 {
 	int ret;
 
-	if (incnt <= stream->incnt)
-		return 0;
+	if (incnt > stream->incnt)
+		goto out;
 
 	ret = genradix_prealloc(&stream->in, incnt, gfp);
 	if (ret)
 		return ret;
 
+out:
 	stream->incnt = incnt;
 	return 0;
 }
#2 lore raw
In reply to Fan, Jessie (NSB - CN/Qingdao)

VGhhbmtzIE1hcmNlbG8gZm9yIHRoZSBjb25maXJtYXRpb24uDQpXZSdsbCB0cnkgdGhlIHBhdGNo IHlvdSBzdWdnZXN0Lg0KDQpSZWdhcmRzLA0KQ2hyaXMNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCkZyb206IE1hcmNlbG8gUmljYXJkbyBMZWl0bmVyIDxtYXJjZWxvLmxlaXRuZXJAZ21h aWwuY29tPiANClNlbnQ6IDIwMjDE6jLUwjE4yNUgMTE6NDANClRvOiBGYW4sIEplc3NpZSAoTlNC IC0gQ04vUWluZ2RhbykgPGplc3NpZS5mYW5Abm9raWEtc2JlbGwuY29tPg0KQ2M6IGxpbnV4LXNj dHBAdmdlci5rZXJuZWwub3JnOyBkYWppYW5nLnpoYW5nQG5va2lhLmNvbTsgcGlnZ3lAYWNtLm9y Zzsga2FybEBhdGhlbmEuY2hpY2Fnby5pbC51czsgY2hyaXNAaHVuZHJlZGFjcmUuYWMudWs7IGpn cmltbUB1cy5pYm0uY29tOyB4aW5nYW5nLmd1b0BpbnRlbC5jb207IHNyaUB1cy5pYm0uY29tOyBk YWlzeWNAdXMuaWJtLmNvbTsgYXJkZWxsZS5mYW5AaW50ZWwuY29tOyBrZXZpbi5nYW9AaW50ZWwu Y29tOyBDaGVuLCBDaHJpcyBBLiAoTlNCIC0gQ04vUWluZ2RhbykgPGNocmlzLmEuY2hlbkBub2tp YS1zYmVsbC5jb20+DQpTdWJqZWN0OiBSZTogdjUuMy4xMiBTQ1RQIFN0cmVhbSBOZWdvdGlhdGlv biBQcm9ibGVtDQoNCkhpLA0KDQpPbiBUdWUsIEZlYiAxOCwgMjAyMCBhdCAxMjozNzoxN0FNICsw MDAwLCBGYW4sIEplc3NpZSAoTlNCIC0gQ04vUWluZ2Rhbykgd3JvdGU6DQo+IEhpLA0KPiANCj4g SSBmb3VuZCB0aGUgU0NUUCBTdHJlYW0gbmVnb3RpYXRpb24gZG9lc24ndCB3b3JrIGFzIGV4cGVj dGVkLCB0aGF0IGlzLCB0aGUgbG9jYWwgb3V0Ym91bmQgc3RyZWFtIGFuZCB0aGUgcmVtb3RlIGlu Ym91bmQgc3RyZWFtIGNvbXBhcmlzb24gc2VlbXMgbWlzc2luZy4NCj4gRm9yIGV4YW1wbGUsIHdo ZW4gdGhlIGxvY2FsIG91dHN0cmVhbSgxNikgaXMgZ3JlYXRlciB0aGFuIHRoZSByZW1vdGUgaW5i b3VuZCBzdHJlYW0oMiksIDE2IGlzIHNhdmVkIGFuZCB1c2VkIGFzIHRoZSAiT1VUUyIsIHdoaWNo IGlzIHNob3duIGZyb20gL3Byb2MvcGlkL25ldC9zY3RwL2Fzc29jcyBiZWxvdy4NCj4gQ2FuIGFu eW9uZSBoZWxwIGNvbW1lbnQ/DQo+IA0KPiBGcm9tIGxvY2FsIGVuZCBwb2ludCwgMTYgaXMgc2V0 IGFzIGJvdGggdGhlIG91dGJvdW5kIGFuZCBpbmJvdW5kIHN0cmVhbS4NCj4gRnJvbSB0aGUgcmVt b3RlIGVuZCBwb2ludCwgMiBpcyBzZXQgZm9yIGJvdGggdGhlIG91dGJvdW5kIGFuZCBpbmJvdW5k IA0KPiBzdHJlYW0NCj4gDQo+IEhvd2V2ZXIsIGFmdGVyIHRoZSBhc3NvY2lhdGlvbiBpcyB1cCwg dGhlIGluYm91bmQgYW5kIG91dGJvdW5kIHN0cmVhbSBpcyBzZXQgYXMgKDIsMTYpLCB3aGljaCBJ IHRoaW5rIGlzIHVuZXhwZWN0ZWQuDQo+IHNoLTQuMiMgY2F0IDEvbmV0L3NjdHAvYXNzb2NzDQo+ IEFTU09DIFNPQ0sgU1RZIFNTVCBTVCBIQktUIEFTU09DLUlEIFRYX1FVRVVFIFJYX1FVRVVFIFVJ RCBJTk9ERSBMUE9SVCANCj4gUlBPUlQgTEFERFJTIDwtPiBSQUREUlMgSEJJTlQgSU5TIE9VVFMg TUFYUlQgVDFYIFQyWCBSVFhDIHdtZW1hIHdtZW1xIA0KPiBzbmRidWYgcmN2YnVmIDU1ZGFlNWJi IGJiM2RlYzcyIDAgNyAzIDAgMjQxNSAwIDAgNTA0IDEyMjM0NTEgMjkwNSAzOTA0IA0KPiB4eC54 eC54eC54eCB5eS55eS55eS55eSA8LT4gKnp6Lnp6Lnp6Lnp6IHd3Lnd3Lnd3Lnd3IDMwMDAwIDIg MTYgMTAgMCAwIA0KPiAwIDEgMCAyNjIxNDQgMjYyMTQ0DQo+IA0KPiBJIGZ1cnRoZXIgY2hlY2tl ZCB0aGUga2VybmVsIGNvZGUgYW5kIGZvdW5kIGluIHY1LjAsIHRoZXJlIGlzIHN0aWxsIGNvbXBh cmlzb24gbG9naWM6IG1pbihvdXRjbnQsIHN0cmVhbS0+b3V0Y250KSBhbmQgc2F2ZSB0aGUgc21h bGxlciBvbmUgaW4gdGhlIGZ1bmN0aW9uIHNjdHBfc3RyZWFtX2FsbG9jX291dCgpLg0KPiBCdXQg dGhlIGxvZ2ljIGRpc2FwcGVhcmVkIGluIHY1LjEsIGFuZCBpZiB0aGUgIm91dGNudCIgaXMgc21h bGxlciwgaXQncyBub3Qgc2F2ZWQgbG9jYWxseS4NCj4gc3RhdGljIGludCBzY3RwX3N0cmVhbV9h bGxvY19vdXQoc3RydWN0IHNjdHBfc3RyZWFtICpzdHJlYW0sIF9fdTE2IG91dGNudCwNCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnZnBfdCBnZnApIHsNCj4gICAgICAgICBpbnQg cmV0Ow0KPiANCj4gICAgICAgICBpZiAob3V0Y250IDw9IHN0cmVhbS0+b3V0Y250KSAvL0hlcmUg aXMgcHJvYmxlbWF0aWMsIGFuZCB0aGUgb3V0Y250IGlzIG5vdCBzYXZlZCBsb2NhbGx5Lg0KDQpN YWtlcyBzZW5zZS4NCkJlZm9yZSAyMDc1ZTUwY2FmNWUgKCJzY3RwOiBjb252ZXJ0IHRvIGdlbnJh ZGl4IikgaXQgd2FzIHVwZGF0aW5nDQpzdHJlYW0tPm91dGNudCB3aXRoIHNtYWxsZXIgdmFsdWVz IHdoZW4gYXBwbGljYWJsZToNCg0KLSAgICAgICBpZiAob3V0Y250ID4gc3RyZWFtLT5vdXRjbnQp DQotICAgICAgICAgICAgICAgZmFfemVybyhvdXQsIHN0cmVhbS0+b3V0Y250LCAob3V0Y250IC0g c3RyZWFtLT5vdXRjbnQpKTsNCisgICAgICAgaWYgKG91dGNudCA8PSBzdHJlYW0tPm91dGNudCkN CisgICAgICAgICAgICAgICByZXR1cm4gMDsNCg0KLSAgICAgICBzdHJlYW0tPm91dCA9IG91dDsN Cg0KSXQgYWxzbyBhZmZlY3RzIHRoZSBpbnB1dCBzdHJlYW0gQUZBSUNULg0KQ2FuIHlvdSBwbGVh c2UgdHJ5IHRoZSBmb2xsb3dpbmcgcGF0Y2g/DQoNClRoYW5rcywNCk1hcmNlbG8NCg0KLS0tODwt LS0NCg0KZGlmZiAtLWdpdCBhL25ldC9zY3RwL3N0cmVhbS5jIGIvbmV0L3NjdHAvc3RyZWFtLmMg aW5kZXggNjdmN2U3MWY5MTI5Li4zNGYwYjczMTJmZTggMTAwNjQ0DQotLS0gYS9uZXQvc2N0cC9z dHJlYW0uYw0KKysrIGIvbmV0L3NjdHAvc3RyZWFtLmMNCkBAIC04MSwxMiArODEsMTMgQEAgc3Rh dGljIGludCBzY3RwX3N0cmVhbV9hbGxvY19vdXQoc3RydWN0IHNjdHBfc3RyZWFtICpzdHJlYW0s IF9fdTE2IG91dGNudCwNCiAJaW50IHJldDsNCiANCiAJaWYgKG91dGNudCA8PSBzdHJlYW0tPm91 dGNudCkNCi0JCXJldHVybiAwOw0KKwkJZ290byBvdXQ7DQogDQogCXJldCA9IGdlbnJhZGl4X3By ZWFsbG9jKCZzdHJlYW0tPm91dCwgb3V0Y250LCBnZnApOw0KIAlpZiAocmV0KQ0KIAkJcmV0dXJu IHJldDsNCiANCitvdXQ6DQogCXN0cmVhbS0+b3V0Y250ID0gb3V0Y250Ow0KIAlyZXR1cm4gMDsN CiB9DQpAQCAtOTYsMTMgKzk3LDE0IEBAIHN0YXRpYyBpbnQgc2N0cF9zdHJlYW1fYWxsb2NfaW4o c3RydWN0IHNjdHBfc3RyZWFtICpzdHJlYW0sIF9fdTE2IGluY250LCAgew0KIAlpbnQgcmV0Ow0K IA0KLQlpZiAoaW5jbnQgPD0gc3RyZWFtLT5pbmNudCkNCi0JCXJldHVybiAwOw0KKwlpZiAoaW5j bnQgPiBzdHJlYW0tPmluY250KQ0KKwkJZ290byBvdXQ7DQogDQogCXJldCA9IGdlbnJhZGl4X3By ZWFsbG9jKCZzdHJlYW0tPmluLCBpbmNudCwgZ2ZwKTsNCiAJaWYgKHJldCkNCiAJCXJldHVybiBy ZXQ7DQogDQorb3V0Og0KIAlzdHJlYW0tPmluY250ID0gaW5jbnQ7DQogCXJldHVybiAwOw0KIH0N Cg=

#3 lore raw
In reply to Fan, Jessie (NSB - CN/Qingdao)

SGkgTWFyY2VsbywNCg0KVGhlIGtlcm5lbCBjcmFzaGVkIGFmdGVyIGFwcGx5aW5nIHlvdXIgcGF0 Y2gsIGFuZCBJIHNlZSBTQ1RQIENhbGwgVHJhY2UgaW4gdGhlIGtlcm5lbCBsb2cuDQpJIGRvdWJs ZSBjaGVja2VkIHRoZSBwYXRjaCBmaXgsIGFuZCB0aGUgYmVsb3cgbG9naWMgbG9va3Mgd3Jvbmcu IA0KDQpAQCAtOTYsMTMgKzk3LDE0IEBAIHN0YXRpYyBpbnQgc2N0cF9zdHJlYW1fYWxsb2NfaW4o c3RydWN0IHNjdHBfc3RyZWFtICpzdHJlYW0sIF9fdTE2IGluY250LCAgew0KIAlpbnQgcmV0Ow0K IA0KLQlpZiAoaW5jbnQgPD0gc3RyZWFtLT5pbmNudCkNCi0JCXJldHVybiAwOw0KKwlpZiAoaW5j bnQgPiBzdHJlYW0tPmluY250KQ0KKwkJZ290byBvdXQ7DQogDQogCXJldCA9IGdlbnJhZGl4X3By ZWFsbG9jKCZzdHJlYW0tPmluLCBpbmNudCwgZ2ZwKTsNCiAJaWYgKHJldCkNCiAJCXJldHVybiBy ZXQ7DQogDQorb3V0Og0KIAlzdHJlYW0tPmluY250ID0gaW5jbnQ7DQogCXJldHVybiAwOw0KIH0N Cg0KU2hvdWxkIGNoYW5nZSB0byA6DQoNCkBAIC05NiwxMyArOTcsMTQgQEAgc3RhdGljIGludCBz Y3RwX3N0cmVhbV9hbGxvY19pbihzdHJ1Y3Qgc2N0cF9zdHJlYW0gKnN0cmVhbSwgX191MTYgaW5j bnQsICB7DQogCWludCByZXQ7DQogDQoJaWYgKGluY250IDw9IHN0cmVhbS0+aW5jbnQpDQotCQly ZXR1cm4gMDsNCisJCWdvdG8gb3V0Ow0KIA0KIAlyZXQgPSBnZW5yYWRpeF9wcmVhbGxvYygmc3Ry ZWFtLT5pbiwgaW5jbnQsIGdmcCk7DQogCWlmIChyZXQpDQogCQlyZXR1cm4gcmV0Ow0KIA0KK291 dDoNCiAJc3RyZWFtLT5pbmNudCA9IGluY250Ow0KIAlyZXR1cm4gMDsNCiB9DQoNCkZZSSwga2Vy bmVsIGxvZy4NClsgMzA2NC4xMDY1NDVdIEJVRzoga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVy ZW5jZSwgYWRkcmVzczogMDAwMDAwMDAwMDAwMDAwMA0KWyAzMDY0LjEwODAzMV0gI1BGOiBzdXBl cnZpc29yIHJlYWQgYWNjZXNzIGluIGtlcm5lbCBtb2RlDQpbIDMwNjQuMTA4ODE5XSAjUEY6IGVy cm9yX2NvZGUoMHgwMDAwKSAtIG5vdC1wcmVzZW50IHBhZ2UNClsgMzA2NC4xMDk1NzRdIFBHRCAx YjU4NzMwNjcgUDREIDFiNTg3MzA2NyBQVUQgMWI1ODcwMDY3IFBNRCAwDQpbIDMwNjQuMTEwNDg2 XSBPb3BzOiAwMDAwIFsjMV0gU01QIE5PUFRJDQpbIDMwNjQuMTExMDcwXSBDUFU6IDMgUElEOiAw IENvbW06IHN3YXBwZXIvMyBLZHVtcDogbG9hZGVkIE5vdCB0YWludGVkIDUuNS40LTEuZWw3Lng4 Nl82NCAjMQ0KWyAzMDY0LjExMjM0NF0gSGFyZHdhcmUgbmFtZTogUmVkIEhhdCBPcGVuU3RhY2sg Q29tcHV0ZSwgQklPUyAxLjEwLjItMy5lbDdfNC4yIDA0LzAxLzIwMTQNClsgMzA2NC4xMTM1NTFd IFJJUDogMDAxMDpzY3RwX3ZhbGlkYXRlX2RhdGErMHg3NS8weDkwIFtzY3RwXQ0KWyAzMDY0LjEx NDQ0N10gQ29kZTogYzMgMDggMGYgYjcgYzkgNDggODkgYzggNDggZjcgZTIgNDggYzEgZWEgMDcg NDggNjkgYzIgY2MgMDAgMDAgMDAgNDggYzEgZTIgMGMgNDggMjkgYzEgNDggOGQgMDQgODkgNDgg OGQgMzQgODIgZTggZWIgZDMgYTMgZTAgPDY2PiAyYiAxOCA4OSBkOCBmNyBkMCA1YiA2NiBjMSBl OCAwZiA1ZCBjMyAwZiAxZg0KMDAgNjYgMmUgMGYgMWYgODQNClsgMzA2NC4xMTczMjFdIFJTUDog MDAxODpmZmZmYzkwMDAwMTBjNmYwIEVGTEFHUzogMDAwMTAyNDYNClsgMzA2NC4xMTgxNTRdIFJB WDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IDAwMDAwMDAwMDAwMDAwMDAgUkNYOiAwMDAwMDAwMDAw MDAwMDAwDQpbIDMwNjQuMTE5Mjc0XSBSRFg6IDAwMDAwMDAwMDAwMDAwMDAgUlNJOiAwMDAwMDAw MDAwMDAwMDAwIFJESTogMDAwMDAwMDBmZmZmZmZmZg0KWyAzMDY0LjEyMDQ0OF0gUkJQOiBmZmZm YzkwMDAwMTBjNmY4IFIwODogMDAwMDAwMDAwMDAwMDAwYyBSMDk6IDAwMDAwMDAwMDAwMjAwMDAN ClsgMzA2NC4xMjE0ODVdIFIxMDogZmZmZmZmZmZhMGExMzNiMCBSMTE6IDAwMDAwMDAwYmViOTA2 OGYgUjEyOiBmZmZmYzkwMDAwMTBjN2YwDQpbIDMwNjQuMTIyNTQyXSBSMTM6IGZmZmY4ODgxZTli NjU4NzIgUjE0OiBmZmZmODg4MWRhMzdiZjAwIFIxNTogMDAwMDAwMDA4NmUzNzJjNA0KWyAzMDY0 LjEyMzU5NV0gRlM6ICAwMDAwMDAwMDAwMDAwMDAwKDAwMDApIEdTOmZmZmY4ODgyMzdkODAwMDAo MDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMA0KWyAzMDY0LjEyNDc5NV0gQ1M6ICAwMDEwIERT OiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMw0KWyAzMDY0LjEyNTY1OV0gQ1Iy OiAwMDAwMDAwMDAwMDAwMDAwIENSMzogMDAwMDAwMDFiNTlhNDAwNSBDUjQ6IDAwMDAwMDAwMDAx NjA2ZTANClsgMzA2NC4xMjY3MjVdIENhbGwgVHJhY2U6DQpbIDMwNjQuMTI3MDk0XSAgPElSUT4N ClsgMzA2NC4xMjc0NTVdICBzY3RwX2VhdF9kYXRhKzB4NDQ4LzB4NWYwIFtzY3RwXQ0KWyAzMDY0 LjEyODE1OF0gIHNjdHBfc2ZfZWF0X2RhdGFfNl8yKzB4ZTgvMHgyYTAgW3NjdHBdDQpbIDMwNjQu MTI4OTY0XSAgc2N0cF9kb19zbSsweGE2LzB4MzIwIFtzY3RwXQ0KWyAzMDY0LjEyOTYwOF0gID8g c2N0cF9oYXNfYXNzb2NpYXRpb24rMHg0MC8weDQwIFtzY3RwXQ0KWyAzMDY0LjEzMDM2OV0gID8g eGZybV9wb2xpY3lfbG9va3VwX2J5dHlwZSsweDE2NS8weDM1MA0KWyAzMDY0LjEzMTE2M10gID8g c2VsaW51eF94ZnJtX2RlY29kZV9zZXNzaW9uKzB4MTMvMHgyMA0KWyAzMDY0LjEzMTk4MF0gID8g c2VsaW51eF9wZWVybGJsX2VuYWJsZWQrMHgxZC8weDQwDQpbIDMwNjQuMTMyNzQ0XSAgPyBzZWxp bnV4X3NvY2tldF9zb2NrX3Jjdl9za2IrMHg4YS8weDIzMA0KWyAzMDY0LjEzMzU2N10gID8gX194 ZnJtX3BvbGljeV9jaGVjaysweDU0Mi8weDg0MA0KWyAzMDY0LjEzNDI0MF0gIHNjdHBfYXNzb2Nf YmhfcmN2KzB4MTBhLzB4MWQwIFtzY3RwXQ0KWyAzMDY0LjEzNTAzNl0gIHNjdHBfaW5xX3B1c2gr MHg2YS8weDgwIFtzY3RwXQ0KWyAzMDY0LjEzNTY5MV0gIHNjdHBfcmN2KzB4NGYwLzB4Y2MwIFtz Y3RwXQ0KWyAzMDY0LjEzNjk4M10gID8gaXBfdnNfaW4rMHg0Yi8weGEwIFtpcF92c10NClsgMzA2 NC4xMzgwNTldICBpcF9wcm90b2NvbF9kZWxpdmVyX3JjdSsweDE5NS8weDFiMA0KWyAzMDY0LjEz OTI2Ml0gIGlwX2xvY2FsX2RlbGl2ZXJfZmluaXNoKzB4NDgvMHg1MA0KWyAzMDY0LjE0MDM3NV0g IGlwX2xvY2FsX2RlbGl2ZXIrMHg2Zi8weGYwDQpbIDMwNjQuMTQxNDYzXSAgPyBpcF9wcm90b2Nv bF9kZWxpdmVyX3JjdSsweDFiMC8weDFiMA0KWyAzMDY0LjE0MjU5N10gIGlwX3N1Ymxpc3RfcmN2 X2ZpbmlzaCsweDU5LzB4NzANClsgMzA2NC4xNDM3MzddICBpcF9zdWJsaXN0X3JjdisweDE4Ny8w eDIxMA0KWyAzMDY0LjE0NDY5N10gID8gaXBfcmN2X2NvcmUuaXNyYS4yMCsweDI5MC8weDI5MA0K WyAzMDY0LjE0NTc5NF0gIGlwX2xpc3RfcmN2KzB4MTQyLzB4MTcwDQpbIDMwNjQuMTQ2NzYxXSAg X19uZXRpZl9yZWNlaXZlX3NrYl9saXN0X2NvcmUrMHgyZGMvMHgzMTANClsgMzA2NC4xNDc5NDVd ICA/IGRldl9ncm9fcmVjZWl2ZSsweDY4My8weDZmMA0KWyAzMDY0LjE0ODk3NF0gIG5ldGlmX3Jl Y2VpdmVfc2tiX2xpc3RfaW50ZXJuYWwrMHgxY2EvMHgyZTANClsgMzA2NC4xNTAxMzJdICBncm9f bm9ybWFsX2xpc3QucGFydC4xMzcrMHgxZS8weDQwDQpbIDMwNjQuMTUxMTYwXSAgbmFwaV9jb21w bGV0ZV9kb25lKzB4Y2QvMHgxMjANClsgMzA2NC4xNTIxNDVdICB2aXJ0cXVldWVfbmFwaV9jb21w bGV0ZSsweDJmLzB4NzAgW3ZpcnRpb19uZXRdDQpbIDMwNjQuMTUzMzQ5XSAgdmlydG5ldF9wb2xs KzB4MzE4LzB4MzcwIFt2aXJ0aW9fbmV0XQ0KWyAzMDY0LjE1NDQ2Nl0gIG5ldF9yeF9hY3Rpb24r MHgyODkvMHg0MDANClsgMzA2NC4xNTUzOTldICBfX2RvX3NvZnRpcnErMHhkOS8weDI5ZQ0KWyAz MDY0LjE1NjMyOF0gIGlycV9leGl0KzB4Y2MvMHhlMA0KWyAzMDY0LjE1NzE5NV0gIGRvX0lSUSsw eDVhLzB4ZjANClsgMzA2NC4xNTgwNDldICBjb21tb25faW50ZXJydXB0KzB4Zi8weGYNClsgMzA2 NC4xNTg5OTVdICA8L0lSUT4NClsgMzA2NC4xNTk2MTldIFJJUDogMDAxMDpuYXRpdmVfc2FmZV9o YWx0KzB4MTIvMHgyMA0KDQoNClRoYW5rcywNCkplc3NpZSBhbmQgQ2hyaXMNCg0KDQotLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogTWFyY2VsbyBSaWNhcmRvIExlaXRuZXIgPG1hcmNl bG8ubGVpdG5lckBnbWFpbC5jb20+IA0KU2VudDogMjAyMMTqMtTCMTjI1SAxMTo0MA0KVG86IEZh biwgSmVzc2llIChOU0IgLSBDTi9RaW5nZGFvKSA8amVzc2llLmZhbkBub2tpYS1zYmVsbC5jb20+ DQpDYzogbGludXgtc2N0cEB2Z2VyLmtlcm5lbC5vcmc7IGRhamlhbmcuemhhbmdAbm9raWEuY29t OyBwaWdneUBhY20ub3JnOyBrYXJsQGF0aGVuYS5jaGljYWdvLmlsLnVzOyBjaHJpc0BodW5kcmVk YWNyZS5hYy51azsgamdyaW1tQHVzLmlibS5jb207IHhpbmdhbmcuZ3VvQGludGVsLmNvbTsgc3Jp QHVzLmlibS5jb207IGRhaXN5Y0B1cy5pYm0uY29tOyBhcmRlbGxlLmZhbkBpbnRlbC5jb207IGtl dmluLmdhb0BpbnRlbC5jb207IENoZW4sIENocmlzIEEuIChOU0IgLSBDTi9RaW5nZGFvKSA8Y2hy aXMuYS5jaGVuQG5va2lhLXNiZWxsLmNvbT4NClN1YmplY3Q6IFJlOiB2NS4zLjEyIFNDVFAgU3Ry ZWFtIE5lZ290aWF0aW9uIFByb2JsZW0NCg0KSGksDQoNCk9uIFR1ZSwgRmViIDE4LCAyMDIwIGF0 IDEyOjM3OjE3QU0gKzAwMDAsIEZhbiwgSmVzc2llIChOU0IgLSBDTi9RaW5nZGFvKSB3cm90ZToN Cj4gSGksDQo+IA0KPiBJIGZvdW5kIHRoZSBTQ1RQIFN0cmVhbSBuZWdvdGlhdGlvbiBkb2Vzbid0 IHdvcmsgYXMgZXhwZWN0ZWQsIHRoYXQgaXMsIHRoZSBsb2NhbCBvdXRib3VuZCBzdHJlYW0gYW5k IHRoZSByZW1vdGUgaW5ib3VuZCBzdHJlYW0gY29tcGFyaXNvbiBzZWVtcyBtaXNzaW5nLg0KPiBG b3IgZXhhbXBsZSwgd2hlbiB0aGUgbG9jYWwgb3V0c3RyZWFtKDE2KSBpcyBncmVhdGVyIHRoYW4g dGhlIHJlbW90ZSBpbmJvdW5kIHN0cmVhbSgyKSwgMTYgaXMgc2F2ZWQgYW5kIHVzZWQgYXMgdGhl ICJPVVRTIiwgd2hpY2ggaXMgc2hvd24gZnJvbSAvcHJvYy9waWQvbmV0L3NjdHAvYXNzb2NzIGJl bG93Lg0KPiBDYW4gYW55b25lIGhlbHAgY29tbWVudD8NCj4gDQo+IEZyb20gbG9jYWwgZW5kIHBv aW50LCAxNiBpcyBzZXQgYXMgYm90aCB0aGUgb3V0Ym91bmQgYW5kIGluYm91bmQgc3RyZWFtLg0K PiBGcm9tIHRoZSByZW1vdGUgZW5kIHBvaW50LCAyIGlzIHNldCBmb3IgYm90aCB0aGUgb3V0Ym91 bmQgYW5kIGluYm91bmQgDQo+IHN0cmVhbQ0KPiANCj4gSG93ZXZlciwgYWZ0ZXIgdGhlIGFzc29j aWF0aW9uIGlzIHVwLCB0aGUgaW5ib3VuZCBhbmQgb3V0Ym91bmQgc3RyZWFtIGlzIHNldCBhcyAo MiwxNiksIHdoaWNoIEkgdGhpbmsgaXMgdW5leHBlY3RlZC4NCj4gc2gtNC4yIyBjYXQgMS9uZXQv c2N0cC9hc3NvY3MNCj4gQVNTT0MgU09DSyBTVFkgU1NUIFNUIEhCS1QgQVNTT0MtSUQgVFhfUVVF VUUgUlhfUVVFVUUgVUlEIElOT0RFIExQT1JUIA0KPiBSUE9SVCBMQUREUlMgPC0+IFJBRERSUyBI QklOVCBJTlMgT1VUUyBNQVhSVCBUMVggVDJYIFJUWEMgd21lbWEgd21lbXEgDQo+IHNuZGJ1ZiBy Y3ZidWYgNTVkYWU1YmIgYmIzZGVjNzIgMCA3IDMgMCAyNDE1IDAgMCA1MDQgMTIyMzQ1MSAyOTA1 IDM5MDQgDQo+IHh4Lnh4Lnh4Lnh4IHl5Lnl5Lnl5Lnl5IDwtPiAqenouenouenouenogd3cud3cu d3cud3cgMzAwMDAgMiAxNiAxMCAwIDAgDQo+IDAgMSAwIDI2MjE0NCAyNjIxNDQNCj4gDQo+IEkg ZnVydGhlciBjaGVja2VkIHRoZSBrZXJuZWwgY29kZSBhbmQgZm91bmQgaW4gdjUuMCwgdGhlcmUg aXMgc3RpbGwgY29tcGFyaXNvbiBsb2dpYzogbWluKG91dGNudCwgc3RyZWFtLT5vdXRjbnQpIGFu ZCBzYXZlIHRoZSBzbWFsbGVyIG9uZSBpbiB0aGUgZnVuY3Rpb24gc2N0cF9zdHJlYW1fYWxsb2Nf b3V0KCkuDQo+IEJ1dCB0aGUgbG9naWMgZGlzYXBwZWFyZWQgaW4gdjUuMSwgYW5kIGlmIHRoZSAi b3V0Y250IiBpcyBzbWFsbGVyLCBpdCdzIG5vdCBzYXZlZCBsb2NhbGx5Lg0KPiBzdGF0aWMgaW50 IHNjdHBfc3RyZWFtX2FsbG9jX291dChzdHJ1Y3Qgc2N0cF9zdHJlYW0gKnN0cmVhbSwgX191MTYg b3V0Y250LA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdmcF90IGdmcCkgew0K PiAgICAgICAgIGludCByZXQ7DQo+IA0KPiAgICAgICAgIGlmIChvdXRjbnQgPD0gc3RyZWFtLT5v dXRjbnQpIC8vSGVyZSBpcyBwcm9ibGVtYXRpYywgYW5kIHRoZSBvdXRjbnQgaXMgbm90IHNhdmVk IGxvY2FsbHkuDQoNCk1ha2VzIHNlbnNlLg0KQmVmb3JlIDIwNzVlNTBjYWY1ZSAoInNjdHA6IGNv bnZlcnQgdG8gZ2VucmFkaXgiKSBpdCB3YXMgdXBkYXRpbmcNCnN0cmVhbS0+b3V0Y250IHdpdGgg c21hbGxlciB2YWx1ZXMgd2hlbiBhcHBsaWNhYmxlOg0KDQotICAgICAgIGlmIChvdXRjbnQgPiBz dHJlYW0tPm91dGNudCkNCi0gICAgICAgICAgICAgICBmYV96ZXJvKG91dCwgc3RyZWFtLT5vdXRj bnQsIChvdXRjbnQgLSBzdHJlYW0tPm91dGNudCkpOw0KKyAgICAgICBpZiAob3V0Y250IDw9IHN0 cmVhbS0+b3V0Y250KQ0KKyAgICAgICAgICAgICAgIHJldHVybiAwOw0KDQotICAgICAgIHN0cmVh bS0+b3V0ID0gb3V0Ow0KDQpJdCBhbHNvIGFmZmVjdHMgdGhlIGlucHV0IHN0cmVhbSBBRkFJQ1Qu DQpDYW4geW91IHBsZWFzZSB0cnkgdGhlIGZvbGxvd2luZyBwYXRjaD8NCg0KVGhhbmtzLA0KTWFy Y2Vsbw0KDQotLS04PC0tLQ0KDQpkaWZmIC0tZ2l0IGEvbmV0L3NjdHAvc3RyZWFtLmMgYi9uZXQv c2N0cC9zdHJlYW0uYyBpbmRleCA2N2Y3ZTcxZjkxMjkuLjM0ZjBiNzMxMmZlOCAxMDA2NDQNCi0t LSBhL25ldC9zY3RwL3N0cmVhbS5jDQorKysgYi9uZXQvc2N0cC9zdHJlYW0uYw0KQEAgLTgxLDEy ICs4MSwxMyBAQCBzdGF0aWMgaW50IHNjdHBfc3RyZWFtX2FsbG9jX291dChzdHJ1Y3Qgc2N0cF9z dHJlYW0gKnN0cmVhbSwgX191MTYgb3V0Y250LA0KIAlpbnQgcmV0Ow0KIA0KIAlpZiAob3V0Y250 IDw9IHN0cmVhbS0+b3V0Y250KQ0KLQkJcmV0dXJuIDA7DQorCQlnb3RvIG91dDsNCiANCiAJcmV0 ID0gZ2VucmFkaXhfcHJlYWxsb2MoJnN0cmVhbS0+b3V0LCBvdXRjbnQsIGdmcCk7DQogCWlmIChy ZXQpDQogCQlyZXR1cm4gcmV0Ow0KIA0KK291dDoNCiAJc3RyZWFtLT5vdXRjbnQgPSBvdXRjbnQ7 DQogCXJldHVybiAwOw0KIH0NCkBAIC05NiwxMyArOTcsMTQgQEAgc3RhdGljIGludCBzY3RwX3N0 cmVhbV9hbGxvY19pbihzdHJ1Y3Qgc2N0cF9zdHJlYW0gKnN0cmVhbSwgX191MTYgaW5jbnQsICB7 DQogCWludCByZXQ7DQogDQotCWlmIChpbmNudCA8PSBzdHJlYW0tPmluY250KQ0KLQkJcmV0dXJu IDA7DQorCWlmIChpbmNudCA+IHN0cmVhbS0+aW5jbnQpDQorCQlnb3RvIG91dDsNCiANCiAJcmV0 ID0gZ2VucmFkaXhfcHJlYWxsb2MoJnN0cmVhbS0+aW4sIGluY250LCBnZnApOw0KIAlpZiAocmV0 KQ0KIAkJcmV0dXJuIHJldDsNCiANCitvdXQ6DQogCXN0cmVhbS0+aW5jbnQgPSBpbmNudDsNCiAJ cmV0dXJuIDA7DQogfQ0K