nsproxy: Introduce nsproxy
Subsystems (12)
PATCH 1/9 nsproxy: Introduce nsproxy
In reply to a message not in the archiveIntroduce the nsproxy struct. Doesn't do anything yet, but has it's own lifecycle pretty much mirrorring the fs namespace.
Subsequent patches will move the namespace struct into the nsproxy. Then as more namespaces are introduced, such as utsname, they can be added to the nsproxy as well.
---
arch/alpha/kernel/init_task.c | 2 + arch/arm/kernel/init_task.c | 2 + arch/arm26/kernel/init_task.c | 2 + arch/frv/kernel/init_task.c | 2 + arch/h8300/kernel/init_task.c | 2 + arch/i386/kernel/init_task.c | 2 + arch/ia64/kernel/init_task.c | 2 + arch/m32r/kernel/init_task.c | 2 + arch/m68knommu/kernel/init_task.c | 2 + arch/mips/kernel/init_task.c | 2 + arch/parisc/kernel/init_task.c | 2 + arch/powerpc/kernel/init_task.c | 2 + arch/s390/kernel/init_task.c | 2 + arch/sh/kernel/init_task.c | 2 + arch/sh64/kernel/init_task.c | 2 + arch/sparc/kernel/init_task.c | 2 + arch/sparc64/kernel/init_task.c | 2 + arch/um/kernel/init_task.c | 2 + arch/v850/kernel/init_task.c | 2 + arch/x86_64/kernel/init_task.c | 2 + include/linux/init_task.h | 7 +++++ include/linux/nsproxy.h | 37 ++++++++++++++++++++++++++ include/linux/sched.h | 2 + kernel/Makefile | 2 + kernel/exit.c | 6 ++++ kernel/fork.c | 18 ++++++++++++- kernel/nsproxy.c | 53 +++++++++++++++++++++++++++++++++++++ 27 files changed, 163 insertions(+), 2 deletions(-) create mode 100644 include/linux/nsproxy.h create mode 100644 kernel/nsproxy.c
0aa5d4e8036649cdb22ea8bc813ba491798e3f13
arch/alpha/kernel/init_task.c +2 -0
@@ -5,6 +5,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h>
@@ -13,6 +14,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);struct task_struct init_task =INIT_TASK (init_task);EXPORT_SYMBOL (init_mm);
arch/arm/kernel/init_task.c +2 -0
@@ -8,6 +8,7 @@ #include <linux/sched.h>#include <linux/init.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -17,6 +18,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/arm26/kernel/init_task.c +2 -0
@@ -11,6 +11,7 @@ #include <linux/sched.h>#include <linux/init.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -20,6 +21,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/frv/kernel/init_task.c +2 -0
@@ -5,6 +5,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -15,6 +16,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/h8300/kernel/init_task.c +2 -0
@@ -8,6 +8,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -17,6 +18,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/i386/kernel/init_task.c +2 -0
@@ -5,6 +5,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -15,6 +16,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/ia64/kernel/init_task.c +2 -0
@@ -12,6 +12,7 @@ #include <linux/module.h>#include <linux/sched.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -21,6 +22,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/m32r/kernel/init_task.c +2 -0
@@ -7,6 +7,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -16,6 +17,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/m68knommu/kernel/init_task.c +2 -0
@@ -8,6 +8,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -17,6 +18,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/mips/kernel/init_task.c +2 -0
@@ -4,6 +4,7 @@ #include <linux/sched.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/thread_info.h> #include <asm/uaccess.h>
@@ -14,6 +15,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/parisc/kernel/init_task.c +2 -0
@@ -28,6 +28,7 @@ #include <linux/sched.h>#include <linux/init.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -38,6 +39,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/powerpc/kernel/init_task.c +2 -0
@@ -5,6 +5,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> static struct fs_struct init_fs =INIT_FS ;
@@ -12,6 +13,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/s390/kernel/init_task.c +2 -0
@@ -11,6 +11,7 @@ #include <linux/module.h>#include <linux/sched.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -20,6 +21,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/sh/kernel/init_task.c +2 -0
@@ -3,6 +3,7 @@ #include <linux/module.h>#include <linux/sched.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -12,6 +13,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/sh64/kernel/init_task.c +2 -0
@@ -14,6 +14,7 @@ #include <linux/mm.h>#include <linux/sched.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -23,6 +24,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);struct pt_regs fake_swapper_regs;
arch/sparc/kernel/init_task.c +2 -0
@@ -3,6 +3,7 @@ #include <linux/module.h>#include <linux/sched.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/pgtable.h> #include <asm/uaccess.h>
@@ -12,6 +13,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);struct task_struct init_task =INIT_TASK (init_task);EXPORT_SYMBOL (init_mm);
arch/sparc64/kernel/init_task.c +2 -0
@@ -3,6 +3,7 @@ #include <linux/module.h>#include <linux/sched.h> #include <linux/init_task.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/pgtable.h> #include <asm/uaccess.h>
@@ -13,6 +14,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/um/kernel/init_task.c +2 -0
@@ -9,6 +9,7 @@ #include "linux/module.h"#include "linux/sched.h" #include "linux/init_task.h" #include "linux/mqueue.h" +#include "linux/nsproxy.h" #include "asm/uaccess.h" #include "asm/pgtable.h" #include "user_util.h"
@@ -17,6 +18,7 @@ #include "os.h"static struct fs_struct init_fs =INIT_FS ;struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);static struct files_struct init_files =INIT_FILES ;static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);
arch/v850/kernel/init_task.c +2 -0
@@ -16,6 +16,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -25,6 +26,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
arch/x86_64/kernel/init_task.c +2 -0
@@ -5,6 +5,7 @@ #include <linux/init.h>#include <linux/init_task.h> #include <linux/fs.h> #include <linux/mqueue.h> +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/pgtable.h>
@@ -15,6 +16,7 @@ static struct files_struct init_files =static struct signal_struct init_signals =INIT_SIGNALS (init_signals);static struct sighand_struct init_sighand =INIT_SIGHAND (init_sighand);struct mm_struct init_mm =INIT_MM (init_mm); +struct nsproxy init_nsproxy =INIT_NSPROXY (init_nsproxy);EXPORT_SYMBOL (init_mm);
include/linux/init_task.h +7 -0
@@ -66,6 +66,12 @@ #define INIT_SIGNALS(sig) { \ .session = 1, \ } +extern struct nsproxy init_nsproxy; +#define INIT_NSPROXY (nsproxy) { \ + .count = ATOMIC_INIT(1), \ + .nslock = SPIN_LOCK_UNLOCKED, \ +} +#define INIT_SIGHAND (sighand) { \ .count = ATOMIC_INIT(1), \ .action = { { { .sa_handler = NULL, } }, }, \
@@ -114,6 +120,7 @@ #define INIT_TASK(tsk) \ .files = &init_files, \ .signal = &init_signals, \ .sighand = &init_sighand, \ + .nsproxy = &init_nsproxy, \ .pending = { \ .list = LIST_HEAD_INIT(tsk.pending.list), \ .signal = {{0}}}, \
include/linux/nsproxy.h new file +37 -0
@@ -0,0 +1,37 @@ +#ifndef _LINUX_NSPROXY_H +#define _LINUX_NSPROXY_H + +#include <linux/spinlock.h> +#include <linux/sched.h> + +struct nsproxy { +atomic_t count; +spinlock_t nslock; +}; +extern struct nsproxy init_nsproxy; + +static inline void get_nsproxy (struct nsproxy *nsp) +{ +atomic_inc (&nsp->count); +} + +struct nsproxy *clone_nsproxy (struct nsproxy *orig); +int copy_nsproxy (int flags,struct task_struct *tsk); +void free_nsproxy (struct nsproxy *nsp); + +static inline void put_nsproxy (struct nsproxy *nsp) +{ +if (atomic_dec_and_test (&nsp->count)) { +kfree (nsp); + } +} + +static inline void exit_nsproxy (struct task_struct *p) +{ +struct nsproxy *nsp = p->nsproxy; +if (nsp) { + p->nsproxy =NULL ; +put_nsproxy (nsp); + } +} +#endif
include/linux/sched.h +2 -0
@@ -236,6 +236,7 @@ extern signed long schedule_timeout_unin asmlinkage void schedule(void);struct namespace ; +struct nsproxy ;/* Maximum number of active map areas.. This is a random (large) number */ #define DEFAULT_MAX_MAP_COUNT 65536
@@ -808,6 +809,7 @@ #endifstruct files_struct *files;/* namespace */ struct namespace *namespace; +struct nsproxy *nsproxy;/* signal handlers */ struct signal_struct *signal;struct sighand_struct *sighand;
kernel/Makefile +1 -1
@@ -8,7 +8,7 @@ obj-y = sched.o fork.o exec_domain.o signal.o sys.o kmod.o workqueue.o pid.o \ rcupdate.o extable.o params.o posix-timers.o \ kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o mutex.o \ - hrtimer.o + hrtimer.o nsproxy.o obj-$(CONFIG_DEBUG_MUTEXES) += mutex-debug.o obj-$(CONFIG_FUTEX) += futex.o
kernel/exit.c +6 -0
@@ -36,6 +36,7 @@ #include <linux/futex.h>#include <linux/compat.h> #include <linux/pipe_fs_i.h> #include <linux/audit.h> /* for audit_free() */ +#include <linux/nsproxy.h> #include <asm/uaccess.h> #include <asm/unistd.h>
@@ -174,6 +175,7 @@ repeat:write_unlock_irq (&tasklist_lock);spin_unlock (&p->proc_lock);proc_pid_flush (proc_dentry); +exit_nsproxy (p);release_thread (p);call_rcu (&p->rcu, delayed_put_task_struct);
@@ -416,6 +418,9 @@ void daemonize(const char *name, ...)exit_namespace (current); current->namespace = init_task.namespace;get_namespace (current->namespace); +exit_nsproxy (current); + current->nsproxy = init_task.nsproxy; +get_nsproxy (current->nsproxy);exit_files (current); current->files = init_task.files;atomic_inc (¤t->files->count);
@@ -919,6 +924,7 @@ #endif__exit_files (tsk);__exit_fs (tsk);exit_namespace (tsk); +exit_nsproxy (current);exit_thread ();cpuset_exit (tsk);exit_keys (tsk);
kernel/fork.c +17 -1
@@ -44,6 +44,7 @@ #include <linux/profile.h>#include <linux/rmap.h> #include <linux/acct.h> #include <linux/cn_proc.h> +#include <linux/nsproxy.h> #include <asm/pgtable.h> #include <asm/pgalloc.h>
@@ -1060,8 +1061,10 @@ #endif goto bad_fork_cleanup_signal;if ((retval =copy_keys (clone_flags, p))) goto bad_fork_cleanup_mm; -if ((retval =copy_namespace (clone_flags, p))) +if ((retval =copy_nsproxy (clone_flags, p))) goto bad_fork_cleanup_keys; +if ((retval =copy_namespace (clone_flags, p))) + goto bad_fork_cleanup_nsproxy; retval =copy_thread (0 , clone_flags, stack_start, stack_size, p, regs);if (retval) goto bad_fork_cleanup_namespace;
@@ -1218,6 +1221,8 @@ #endif bad_fork_cleanup_namespace:exit_namespace (p); +bad_fork_cleanup_nsproxy: +exit_nsproxy (p); bad_fork_cleanup_keys:exit_keys (p); bad_fork_cleanup_mm:
@@ -1559,6 +1564,7 @@ asmlinkage long sys_unshare(unsigned lonstruct mm_struct *mm, *new_mm =NULL , *active_mm =NULL ;struct files_struct *fd, *new_fd =NULL ;struct sem_undo_list *new_ulist =NULL ; +struct nsproxy *new_nsproxy, *old_nsproxy;check_unshare_flags (&unshare_flags);
@@ -1585,7 +1591,16 @@ asmlinkage long sys_unshare(unsigned lonif (new_fs || new_ns || new_sigh || new_mm || new_fd || new_ulist) { + old_nsproxy = current->nsproxy; + new_nsproxy =clone_nsproxy (old_nsproxy); +if (!new_nsproxy) { + err = -ENOMEM ; + goto bad_unshare_cleanup_semundo; + } +task_lock (current); + current->nsproxy = new_nsproxy; +put_nsproxy (old_nsproxy);if (new_fs) { fs = current->fs;
@@ -1623,6 +1638,7 @@ asmlinkage long sys_unshare(unsigned lontask_unlock (current); } +bad_unshare_cleanup_semundo: bad_unshare_cleanup_fd:if (new_fd)put_files_struct (new_fd);
kernel/nsproxy.c new file +53 -0
53 lines not on this page · raw message
Signature · 1 line
1.3.0
Quoted 6 lines · Serge E. Hallyn
Introduce the nsproxy struct. Doesn't do anything yet, but has it's own lifecycle pretty much mirrorring the fs namespace.
Subsequent patches will move the namespace struct into the nsproxy. Then as more namespaces are introduced, such as utsname, they can be added to the nsproxy as well.
Is there any reason why those can't be simply part of namespace? I.e. be carried by the stuff mounted in standard places...
Quoted 10 lines · Al Viro
Quoted 6 lines · Serge E. Hallyn
Introduce the nsproxy struct. Doesn't do anything yet, but has it's own lifecycle pretty much mirrorring the fs namespace.
Subsequent patches will move the namespace struct into the nsproxy. Then as more namespaces are introduced, such as utsname, they can be added to the nsproxy as well.
Is there any reason why those can't be simply part of namespace? I.e. be carried by the stuff mounted in standard places...
The argument has been that it is desirable to be able to unshare these namespaces - uid, pid, network, sysv, utsname, fs-namespace - separately. Are you talking about having these all be part of a single namespace unshared all at once (and stored in struct namespace)? Or am I misunderstandimg you entirely?
Andi Kleen (I believe) thinks it should be like that, all or nothing. I think Herbert Poetzl had current examples where vserver is used to unshare just pieces, i.e. apache unsharing network but sharing global pidspace.
thanks,
-serge
Quoted 9 lines · Serge E. Hallyn
Quoted 8 lines · Al Viro
Quoted 6 lines · Serge E. Hallyn
Introduce the nsproxy struct. Doesn't do anything yet, but has it's own lifecycle pretty much mirrorring the fs namespace.
Subsequent patches will move the namespace struct into the nsproxy. Then as more namespaces are introduced, such as utsname, they can be added to the nsproxy as well.
Quoted 8 lines
Quoted 2 lines
Is there any reason why those can't be simply part of namespace? I.e. be carried by the stuff mounted in standard places...
The argument has been that it is desirable to be able to unshare these namespaces - uid, pid, network, sysv, utsname, fs-namespace - separately. Are you talking about having these all be part of a single namespace unshared all at once (and stored in struct namespace)? Or am I misunderstandimg you entirely?
the straight forward approach was to have N (currently nine?) different 'spaces' all referenced by a task, and the latest idea to optimize that (Andi made that some requirement IIRC) was to have one structure referenced by the task struct, which holds the references to those 'spaces'
Quoted 4 lines
Andi Kleen (I believe) thinks it should be like that, all or nothing. I think Herbert Poetzl had current examples where vserver is used to unshare just pieces, i.e. apache unsharing network but sharing global pidspace.
we (Linux-VServer) basically consider the various 'spaces' building blocks (or smallest units) to build larger environments which are isolated or virtualized in some aspects, but not all of them.
think of it as: chroot(), chnamespace, chcontext, chbind, ...
existing examples (just to get the idea) are:
- cooperating applications which are limited to a subset of the available network addresses
- strictly isolated (pid and resources) services on the same filesystem and network
best,
Herbert
Quoted 2 lines
thanks,
-serge
Quoted 10 lines · Al Viro
Quoted 6 lines · Serge E. Hallyn
Introduce the nsproxy struct. Doesn't do anything yet, but has it's own lifecycle pretty much mirrorring the fs namespace.
Subsequent patches will move the namespace struct into the nsproxy. Then as more namespaces are introduced, such as utsname, they can be added to the nsproxy as well.
Is there any reason why those can't be simply part of namespace? I.e. be carried by the stuff mounted in standard places...
Wee... Exploring the implementation space.
So the namespaces under discussion are:
- The uts namespace
- The sysvipc namespace
- The pid namespace
- The network namespace
- The uid namespace
- The time namespace
None of which are currently expressed as a standard mount, so there is not an obvious mapping. Suggestions?
A standard mount location is not strong enough, it must be a fixed mount location so the kernel can use it.
Looking at a fixed mount location in the kernel looks likely to be too clumsy to use we would need pointers similar to those in fs_struct to cache the mount, and we would still have the problem of identifying which mounts from kernel space are for the different namespaces.
I am a little concerned about the overhead in implementing this on the kernel side but those are simply implementation optimization issues not semantic issues.
Exporting the different kernel namespaces/subsystem through filesystems sounds reasonable if it will simplify the semantics. Currently the only practical difference I can see is that you could use mount/umount instead of clone and unshare. Which seems to give us additional complications for no real gain.
If we did not have to be backwards compatible and we could reduce our number of system calls by exporting whole subsystem instances as filesystem mounts I can see great gains here, but since we are concerned with existing namespaces/subsystems and just want to make it appear that we have multiple instances of them I don't see any gains.
Eric