Skip to contentSkip to conversation

mark install_page static

PATCH Petr Vandrovec 3 participants 3 messages Sep 7, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 1 line · Christoph Hellwig

Not used anywhere in modules and it really shouldn't either.

How are modules supposed to implement vma's populate method without having install_page available? And yes, there are out of tree kernel modules which prefer fremap & populate & install_page over creating several thousands of VMAs to get non-linear mappings.
Thanks,
Petr Vandrovec

Quoted 10 lines
mm/fremap.c 2004-09-07 13:51:20 +02:00 renamed from mm/fremap.c 2004-08-23 10:15:12 +02:00 +0 -2
@@ -99,8 +99,6 @@
    spin_unlock(&mm->page_table_lock);
    return err;
 }
-EXPORT_SYMBOL(install_page);
-
 
#1 lore raw
Quoted 7 lines · Petr Vandrovec
Quoted 1 line · Christoph Hellwig

Not used anywhere in modules and it really shouldn't either.

How are modules supposed to implement vma's populate method without having install_page available? And yes, there are out of tree kernel modules which prefer fremap & populate & install_page over creating several thousands of VMAs to get non-linear mappings.

Submit them fo inclusion and we can consider them.

#2 lore raw
In reply to Petr Vandrovec
Quoted 1 line · Christoph Hellwig
Quoted 1 line

Not used anywhere in modules and it really shouldn't either.

Quoted 4 lines · Petr Vandrovec

How are modules supposed to implement vma's populate method without having install_page available? And yes, there are out of tree kernel modules which prefer fremap & populate & install_page over creating several thousands of VMAs to get non-linear mappings.

I think this is serious enough to keep the export.

-- wli