io_uring/cmd_net: fix wrong argument types for skb_queue_splice()
Jens Axboe
maintainerPATCH 1/1 io_uring/cmd_net: fix wrong argument types for skb_queue_splice()
If timestamp retriving needs to be retried and the local list of SKB's already has entries, then it's spliced back into the socket queue. However, the arguments for the splice helper are transposed, causing exactly the wrong direction of splicing into the on-stack list. Fix that up.
Reported-by Google Big Sleep <[email protected]>
Fixes 9e4ed359b8ef ("io_uring/netcmd: add tx timestamping cmd support")
Signed-off-by Jens Axboe <[email protected]>
---
io_uring/cmd_net.c +1 -1
@@ -127,7 +127,7 @@ static int io_uring_cmd_timestamp(struct socket *sock,if (!unlikely (skb_queue_empty (&list))) { scoped_guard(spinlock_irqsave, &q->lock) -skb_queue_splice (q, &list); +skb_queue_splice (&list, q); }return -EAGAIN ; }
Signature · 1 line
Jens Axboe
Quoted 28 lines · Jens Axboe
If timestamp retriving needs to be retried and the local list of SKB's already has entries, then it's spliced back into the socket queue. However, the arguments for the splice helper are transposed, causing exactly the wrong direction of splicing into the on-stack list. Fix that up.
Reported-by Google Big Sleep <[email protected]>Fixes 9e4ed359b8ef ("io_uring/netcmd: add tx timestamping cmd support")Signed-off-by Jens Axboe <[email protected]>---
io_uring/cmd_net.c +1
-1@@ -127,7 +127,7 @@ static int io_uring_cmd_timestamp(struct socket *sock,if (!unlikely (skb_queue_empty (&list))) { scoped_guard(spinlock_irqsave, &q->lock) -skb_queue_splice (q, &list); +skb_queue_splice (&list, q); }return -EAGAIN ; }Signature · 1 line
--
Thanks for the quick patch!
Reviewed-by Günther Noack <[email protected]>
Tested-by Günther Noack <[email protected]>
—Günther