Skip to contentSkip to conversation

fix typo in pm.h

PATCH In review Coywolf Qi Hunt 5 participants 6 messages Mar 8, 2005

Subsystems (4)
Kernel janitors Suspend to RAM Hibernation Power management core
lore
Share & tools
lore

Coywolf Qi Hunt

author
#0 lore raw

PATCH 1/1 fix typo in pm.h

This patch fixes a typo in PMSG_ comment in pm.h.

Signed-off-by Coywolf Qi Hunt <[email protected]>
include/linux/pm.h +0 -0
diff -Nrup 2.6.11/include/linux/pm.h 2.6.11-cy/include/linux/pm.h
@@ -208,7 +208,7 @@ typedef u32 __bitwise pm_message_t;
  *           pci D3.
  *
  * Unfortunately, current drivers only recognize numeric values 0

(ON) and 3 (SUSPEND).
- * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
+ * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
* and will go away as soon as drivers are fixed. Also note that
typedef is neccessary,
* we'll probably want to switch to
* typedef struct pm_message_t { int event; int flags; } pm_message_t

Signature · 2 lines
Coywolf Qi Hunt
Homepage http://sosdg.org/~coywolf/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 12 lines · Coywolf Qi Hunt

This patch fixes a typo in PMSG_ comment in pm.h.

Signed-off-by Coywolf Qi Hunt <[email protected]>

diff -Nrup 2.6.11/include/linux/pm.h 2.6.11-cy/include/linux/pm.h

include/linux/pm.h +0 -0
@@ -208,7 +208,7 @@ typedef u32 __bitwise pm_message_t;
  *           pci D3.
  *
  * Unfortunately, current drivers only recognize numeric values 0

(ON) and 3 (SUSPEND).

Quoted 8 lines

- * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
+ * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
* and will go away as soon as drivers are fixed. Also note that
typedef is neccessary,
* we'll probably want to switch to
* typedef struct pm_message_t { int event; int flags; } pm_message_t

Your patch got wrapped.

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#2 lore raw
In reply to Coywolf Qi Hunt
Quoted 2 lines · Nishanth Aravamudan

Your patch got wrapped.

This patch fixes a typo in PMSG_ comment in pm.h.

Signed-off-by Coywolf Qi Hunt <[email protected]>
include/linux/pm.h +0 -0
diff -Nrup 2.6.11/include/linux/pm.h 2.6.11-cy/include/linux/pm.h
@@ -208,7 +208,7 @@ typedef u32 __bitwise pm_message_t;
  *           pci D3.
  *
  * Unfortunately, current drivers only recognize numeric values 0

(ON) and 3 (SUSPEND).
- * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
+ * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
* and will go away as soon as drivers are fixed. Also note that
typedef is neccessary,
* we'll probably want to switch to
* typedef struct pm_message_t { int event; int flags; } pm_message_t

Signature · 2 lines
Coywolf Qi Hunt
Homepage http://sosdg.org/~coywolf/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw
In reply to Coywolf Qi Hunt

* Coywolf Qi Hunt <[email protected]>:

Quoted 3 lines

This patch fixes a typo in PMSG_ comment in pm.h.

Signed-off-by Coywolf Qi Hunt <[email protected]>

I just spotted two more. Patch together with your one.

include/linux/pm.h renamed from include/linux/pm.h.orig +3 -3
@@ -153,7 +153,7 @@
 #endif /* CONFIG_PM */
 
 /* Functions above this comment are list-based old-style power
- * managment. Please avoid using them.  */
+ * management. Please avoid using them.  */
 
 /*
  * Callbacks for platform drivers to implement.

@@ -208,8 +208,8 @@
  *           pci D3.
  *
  * Unfortunately, current drivers only recognize numeric values 0 (ON) and 3 (SUSPEND).
- * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
- * and will go away as soon as drivers are fixed. Also note that typedef is neccessary,
+ * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
+ * and will go away as soon as drivers are fixed. Also note that typedef is necessary,
  * we'll probably want to switch to
  *   typedef struct pm_message_t { int event; int flags; } pm_message_t
  * or something similar soon.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#5 lore raw
In reply to Coywolf Qi Hunt
Quoted 7 lines · Nicolas Kaiser

- * managment. Please avoid using them. */
+ * management. Please avoid using them. */

- * We'll need to fix the drivers. So yes, putting 3 to all diferent defines is intentional,
- * and will go away as soon as drivers are fixed. Also note that typedef is neccessary,
+ * We'll need to fix the drivers. So yes, putting 3 to all different defines is intentional,
+ * and will go away as soon as drivers are fixed. Also note that typedef is necessary,

Always grep the entire tree if typo is found. You know, identical keyboards, people copy, ... ;-)

linux-2.6.11-bk4]$ grep managment -r . | wc -l
21

linux-2.6.11-bk4]$ grep neccessary -r . | wc -l
18

Alexey

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors