Skip to contentSkip to conversation

unexport and static __mntput()

DISCUSSION Coywolf Qi Hunt 3 participants 3 messages Jun 9, 2005 – Jun 11, 2005

lore
Share & tools
lore
#0 lore raw

Hello,

I don't see any reasons that modules should call __mntput.
And it's only called by mntput(). Or anyone knows any outer code depends on it?

Adrian, a patch unexport and static it?

Signature · 2 lines
Coywolf Qi Hunt
http://ahbl.org/~coywolf/
#1 lore raw
Quoted 7 lines · Coywolf Qi Hunt

Hello,

I don't see any reasons that modules should call __mntput.
And it's only called by mntput(). Or anyone knows any outer code depends on it?

Adrian, a patch unexport and static it?

It's used indirectly by autofs, autofs4 and nfsd.

Mike Waychison

#2 lore raw
In reply to Coywolf Qi Hunt
Quoted 6 lines · Coywolf Qi Hunt

Hello,

I don't see any reasons that modules should call __mntput.
And it's only called by mntput(). Or anyone knows any outer code depends on it?

Adrian, a patch unexport and static it?

Besides it being wrong (as Mike Waychison already explained), why can't you make patches yourself? It's not that I had any special position in kernel development...

Quoted 1 line

Coywolf Qi Hunt

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed