Skip to contentSkip to conversation

lsm: Fix signedness bug in selinux_secid_to_secctx()

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 2, 2024 – Nov 5, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lsm: Fix signedness bug in selinux_secid_to_secctx()

The "ret" variable needs to be signed for the error checking to work.

Fixes 95a3c11eb670 ("lsm: replace context+len with lsm_context")
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/hooks.c +1 -1
index eca9674c9478..0ff018f557ac 100644
@@ -6644,7 +6644,7 @@ static int selinux_ismaclabel(const char *name)
 static int selinux_secid_to_secctx(u32 secid, struct lsm_context *cp)
 {
 	u32 seclen;
-	u32 ret;
+	int ret;
 
 	if (cp) {
 		cp->id = LSM_ID_SELINUX;
Signature · 1 line
2.45.2
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Dan Carpenter

The "ret" variable needs to be signed for the error checking to work.

Doh.

Thank you.

Quoted 20 lines
Fixes 95a3c11eb670 ("lsm: replace context+len with lsm_context")
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/hooks.c +1 -1
index eca9674c9478..0ff018f557ac 100644
@@ -6644,7 +6644,7 @@ static int selinux_ismaclabel(const char *name)
 static int selinux_secid_to_secctx(u32 secid, struct lsm_context *cp)
 {
 	u32 seclen;
-	u32 ret;
+	int ret;
 
 	if (cp) {
 		cp->id = LSM_ID_SELINUX;
maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 8 lines · Dan Carpenter

The "ret" variable needs to be signed for the error checking to work.

Fixes 95a3c11eb670 ("lsm: replace context+len with lsm_context")
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Merged into lsm/dev-staging, thanks Dan.

Signature · 1 line
paul-moore.com