Skip to contentSkip to conversation

m68k/PCI: Fix a memory leak in an error handling path

PATCH Markus Elfring 2 participants 2 messages Apr 18, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

If 'ioremap' fails, we must free 'bridge', as done in other error handling path bellow.

I suggest to improve this change description.

* Please avoid a typo.

* Is an imperative wording preferred?

…

Review static int __init mcf_pci_init(void)

Quoted 2 lines

+++ b/arch/m68k/coldfire/pci.c

(quoted diff) +0 -0
@@ -216,8 +216,10 @@ static int __init mcf_pci_init(void)

…

I propose to move the pci_free_host_bridge() call for the desired exception handling to the end of this function implementation.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=c0d73a868d9b411bd2d0c8e5ff9d98bfa8563cb1#n450

Regards,
Markus

#1 lore raw

Le 18/04/2020 à 22:00, Markus Elfring a écrit :

Quoted 3 lines
Quoted 2 lines

If 'ioremap' fails, we must free 'bridge', as done in other error handling path bellow.

I suggest to improve this change description.

I suggest you stop proposing over and over useless comments. Please just ignore my proposals as I do for your boring, never constructing, replies.

Quoted 4 lines

* Please avoid a typo.

* Is an imperative wording preferred?

* is Melissa still around?

Quoted 6 lines

…

Review static int __init mcf_pci_init(void)

Quoted 2 lines

+++ b/arch/m68k/coldfire/pci.c

(quoted diff) +0 -0
@@ -216,8 +216,10 @@ static int __init mcf_pci_init(void)

…

I propose to move the pci_free_host_bridge() call for the desired

I propose to let patch submitter and maintainer decide about it. I don't need your point of view. I guess that maintainers don't either.

No need to waste time trying to engage any discussion with me. This is the first and very last exchange we will ever have.

Best regards,
CJ

Quoted 6 lines

exception handling to the end of this function implementation.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?idÀd73a868d9b411bd2d0c8e5ff9d98bfa8563cb1#n450

Regards,
Markus