wifi: rtl8xxxu: Add LED control code for RTL8723BU
PATCH v3 1/1 wifi: rtl8xxxu: Add LED control code for RTL8723BU
Software control (on/off) and hardware control (automatic blinking) tested with EDUP EP-N8568.
Signed-off-by Bitterblue Smith <[email protected]>
---
v3:
- Remove unnecessary braces to silence checkpatch
v2:
- More information in the commit message.
--- .../realtek/rtl8xxxu/rtl8xxxu_8723b.c | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+)
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c +22 -0
@@ -1701,6 +1701,27 @@ static s8 rtl8723b_cck_rssi(struct rtl8xxxu_priv *priv, struct rtl8723au_phy_stareturn rx_pwr_all; } +static int rtl8723bu_led_brightness_set (struct led_classdev *led_cdev, +enum led_brightness brightness) +{ +struct rtl8xxxu_priv *priv =container_of (led_cdev, + struct rtl8xxxu_priv, + led_cdev); +u8 ledcfg =rtl8xxxu_read8 (priv,REG_LEDCFG2 ); + ledcfg &=LEDCFG2_DPDT_SELECT ; + +if (brightness ==LED_OFF ) + ledcfg |=LEDCFG2_SW_LED_CONTROL |LEDCFG2_SW_LED_DISABLE ; +else if (brightness ==LED_ON ) + ledcfg |=LEDCFG2_SW_LED_CONTROL ; +else if (brightness ==RTL8XXXU_HW_LED_CONTROL ) + ledcfg |=LEDCFG2_HW_LED_CONTROL |LEDCFG2_HW_LED_ENABLE ; + +rtl8xxxu_write8 (priv,REG_LEDCFG2 , ledcfg); + +return 0 ; +} +struct rtl8xxxu_fileops rtl8723bu_fops = { .identify_chip = rtl8723bu_identify_chip, .parse_efuse = rtl8723bu_parse_efuse,
@@ -1731,6 +1752,7 @@ struct rtl8xxxu_fileops rtl8723bu_fops = { .fill_txdesc = rtl8xxxu_fill_txdesc_v2, .set_crystal_cap = rtl8723a_set_crystal_cap, .cck_rssi = rtl8723b_cck_rssi, + .led_classdev_brightness_set = rtl8723bu_led_brightness_set, .writeN_block_size = 1024, .tx_desc_size = sizeof(struct rtl8xxxu_txdesc40), .rx_desc_size = sizeof(struct rtl8xxxu_rxdesc24),
Signature · 1 line
2.44.0
Quoted 4 lines · Bitterblue Smith
Software control (on/off) and hardware control (automatic blinking) tested with EDUP EP-N8568.
Signed-off-by Bitterblue Smith <[email protected]>
Still warns:
WARNING: Missing a blank line after declarations #28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711: + u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2); + ledcfg &= LEDCFG2_DPDT_SELECT;
Set patchset state to Changes Requested
[v3] wifi: rtl8xxxu: Add LED control code for RTL8723BU