Skip to contentSkip to conversation

revert yenta free_irq on suspend

DISCUSSION [email protected] 4 participants 5 messages Aug 1, 2005 – Aug 3, 2005

lore
Share & tools
lore
#0 lore raw

----- Original Message -----
From: Linus Torvalds <[email protected]>
Date: Sunday, July 31, 2005 9:07 pm
Subject: Re: revert yenta free_irq on suspend

Quoted 11 lines · Dave Airlie
Quoted 2 lines

You said earlier we only should fix drivers that need fixing, but

they> all need fixing

I think you're still talking from a theoretical standpoing, while all my
arguments are practical.

Quoted 6 lines

In _practice_, I hope that

(a) we don't see that very much (ie the people for whom things work
already are a strong argument that this is less of a problem in practice than people try to make it appear)

They may not always be triggered, but they are real bugs. We can't ensure stable PM until they are fixed. If they weren't a real issue, then calling free_irq() in pcmcia probably wouldn't have broken the sound driver we saw in this case.

Quoted 10 lines

(b) drivers, _especially_ on notebooks, are already able to handle an
incoming interrupt with the device in D3 state and returning 0xff for all reads.

In particular, this is exactly the same thing that you get on
a
surprise device removal too.

Quoted 6 lines

iow it really _really_ shouldn't matter that a shared interrupt comes in
after (or before) a device has gone to sleep. Because a driver that can'thandle that schenario is buggy for totally unrelated reasons, and doing a
"free_irq()/request_irq()" pair at suspend time is _not_ the solution!

I understand this. But calling free_irq()/request_irq() still seems to make sense. It's the cleanest and most straightforward approach. It's the easiest way we can ensure there will not be race conditions. An interrupt could be triggered during the device's power transition when it's in between on and off. More importantly, we need this change for runtime power management anyway.

Quoted 6 lines
Quoted 3 lines

This has nothing to do with the issues with highlevel PM interfaces for shutting down hardware, this is do with fixing the drivers in

the> kernel currently and what the correct way to do it is without breaking> someone elses hardware....

Quoted 7 lines

... and I don't think this has _anything_ to do with free_irq/request_irq,
and everything to do with the fact that we can try to make at least the
common drivers "hardened" for unexpected interrupts coming in when the hw
might not be ready for them.

We either need to change every driver to free irqs or "harden" each of them. Freeing irqs obviously seems easier. I propose we make this change in -mm in one pass to avoid bugs like this.

Also, as I said earlier, the better we support OSPM initiated power management, the more likely APM will break. This may be technically unavoidable on some isolated boxes without quirks. I agree with Pavel that "do nothing" may make sense, but it seems some devices may still need to be disabled by the OS. As a real world example, we currently can't turn off cardbus bridges because it breaks APM on a couple of older laptops.

Thanks,
Adam

#1 lore raw
Quoted 3 lines · On Sun, 31 Jul 2005 [email protected] wrote:

We either need to change every driver to free irqs or "harden" each of them.

No. No "either".

Drivers need to be safe from the hw going away, whether it be physically or because it got shut down.

Quoted 1 line

Freeing irqs obviously seems easier.

No.

Freeing irq's DOES NOT HELP.

Listen to me. You need the hardening of the driver anyway for the hotplug case. Freeing irq's doesn't do anything for it, it's just shuffling the real problem under the carpet.

So fix the damn problem _right_, and suddenly freeing the irq doesn't make any difference at all. It's just unnecessary and incorrect complexity.

Linus

#2 lore raw
In reply to [email protected]
Quoted 7 lines · On Sun, 2005-07-31 at 23:03 -0400, [email protected] wrote:

Also, as I said earlier, the better we support OSPM initiated power management, the more likely APM will break. This may be technically unavoidable on some isolated boxes without quirks. I agree with Pavel that "do nothing" may make sense, but it seems some devices may still need to be disabled by the OS. As a real world example, we currently can't turn off cardbus bridges because it breaks APM on a couple of older laptops.

Won't freeing of IRQs cause problems with things like handhelds that actually rely on an interrupt to wake up ?

Ben.

#3 lore raw

Hi!

Quoted 10 lines
Quoted 7 lines

Also, as I said earlier, the better we support OSPM initiated power management, the more likely APM will break. This may be technically unavoidable on some isolated boxes without quirks. I agree with Pavel that "do nothing" may make sense, but it seems some devices may still need to be disabled by the OS. As a real world example, we currently can't turn off cardbus bridges because it breaks APM on a couple of older laptops.

Won't freeing of IRQs cause problems with things like handhelds that actually rely on an interrupt to wake up ?

Well, you probably don't want to free IRQ that is used for wakeup; but if driver is used for wakeup, it probably needs some special handling, anyway (right?).
Pavel

Signature · 1 line
teflon -- maybe it is a trademark, but it should not be.
#4 lore raw
Quoted 10 lines · Pavel Machek

Hi!

Quoted 8 lines
Quoted 7 lines

Also, as I said earlier, the better we support OSPM initiated power management, the more likely APM will break. This may be technically unavoidable on some isolated boxes without quirks. I agree with Pavel that "do nothing" may make sense, but it seems some devices may still need to be disabled by the OS. As a real world example, we currently can't turn off cardbus bridges because it breaks APM on a couple of older laptops.

Quoted 6 lines
Quoted 2 lines

Won't freeing of IRQs cause problems with things like handhelds that actually rely on an interrupt to wake up ?

Well, you probably don't want to free IRQ that is used for wakeup; but if driver is used for wakeup, it probably needs some special handling, anyway (right?).

Not necessarily something the driver itself knows about ... For example, some platforms do a hardware OR between PME and INTA ...

Ben.