Skip to contentSkip to conversation

Adding usb-ctrl from intel-bmc into phosphor-misc

DISCUSSION Wang, Kuiying 3 participants 7 messages May 27, 2020 – May 28, 2020

lore
Share & tools
lore
#0 lore raw

Hi Lei,
What’s your final purpose for this?

Now we already have KCS between host and bmc.

Thanks,
Kwin.

郁雷 yulei.sh at bytedance.com<mailto:openbmc%40lists.ozlabs.org?Subject=Re%3A%20Adding%20usb-ctrl%20from%20intel-bmc%20into%20phosphor-misc&In-Reply-To=%3CCAGm54UEDRmEQVQ-WaRiUa%2BfpxL0UUe-OZ4rwRZHVLTUJBZZb%3DA%40mail.gmail.com%3E> Wed May 27 13:07:45 AEST 2020

There is a script [usb-ctrl][1] hosted in intel-bmc.

It supports the VirtualMedia feature by insert/eject files to the host

as a USB mass-storage device.

Comparing to the existing [state_hook][2] in jsnbd, it supports

multiple UDCs, so it supports mount multiple files.

In addition, I have some updates on the usb-ctrl script to make it

support the USB ECM device, which creates a USB ethernet device

between BMC and the host.

So my proposal is to add the usb-ctrl script into the phosphor-misc

repo so that it gets reviewed and could be used by upstream.

Any ideas?

[1]: https://github.com/Intel-BMC/openbmc/blob/intel/meta-openbmc-mods/meta-common/recipes-core/fw-update/files/usb-ctrl

[2]: https://github.com/openbmc/openbmc/blob/master/meta-phosphor/aspeed-layer/recipes-connectivity/jsnbd/jsnbd/state_hook

--

BRs,

Lei YU

#1 lore raw
Quoted 5 lines · Kuiying

Hi Lei,

What’s your final purpose for this?

The USB ECM device is an ethernet between BMC and Host, so that they could have a real local ethernet between them.

On this internal ethernet, it is possible to do internal communication, e.g. host calls Redfish API to BMC without any outside-network.

Signature · 2 lines
BRs,
Lei YU
#2 lore raw

Ok, it is a working way, we could discuss more detail on your patch review.

Thanks,
Kwin.

-----Original Message-----
From: 郁雷 [mailto:[email protected]]
Sent: Wednesday, May 27, 2020 5:35 PM
To: Wang, Kuiying <[email protected]>
Cc: [email protected]
Subject: RE: Adding usb-ctrl from intel-bmc into phosphor-misc

Quoted 5 lines · Kuiying

Hi Lei,

What’s your final purpose for this?

The USB ECM device is an ethernet between BMC and Host, so that they could have a real local ethernet between them.

On this internal ethernet, it is possible to do internal communication, e.g. host calls Redfish API to BMC without any outside-network.

--
BRs,
Lei YU

#4 lore raw

Hi,

For in-band usb network communication, I recommend that you can use rndis. There is a usb network recipe locates in quanta's layer, you can take it as reference.
https://github.com/openbmc/openbmc/tree/master/meta-quanta/meta-common/network
https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-gsj/recipes-kernel/linux/linux-nuvoton/gsj.cfg#L40

Thanks,
KW
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of 郁雷
Sent: Thursday, May 28, 2020 11:55 AM
To: Wang, Kuiying <[email protected]>
Cc: [email protected]
Subject: Re: [External] RE: Adding usb-ctrl from intel-bmc into phosphor-misc

Quoted 3 lines · Kuiying

Ok, it is a working way, we could discuss more detail on your patch review.

Sure.
The patches are pushed to below series:
https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.openbmc-2Dproject.xyz_c_openbmc_phosphor-2Dmisc_-2B_32877&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=NwkSSvXDL-VLNd7yP7hEpko8v_bzJfl2qzZUmWTmwgs&s=kWiMmX95jKxXwKcpxknJcIlZlsvxE12sGVNow0GPxqg&e=
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

#5 lore raw
Quoted 7 lines · On Thu, May 28, 2020 at 5:02 PM CS20 KWLiu <[email protected]> wrote:

Hi,

For in-band usb network communication, I recommend that you can use rndis. There is a usb network recipe locates in quanta's layer, you can take it as reference.
https://github.com/openbmc/openbmc/tree/master/meta-quanta/meta-common/network
https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-gsj/recipes-kernel/linux/linux-nuvoton/gsj.cfg#L40

Yup, it looks like both rndis and ecm work. Could you kindly elaborate why you recommend rndis?

Btw, I see there are two different scripts in meta-quanta layer, one uses rndis and the other uses ecm:
https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-gsj/recipes-gsj/usb-network/files/usb_network.sh
https://github.com/openbmc/openbmc/blob/master/meta-quanta/meta-common/network/usb-network/usb-network.sh

Would you mind if you could merge the scripts into
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-misc/+/32878?

#6 lore raw

Hi

RNDIS is a Microsoft standard, it is not only supported in Windows OS but also in other OS platforms. So, this is an option we can provide as well.

I will check your patch to see how to merge rndis script.

Thanks.
-----Original Message-----
From: 郁雷 <[email protected]>
Sent: Thursday, May 28, 2020 5:34 PM
To: CS20 KWLiu <[email protected]>
Cc: Wang, Kuiying <[email protected]>; [email protected]
Subject: RE: Adding usb-ctrl from intel-bmc into phosphor-misc

Quoted 16 lines · On Thu, May 28, 2020 at 5:02 PM CS20 KWLiu <[email protected]> wrote:

Hi,

For in-band usb network communication, I recommend that you can use rndis. There is a usb network recipe locates in quanta's layer, you can take it as reference.
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbm
c_openbmc_tree_master_meta-2Dquanta_meta-2Dcommon_network&d=DwIBaQ&c=u e8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPx PxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=xxw O5BMx8cMwRXtNZ-ZGTPgCDrgIy5eXfhEMorF-FNY&e=
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbm
c_openbmc_blob_master_meta-2Dquanta_meta-2Dgsj_recipes-2Dkernel_linux_ linux-2Dnuvoton_gsj.cfg-23L40&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UF DmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0P bqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=iOvDtZiIJKoEIQBa6UaKNhWbUQJhDH- tuSlnDnDP0dg&e=

Yup, it looks like both rndis and ecm work. Could you kindly elaborate why you recommend rndis?

Btw, I see there are two different scripts in meta-quanta layer, one uses rndis and the other uses ecm:
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbmc_openbmc_blob_master_meta-2Dquanta_meta-2Dgsj_recipes-2Dgsj_usb-2Dnetwork_files_usb-5Fnetwork.sh&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=mDp-Bk9eSS8-xyRsSebF2Svn-omhZyA9eINaIrP7kd0&e=
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openbmc_openbmc_blob_master_meta-2Dquanta_meta-2Dcommon_network_usb-2Dnetwork_usb-2Dnetwork.sh&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=J6AOmmmisgGa-TvoqfwTrtrx6M1cJGyoEPNbYnfMWMU&e=

Would you mind if you could merge the scripts into https://urldefense.proofpoint.com/v2/url?u=https-3A__gerrit.openbmc-2Dproject.xyz_c_openbmc_phosphor-2Dmisc_-2B_32878-3F&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=7g2D1XDc1ET3CnY1ySnaWQXPxPxfpLww1MiDbLW4v8Q&m=B-UYt0PbqENhhFwPReR07OF8di1nauIg7z0r3u2ZpqM&s=z5xxtqsQN3WqZu4mkS98aTmGRZ1O-Y6spzjtLzcBUes&e=
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.