Skip to contentSkip to conversation

KVM: Fix the indentation to match coding style

PATCH Applied Haiwei Li 3 participants 3 messages May 18, 2020

Subsystems (3)
lore
Share & tools
lore

Haiwei Li

author
#0 lore raw

PATCH 1/1 KVM: Fix the indentation to match coding style

From: Haiwei Li <[email protected]>

There is a bad indentation in next&queue branch. The patch looks like fixes nothing though it fixes the indentation.

Before fixing:

                if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                        kvm_skip_emulated_instruction(vcpu);
                        ret = EXIT_FASTPATH_EXIT_HANDLED;
               }
                break;
        case MSR_IA32_TSCDEADLINE:

After fixing:

                if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                        kvm_skip_emulated_instruction(vcpu);
                        ret = EXIT_FASTPATH_EXIT_HANDLED;
                }
                break;
        case MSR_IA32_TSCDEADLINE:
---
 arch/x86/kvm/x86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/x86.c +1 -1
index 471fccf..446f747 100644
@@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct kvm_vcpu *vcpu)
                if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                        kvm_skip_emulated_instruction(vcpu);
                        ret = EXIT_FASTPATH_EXIT_HANDLED;
-               }
+               }
                break;
        case MSR_IA32_TSCDEADLINE:
                data = kvm_read_edx_eax(vcpu);

--
1.8.3.1

Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Haiwei Li

From: Haiwei Li <[email protected]>

There is a bad indentation in next&queue branch. The patch looks like fixes nothing though it fixes the indentation.

Before fixing:

                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
                }
                 break;
         case MSR_IA32_TSCDEADLINE:
Quoted 9 lines

After fixing:

                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
                 }
                 break;
         case MSR_IA32_TSCDEADLINE:
Quoted 22 lines
---
  arch/x86/kvm/x86.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/x86.c +1 -1
index 471fccf..446f747 100644
@@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
 kvm_vcpu *vcpu)
                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
-               }
+               }
                 break;
         case MSR_IA32_TSCDEADLINE:
                 data = kvm_read_edx_eax(vcpu);

--
1.8.3.1

maintainer Applied
#2 lore raw
In reply to Haiwei Li
Quoted 41 lines · Haiwei Li

From: Haiwei Li <[email protected]>

There is a bad indentation in next&queue branch. The patch looks like fixes nothing though it fixes the indentation.

Before fixing:

                if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) { kvm_skip_emulated_instruction(vcpu); ret = EXIT_FASTPATH_EXIT_HANDLED;
               }
                break;
        case MSR_IA32_TSCDEADLINE:

After fixing:

                if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) { kvm_skip_emulated_instruction(vcpu); ret = EXIT_FASTPATH_EXIT_HANDLED;
                }
                break;
        case MSR_IA32_TSCDEADLINE:

---
 arch/x86/kvm/x86.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/x86.c +1 -1
index 471fccf..446f747 100644
@@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
 kvm_vcpu *vcpu)
                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
-               }
+               }
                 break;
Quoted 5 lines

        case MSR_IA32_TSCDEADLINE:
                data = kvm_read_edx_eax(vcpu);

Signature · 1 line
1.8.3.1

Queued, thanks.

Paolo