Skip to contentSkip to conversation

x86-64 support

PATCH Andi Kleen 2 participants 3 messages Aug 28, 2004 – Sep 3, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw

Takao Indoh <[email protected]> writes:

Hallo,

Quoted 5 lines

Hi all,

Here is the latest diskdump patch for kernel 2.6.8.1.

- Supports x86_64

Thanks for doing this work.

Quoted 7 lines

When I tested diskdump on x86-64 machine, I found that memory dump of the following two areas failed.

1) 04000000 - 07ffffff
2) around last two page

Memory dump of the area 2) failed because page->flag was broken.

Broken in what way? That should probably just be fixed in the core kernel.

Quoted 20 lines

So I compare PFN to page_to_pfn(pfn_to_page(PFN)) and skip this PFN if these value is different.

		page = pfn_to_page(nr);
		if (nr != page_to_pfn(page)) {
			/* page_to_pfn() is called from kmap_atomic().
			 * If page->flag is broken, it specified a wrong
			 * zone and it causes kmap_atomic() fail.
			 */
			Err("Bad page. PFN %lu flags %lx\n",
			    nr, (unsigned long)page->flags);
			memset(scratch + blk_in_chunk * PAGE_SIZE, 0,
			       PAGE_SIZE);
			sprintf(scratch + blk_in_chunk * PAGE_SIZE,
				"Bad page. PFN %lu flags %lx\n",
			 	 nr, (unsigned long)page->flags);
			goto write;
		}
Quoted 2 lines

Memory dump of the area 1) failed because this area was not mapped to vaddr. Diskdump checks page using page_is_ram() and maps it using

Yes, this is done intentionally because the IOMMU is not 100% cache coherent in the way Linux uses it and accesses to the aperture area by the CPU are not allowed. To prevent mistakes or the CPU prefetching by its own into it it is unmapped.

SLAB DEBUG can cause the same thing and even on other architectures, so you really need to handle it generically.

Quoted 2 lines

kmap_atomic(). In the area 1), both page_is_ram() and kmap_atomic() return true, but page is not attached to the page table.

kmap_atomic() on 64bit always just returns the pointer, it's a nop. Even on 32bit it cannot fail.

Quoted 8 lines

I think this area is AGP Aperture. I found this message in the dmesg.

PCI-DMA: Disabling AGP.
PCI-DMA: aperture base @ 4000000 size 65536 KB
PCI-DMA: Reserving 64MB of IOMMU area in the AGP aperture

To resolve this problem, I check page using kern_addr_valid() before kmap_atomic().

kern_addr_valid is probably not a bad way to solve it, although it is a bit costly.

When the page is not mapped you could always map it on your own with ioremap(), but that address cannot be used for any DMA, so it may not work. Skipping them is probably ok.

-Andi

#2 lore raw

Hello,

Thanks for comment.

Quoted 10 lines · Andi Kleen
Quoted 7 lines

When I tested diskdump on x86-64 machine, I found that memory dump of the following two areas failed.

1) 04000000 - 07ffffff
2) around last two page

Memory dump of the area 2) failed because page->flag was broken.

Broken in what way? That should probably just be fixed in the core kernel.

page->flag around last two page is 0.
I tested on another machine and found all of page->flag is correct. So this problem may be dependent on machine.

Regards,
Takao Indoh

#3 lore raw
Quoted 6 lines · Takao Indoh
Quoted 6 lines
Quoted 6 lines

When I tested diskdump on x86-64 machine, I found that memory dump of the following two areas failed.

1) 04000000 - 07ffffff
2) around last two page

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Memory dump of the area 2) failed because page->flag was broken.

Broken in what way? That should probably just be fixed in the core kernel.

page->flag around last two page is 0.
I tested on another machine and found all of page->flag is correct. So this problem may be dependent on machine.

page->flag of the following two page is 0...

PFN 1310719
PFN 1441791

Regards,
Takao Indoh