f2fs:remove unnecessary condition judgment
Subsystems (2)
PATCH 1/3 f2fs:remove unnecessary condition judgment
Remove the unnecessary condition judgment, because 'max_slots' has been initialized to '0' at the beginging of the function, as following:
if (max_slots)
max_len = 0;
Signed-off-by Yuan Zhong <[email protected]>
--- fs/f2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/dir.c +1 -1
@@ -139,7 +139,7 @@ struct f2fs_dir_entry *find_target_dentry(struct qstr *name, int *max_slots, !memcmp(d->filename[bit_pos], name->name, name->len)) goto found; -if (max_slots && *max_slots >=0 && max_len > *max_slots) { +if (max_slots && max_len > *max_slots) { *max_slots = max_len; max_len =0 ; }
Signature · 7 lines
1.7.9.5 ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
Hi Yuan,
Quoted 5 lines · Yuan Zhong
Remove the unnecessary condition judgment, because '
max_slots' has been initialized to '0' at the beginging of the function, as following:
if (max_slots)max_len = 0;
There is wrong statement. It should be fixed as *max_slot = 0.
Thanks,
Quoted 31 lines
Signed-off-by Yuan Zhong <[email protected]>--- fs/f2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/f2fs/dir.c +1
-1@@ -139,7 +139,7 @@ struct f2fs_dir_entry *find_target_dentry(struct qstr *name, int *max_slots, !memcmp(d->filename[bit_pos], name->name, name->len)) goto found; -if (max_slots && *max_slots >=0 && max_len > *max_slots) { +if (max_slots && max_len > *max_slots) { *max_slots = max_len; max_len =0 ; }Signature · 11 lines
1.7.9.5 ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel