Skip to contentSkip to conversation

drivers: firmware: fix kconfig dependency on CRYPTO

PATCH New Julian Braha 1 participant 1 message Feb 19, 2021 EFI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: firmware: fix kconfig dependency on CRYPTO

commit 72304490d9df7d6af2e6851cc5762908abd52889

Author: Julian Braha <[email protected]>
Date:   Fri Feb 19 18:36:22 2021 -0500

drivers: firmware: fix kconfig dependency on CRYPTO

When EFI_EMBEDDED_FIRMWARE is enabled and CRYPTO is disabled, Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]

This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256, without depending on or selecting CRYPTO, despite that config option being subordinate to CRYPTO.

drivers/firmware/efi/Kconfig +1 -0
index 2c3dac5ecb36..f914da9845ac 100644
@@ -248,6 +248,7 @@ endmenu
 config EFI_EMBEDDED_FIRMWARE
        bool
        depends on EFI
+       select CRYPTO
        select CRYPTO_LIB_SHA256
 
 config UEFI_CPER