Skip to contentSkip to conversation

CFS: Add hierarchical tree-based penalty.

PATCH William Pitcock 1 participant 1 message Oct 12, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi,

Quoted 8 lines · ----- "Peter Zijlstra
Quoted 1 line · William Pitcock

Yes, this should be a multiplication I believe, not a divide. My

original

Quoted 1 line

code had this as a multiplication, not a division, as does the new

patch.

Quoted 3 lines

However, I think:

Quoted 9 lines
Quoted 3 lines
    vruntime >>= tsk->fork_depth;

would do the job just as well and be faster.

That's still somewhat iffy as explained, vruntime is the absolute service level, multiplying that by 2 (or even more) will utterly upset
things.

Yes, this is why I thought that doing a division would be better.

Quoted 20 lines

Imagine two runnable tasks of weight 1, say both have a vruntime of 3 million, seconds (there being two, vruntime will advance at 1/2 wall-time).

Now, suppose you wake a third, it too had a vruntime of around 3 million
seconds (it only slept for a little while), if you then multiply that with 2 and place it at 6 mil, it will have to wait for 6 mil seconds before it gets serviced (twice the time of the 3 mil difference in service time between this new and the old tasks).

So, theory says the fair thing to do is place new tasks at the weighted
average of the existing tasks, but computing that is expensive, so what
we do is place it somewhere near the leftmost task in the tree.

Now, you don't want to push it out too far to the right, otherwise we get starvation issues and people get upset.

Quoted 6 lines

So you have to somehow determine a window in which you want to place this task and then vary in that depending on your fork_depth.

Simply manipulating the absolute service levels like you propose isn't
going to work.

I think I have a solution to this. Presently waiting on a kernel rebuild on my laptop so I can test.

William